Category: Upgrade Blocker

Users can sign in, but the groups they are in are not being synced.

Worked ok in version 5. I've upgraded to version 18.3 via version 12 and now I'm stuck.

No errors in the tiki log.

The only odd line is this:
Searching for user information with filter: (cn=wiki_user) at line 280 in /srv/tiki-18.3/lib/auth/ldap.php

I would expect the filter to read "memberUid" ..
{img fileId="1283" thumb="box"}

I've tried the fix here: https://dev.tiki.org/item5657, but just a got a white-screen of death :-)

{syntax type="tiki" editor="plain"}
You can't see or edit the left or right column modules on tiki-admin_modules.php any more (without clicking show hidden modules, and when you save anything they get hidden again).

Critical regression, release blocker!

In tiki-calendar_nav.tpl the display of calendar dates is formed (template), but in a IMHO rather bizarre mix of hard-coded and localizable syntax, which
a) does not make use and thus circumvents the existing user pref for date formats and
b) effectively makes correct localization impossible.

I quote from this template a code snippet:

{CODE(colors="tiki")}
{if $viewlist ne 'list' or $prefs.calendar_list_begins_focus ne 'y'}
{if $calendarViewMode eq 'month'}
{$daystart|tiki_date_format:"%B %Y"}
{elseif $calendarViewMode eq 'week'}
{* test display_field_order and use %d/%m or %m/%d *}
{if ($prefs.display_field_order eq 'DMY') || ($prefs.display_field_order eq 'DYM') || ($prefs.display_field_order eq 'YDM')}
{$daystart|tiki_date_format:"{tr}%d/%m{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%d/%m{/tr}/%Y"}
{else}
{$daystart|tiki_date_format:"{tr}%m/%d{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%m/%d{/tr}/%Y"}
{/if}
{else}
{$daystart|tiki_date_format:"%B %Y"} - {$dayend|tiki_date_format:"%B %Y"}
{/if}
{else}
{$daystart|tiki_date_format:"{tr}%m/%d{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%m/%d{/tr}/%Y"}
{/if}
{CODE}

So there is some testing for localized date format, but it assumes that only the order of day and month may be swapped through translation? This only works inside the USA or partly in the UK. It does not work in Germany, and not in Japan and possibly conflicts with other countries as well.

Germany uses
{CODE(colors="tiki")}
%d.%m.%Y
{CODE}

Japan uses
{CODE(colors="tiki")}
%Y-%m-%d
{CODE}

Look at the peculiar coding in tiki-calendar_nav.php. To magnify, I have extracted one example that clearly shows the logical error in it:

{CODE(colors="tiki")}
{$dayend|tiki_date_format:"{tr}%d/%m{/tr}/%Y"}
{CODE}

The year was excluded from translation and also the slash that comes before the year (at least in the USA...). So the slash cannot be removed by custom.php, because it is outside the translation. And it would be even worse for a localization into Japanese, because of their year leading the date...

It would be far better if date format was used in the form of the user pref that exists! But for a faster "quick resolution" moving the %Y into the translation braces would do the trick, and later introduce the "proper" way... Thanks.

When changing a wiki structure with drag and drop in tiki-edit_structure.php, the 'save' button doesn't appear as it does in Tiki 18/19.
It's keeps being hidden by css with display:none, beside that it also doesn't work; it will not save the changes.

Please see as showed here, it's possible to drag a new page in to the structure but there is no save button.
http://wobow-11900-7179.show2.tikiwiki.org/tiki-edit_structure.php?page_ref_id=1

On Tiki23, Tiki24 and master there is a regression as the user preferences "Language" is "forced" by default to French.

On a new installation ===as soon=== as I enable Multilingual features the tiki displays in French. (the other options like default language are still on English).

{img fileId="1707" thumb="box"}
{img fileId="1708" thumb="box"}

It seems the user preferences are set by default with the French language and are taking over even if I didn't set anything.

{img fileId="1709" thumb="box"}

It is also possible as the option "Users can choose the language of their interface" that is enable by default (even if multilingual is disable) BUT this setting is not accessible for the user as "User preferences screen " is disable by default. They are needed together !
If "Users can choose the language of their interface" then obviously they should be able to do it (User preferences screen should be enable) else they will be stuck with a possible language selection they can't change. (like what we have now).

In Tiki23 a new dropdown was added to improve the UX and action selection.
Something nice BUT once you upgrade it will resets the previous and existing scheduled tasks without warning.

See : https://gitlab.com/tikiwiki/tiki/-/commit/a77af6f7da9f41e647de91693d8f0edbe0110616

We receive many issues while people try to register. So I went to test out what is going on... While testing new user registration in new incognito mode Chrome I got this when I submitted the filled in form:
{img fileId="1361" thumb="box"}

Not a good feedback to the user trying to register :(

Steps to reproduce:

# open new incognito window
# go to https://tiki.org/login
# click the Register link in the login form which brings you to https://tiki.org/tiki-register.php?key=randomstring
# fill in the form and click "Register" button
# you get the error screen

__Anyway, the user was created.__
As an admin I received immediately a watch notification email first:
^__User joined Registered__
The user lucitest joined Registered%%%
at: Sun 23 Feb 2020 17:13 CET^

Then --after some minutes (17:21 CET)-- 17:14 CET I received "Community Members Information" tracker email about the Item Creation too __with no link to validate the user__ (but at that time I validated the test user manually already).

We also receive many registration attempts (in comparison as seen while watching user joining Registered group) __without__ any tracker or validation link emails coming out / being received at all.
---
Confirmed sadly {sign user="jonnybradley" datetime="2020-03-09T17:22:33+00:00"}

Same as Bernards report but creating a Show Instance for Tiki 21x (if that's possible)

See https://dev.tiki.org/item7496-Not-possible-to-add-a-file-in-a-tracker-item-tracker-field-file-Data-is-lost

It is not possible anymore to save a wiki page (or a tracker item) with an HTML plugin.

Go to :
Add the following code on the page:
{CODE()}
{HTML()}
<h1>Youppi</h1>
{HTML}
{CODE}
Save and you will see this error:
{CODE()}
Fatal error: Uncaught Error: Object of class Laminas\Mime\Message could not be converted to string in /var/www/virtual/dev.tiki.org/html/lib/webmail/tikimaillib.php:300 Stack trace: #0 /var/www/virtual/dev.tiki.org/html/lib/tikilib.php(5492): TikiMail->send() #1 /var/www/virtual/dev.tiki.org/html/lib/tikilib.php(5447): TikiLib->plugin_pending_notification() #2 /var/www/virtual/dev.tiki.org/html/lib/tikilib.php(5398): TikiLib->plugin_post_save_actions() #3 /var/www/virtual/dev.tiki.org/html/lib/core/Tiki/Event/Lib.php(27): TikiLib->object_post_save() #4 /var/www/virtual/dev.tiki.org/html/lib/core/Tiki/Event/Manager.php(83): Tiki_Event_Lib->__invoke() #5 /var/www/virtual/dev.tiki.org/html/lib/core/Tiki/Event/Chain.php(22): Tiki_Event_Manager->internalTrigger() #6 /var/www/virtual/dev.tiki.org/html/lib/core/Tiki/Event/Manager.php(83): Tiki_Event_Chain->__invoke() #7 /var/www/virtual/dev.tiki.org/html/lib/core/Tiki/Event/Chain.php(22): Tiki_Event_Manager->internalTrigger() #8 /var/www/virtual/dev.tiki.org/html/lib/core/Tiki/E in /var/www/virtual/dev.tiki.org/html/lib/webmail/tikimaillib.php on line 300
{CODE}

{syntax type="tiki" editor="plain"}
The button "Upload" is gone from the upload form on dev.t.o

See: https://ibb.co/5g0KW0ZG

__Test by luci:__
{img fileId="3247" thumb="box"}

Cannot reproduce. Seems to work? The button is not labeled "Upload" but "Insert" but works for me?

{img fileId="3248" thumb="box"}

The pages are now listed twice at https://dev.tiki.org/tiki-listpages.php

See:
{img fileId="1583" thumb="box"}

I wonder why I did not see this before... But now it's clear to see.

The function to count page accesses is completely (!) out of order. My site contains > 300 pages. ALL OF THEM have an access counter in the "list pages" view of 0. Zero, nada, nothing. During my efforts to create a readable German translation I have visited numerous pages time and again, there must have been thousands of page impressions, and yet every single page is counted as having zero visits...

The absolute minimum for every page would be the number of page revisions plus one, because every page is visited after creation or modification. But all of the >300 pages list as 0...

And again, the need of a bug category "LOSS OF DATA" arises...

The GUI layout in tiki-calendar_edit_item.php breaks if localization comes into play. Look at the screenshot (attachment) to see these issues, that surface when you want to introduce a repeated event. They are:
a) in "monthly" all ordinals below 10 have a leading zero, which is unnessary. It would do no harm, but surprisingly the leading 0 is separated by the number with a space, which together render wider than the space that was allocated for that, leaving only the leading 0 visible... There is no dot, although ordinals in German have a dot "sixth" is spelled "6." in German.
b) in "yearly", where you can for instance define "every 6th of a month", there is the dot, but as a text input field? Actually you cannot write in there, but is is layouted as a text input field (white background). And here also the width is highly insufficient.

c) I cannot translate the "End period" string. Even if I add the array_merge to custom.php (see the bug report for that). And in tiki-calendar_edit_item.php I do see tr in curly braces, so it should respond to language.php and custom.php, but it doesn't?

{syntax type="tiki" editor="plain"}
Wow, toolbars are seriously messed up ((File a big|here))... what isn't broken in 30.x?

Anyway, on doc.tiki.org and all my v29+ tikis the plugin help has disappeared from the help popup. Here however it has appeared as a separate {icon name=plugin} icon, so presumably whoever broke this hasn't done an upgrade script (that works)

Also no preview on this text area? Wow...

I seem to have a plugin that needs approval on a page that hasn't been edited since February, following an update in the past few days. {sign user="jonnybradley" datetime="2023-06-15T09:45:32+00:00"}

It says it's a {CODE()}{box}{CODE} plugin needing approval, but it's coming back from a {CODE()}{list}{CODE} plugin returning -+^No results for query.^+-

This is in a tiki syntax page.

As discussed in the devlist:
I can confirm now a nasty regression introduced in Tiki22.x at some point. (between 2 month ago and now)

It broke filters (item link and item list)

It may be related of tracker field "real" life as I saw the BLOB/TEXT error on a field that was added at some point and not all the items have been saved with it (math field).
(console.php recalc doesn’t seems to be in Tiki22)

{img fileId="1508" thumb="box"}

List of the files reverted to have my Tiki back to work (updated, created, deleted):
{CODE()}
reverted:
.editorconfig
_htaccess
changelog.txt
copyright.txt
db/tiki-db.php
db/tiki.sql
doc/devtools/release.php
doc/devtools/satis.json
installer/composer-patches/jcbrand-conversejs_remove-native-javascript-for-bootstrap.patch
installer/schema/20101230_create_top_modules_tiki.php
installer/schema/20110115_create_bottom_modules_tiki.php
installer/schema/20110201_c_code_to_user_modules_tiki.php
lang/ar/language.php
lang/bg/language.php
lang/ca/language.php
lang/cn/language.php
lang/cs/language.js
lang/cs/language.php
lang/cy/language.php
lang/da/language.php
lang/de/language.php
lang/el/language.php
lang/en-uk/language.php
lang/en/language.php
lang/es/language.php
lang/fa/language.php
lang/fi/language.php
lang/fj/language.php
lang/fr/language.php
lang/fy-NL/language.php
lang/gl/language.php
lang/he/language.php
lang/hr/language.php
lang/hu/language.php
lang/id/language.php
lang/is/language.php
lang/it/language.php
lang/iu-iq/language.php
lang/iu-ro/language.php
lang/iu/language.php
lang/ja/language.php
lang/ko/language.php
lang/lt/language.php
lang/nds/language.php
lang/nl/language.php
lang/no/language.php
lang/pl/language.php
lang/pt-br/language.php
lang/pt/language.php
lang/rm/language.php
lang/ro/language.php
lang/ru/language.php
lang/sb/language.php
lang/si/language.php
lang/sk/language.php
lang/sl/language.php
lang/sq/language.php
lang/sr-latn/language.php
lang/sv/language.php
lang/sw/language.php
lang/th/language.php
lang/tr/language.php
lang/tv/language.php
lang/tw/language.php
lang/uk/language.php
lang/ur/language.php
lang/vi/language.php
lib/blogs/bloglib.php
lib/categories/categlib.php
lib/comments/commentslib.php
lib/core/H5P/editor.js
lib/core/Math/Formula/Function/ForEach.php
lib/core/Math/Formula/Function/Subtotal.php
lib/core/Perms.php
lib/core/Perms/ResolverFactory/CategoryFactory.php
lib/core/Perms/ResolverFactory/ObjectFactory.php
lib/core/Search/Formatter.php
lib/core/Search/Indexer.php
lib/core/Search/Query/WikiBuilder.php
lib/core/Services/Cypht/Controller.php
lib/core/Services/Edit/PluginController.php
lib/core/Services/H5P/Controller.php
lib/core/Services/Tracker/Controller.php
lib/core/Services/Tracker/TabularController.php
lib/core/Services/Tracker/Utilities.php
lib/core/Tiki/Command/GetStringsCommand.php
lib/core/Tiki/MailIn/Source/Imap.php
lib/core/Tiki/MailIn/Source/Pop3.php
lib/core/Tiki/MemoryLimit.php
lib/core/Tiki/Profile/InstallHandler/WikiPage.php
lib/core/Tiki/SabreDav/Utilities.php
lib/core/Tiki/Sitemap/AbstractType.php
lib/core/Tiki/Sitemap/Generator.php
lib/core/Tiki/Sitemap/Type/Articles.php
lib/core/Tiki/Sitemap/Type/Blog.php
lib/core/Tiki/Sitemap/Type/Forums.php
lib/core/Tiki/Sitemap/Type/Page.php
lib/core/Tracker/Field/GroupSelector.php
lib/core/Tracker/Field/ItemsList.php
lib/core/Tracker/Field/Math.php
lib/core/Tracker/Filter/Collection.php
lib/core/Tracker/Rule/Definition.php
lib/core/Tracker/Rule/Type/Collection.php
lib/core/Tracker/Rule/Type/Text.php
lib/cypht/integration/classes.php
lib/cypht/modules/tiki/general_modules.php
lib/cypht/modules/tiki/setup.php
lib/cypht/site.js
lib/filegals/filegallib.php
lib/filegals/h5plib.php
lib/gitlib.php
lib/headerlib.php
lib/jquery_tiki/elfinder/tiki-elfinder.js
lib/jquery_tiki/inline_edit.js
lib/jquery_tiki/pluginedit.js
lib/jquery_tiki/tiki-jquery.js
lib/jquery_tiki/wikiplugin-pivottable.js
lib/language/CollectFiles.php
lib/parser/parserlib.php
lib/prefs/feature.php
lib/setup/twversion.class.php
lib/smarty_tiki/modifier.sefurl.php
lib/smarty_tiki/modifier.slug.php
lib/structures/structlib.php
lib/test/rating/AggregationTest.php
lib/tiki-js.js
lib/tikilib.php
lib/toolbars/toolbarslib.php
lib/trackers/trackerlib.php
lib/userslib.php
lib/vue/duration/DurationPicker.vue
lib/vue/duration/DurationPickerEditor.vue
lib/vue/duration/DurationPickerModal.vue
lib/vue/duration/DurationPickerTitle.vue
lib/vue/duration/styles.css
lib/wiki-plugins/wikiplugin_customsearch.php
lib/wiki-plugins/wikiplugin_cypht.php
lib/wiki-plugins/wikiplugin_group.php
lib/wiki-plugins/wikiplugin_pivottable.php
lib/wiki/editlib.php
lib/xmpp/ConverseJS.php
lib/xmpp/css/conversejs.css
lib/xmpp/js/conversejs-tiki-oauth.js
lib/xmpp/js/conversejs-tiki.js
README
robots.txt
route.php
templates/admin/include_security.tpl
templates/admin/include_trackers.tpl
templates/categorize.tpl
templates/database_connection_error.html
templates/filter_control/drop_down.tpl
templates/freetag.tpl
templates/header.tpl
templates/tiki-admin_calendars.tpl
templates/tiki-admin_categories.tpl
templates/tiki-admin_orphaned.tpl
templates/tiki-admin_sitemap.tpl
templates/tiki-admin_tracker_fields.tpl
templates/tiki-admingroups.tpl
templates/tiki-calendar.tpl
templates/tiki-edit_article.tpl
templates/tiki-edit_blog.tpl
templates/tiki-forums.tpl
templates/tiki-list_trackers.tpl
templates/tiki-upload_file.tpl
templates/tiki-view_forum.tpl
templates/tracker/import.tpl
templates/tracker/remove_fields.tpl
templates/tracker_actions.tpl
templates/tracker_sync/clone_remote.tpl
templates/trackerinput/duration.tpl
templates/trackerinput/userpreference.tpl
templates/wiki-plugins/wikiplugin_files.tpl
templates/wiki-plugins/wikiplugin_pivottable.tpl
templates/wiki-plugins/wikiplugin_subscribenewsletter.tpl
templates/wizard/changes_doc_page_iframe.tpl
templates/wizard/changes_new_in_22.tpl
tiki-admin_categories.php
tiki-admin_modules.php
tiki-caldav.php
tiki-calendar_edit_item.php
tiki-check.php
tiki-forums.php
tiki-index.php
tiki-login.php
tiki-setup.php
tiki-upload_file.php
tiki-user_preferences.php
tiki-view_forum_thread.php
vendor_bundled/composer.json
vendor_bundled/composer.lock

db/tiki-secdb_22.0_mysql.sql

db/tiki-secdb_22.1_mysql.sql
installer/schema/20210115_add_trackerfields_sefurl_tiki.sql
lib/core/Math/Formula/Function/PregReplace.php
lib/core/Search/Formatter/ValueFormatter/Url.php
lib/core/Services/Edit/Utilities.php
lib/core/Tracker/Rule/Operator/CollectionContainsUsername.php
lib/core/Tracker/Rule/Operator/TextIsUsername.php
lib/validators/validator_smarty.php
templates/examples/search/h5p.tpl
templates/examples/search/simple_table.tpl
tiki-robots.php
{CODE}

{syntax type="tiki" editor="plain"}
Uploading a file on tiki-upload_file.php shows an error when uploading anything:
-+UploadAjaxError: fail to POST tiki-ajax_services.php?controller=file&action=upload 500+-

This happens in -+\Services_File_Controller::action_upload+- on the line that runs -+updateDeleteAfter+- (210 in master currently), and it is because the values -+$input->deleteAfter+-0 and -+$input->deleteAfter_unit+- are now jitFilter objects, and not integers any more.

Also, the "Automatic upload" checkbox has gone missing, and from what i can tell, it is unzipping active files automatically and i need it not to currently.

{syntax type="tiki" editor="plain"}
On master, any page I save have the value of 1 added for the Properties: Description and Title.
All my pages have now the title of "1".

It is coming back each time I edit a page, I have to fix manually for each editing.

It is possible more options are affected, I could see only these for the options/features I enabled.

Under TikiWIki 21(.2) only the page title is displayed in the search results list, but no longer text in the content section.
See also the forum post: https://tiki.org/forumthread75156-Search-content-section-is-empty

We tested once in the demo area on tiki.org.
There, pages with Lorem ipsum content were created and then we searched for Lorem.
All pages were listed as results but no content was displayed.

In the local test with newly created databases with TikiWiki 18.2 and TikiWiki 21.2, the text content appears under 18.2 but under 21.2 a number instead:

Even rebuilding the search index does not change this.

Example Link:
http://webclassix-12006-7532.show2.tikiwiki.org/tiki-searchindex.php?filter%7Econtent=lorem&sort_mode=score_ndesc
{img fileId="1447" thumb="box"}

Site with content:
http://webclassix-12006-7532.show2.tikiwiki.org/tiki-index.php?page=testpage&highlight=lorem
{img fileId="1448" thumb="box"}

After it has been updated to Tiki 24, we have "No results for query." at https://doc.tiki.org/Video-Tutorials

{syntax type="tiki" editor="plain"}
On my last version of Tiki30 (updated 20200414) several modules are gone especially menus.

Seems that only menu 42 survived the update (when I'm logged as admin).
Other custom modules are gone also.

see:
https://ibb.co/5g0KW0ZG
https://ibb.co/GQ6hn17k

Was hard to diagnose...

After upgrading a Tiki20 to Tiki21 I was able to rebuilt the index:

{CODE()}
[03-03-2020 12:05] Started rebuilding index... logging to file: /var/tmp/Search_Indexer_mysql_tsaharoniki_tiki21_console.log
Unified search engine: MySQL, version 5.7.26
error: The search index could not be rebuilt.
Expression #1 of ORDER BY clause is not in SELECT list, references column 'tsaharoniki_tiki21.ttif0.value' which is not in SELECT list; this is incompatible with DISTINCT
{CODE}

The log:
{CODE()}
2020-03-03T10:47:35+02:00 ERR (3): WARNING: PDOStatement::execute(): SQLSTATE[HY000]: General error: 3065 Expression #1 of ORDER BY clause is not in SELECT list, references column 'tsaharoniki_tiki21.tti$
{CODE}

Checking the item (I had to find it!) I found out that having a sort parameter in an itemList field was responsible.

{img fileId="1373" thumb="box"}

Once removed it worked.
This is very problematic when you have financial data as any report must be ordered (by date).

Update: {sign user="Bsfez" datetime="2020-03-08T17:20:40+00:00"}
Same same in Tiki 20
It may be related to the removal of the "split" function in PHP 7+;
https://whmcs.community/topic/290945-how-to-sort-smarty-variables-in-whmcs-76/

Update: {sign user="Bsfez" datetime="2021-03-02T14:41:19+00:00"}
It is now also on Tiki18.8 as it was signaled to me by another Tiki user (tested with him)
I tried to reproduce on the show instance but there is a bug with field list on the trackers and it is not possible to recreate the caches.
{img fileId="1514" thumb="box"}