Loading...
 
Skip to main content

H5P feature partially breaks File Gallery when activated

  • Tracker item actions
Trackers
Items
Status
Pending
Subject
H5P feature partially breaks File Gallery when activated
Version
21.x
Category
  • Bug
  • Error
  • Regression
Feature
File Gallery (elFinder or standard UI)
H5P
Resolution status
Works For Me
Submitted by
Torsten Fabricius
Volunteered to solve
Jonny Bradley
Keep informed
John Morris, luci, Xavier de Pedro
Lastmod by
Torsten Fabricius
Rating
(0)
Description

Please mind that the described H5P related bug occurs whilst not using H5P, but using the file gallery when H5P is activated. Deactivating H5P makes the bug disappear.

  1. Upgraded existing Tiki 19 to Tiki 21.x (future, currently trunk) at 16 Oct 2019.
  2. Activated H5P
    1. created an extra new file gallery for H5P
    2. did not (yet) set Site Key and H5P UUID, as I do not yet heard about them
    3. did not yet upload any H5P files and not yet try to use H5P in this Tiki instance
    4. the folder in tikiroot storage/public/h5p is existing, likely created automatically during upgrade

  3. When I got to the preferences of an arbitrary file in an arbitrary existing file gallery, maybe change some preference like editing the description or even do no change at all and then I save this file, two things happen:
    1. The file is saved/updated correctly (ex: description updated
    2. Tiki does not refer back to the file gallery, but instead to a WSOD blank page with an error message. I have to manually alter the url in the browsers address line or to use the browsers back button to get back to my Tiki.


This is the error message:

Copy to clipboard
Parse error: syntax error, unexpected ')' in /www/htdocs/Path-To-Tikiroot/lib/core/H5P/H5PTiki.php on line 947


Solution

Hi @Torsten Fabricius

Is this still happening for you? (sorry for the late attention on this)

Seems absolutely fine for me (although found a few other issues and had to delete all my old h5p's from before again, then had to enable the h5p hub to be able to create new ones).

Which version of php is this on? And assuming it's 7.2+ can you make a show2 instance?

Importance
5
Easy to solve?
7
Priority
35
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
7193
Created
Thursday 17 October, 2019 13:56:12 UTC
by Torsten Fabricius
LastModif
Wednesday 03 March, 2021 17:30:04 UTC


Show PHP error messages