Share access rights when using Share or Tell a friend fails in both cases with SEFURL enabled

• Conflict of two features (each works well independently)
• Error
• Regression

I recall this working in 6.x or so, so "tagged as regression".

Using (12.1svn): Abril 4, 2014. r50665

Sharing acccess rights, with token access, seems to be failing.
When using "Tell a firend" for a wiki page, as user with tiki_p_admin, there is a checkboxa message sending time, and the link in the email received by the destination emial contains a TOKEN hash inside. However, once clicked in that link in a browser as anonymous, the user see the message "L'accés a aquesta pàgina està acabat" (the access to this page is over).

When using Share, as user with tiki_p_admin to share a wiki page, I see the dropdown to indicate how many times to share access rights with that email. I shared for 3 accesses (the mas allowed in the admin panel, and thus, in the dropdown, also). The eamil that receives a message comes with a token hash inside, but still gets the message "L'accés a aquesta pàgina està acabat" (the access to this page is over).

u: admin
p: 12345
Homepage restricted to registered users. When SEFURL is off, sharing access rights with friends seemed to work as expected.
http://xavi-9794-5225.show.tikiwiki.org/tiki-index.php?page=Community+Members+HomePage

IT seems the bug was not solved in trunk by then (15.x currently), and a new fix was added by jonnyb in r58322.

Fix unconfirmed for me in localhost with a snapshot of this site upgradeed to 15.x (rewrite rules do not work in show.t.o so SEF cannot be tested there). When attempting to view the site as anon. with the url (which includes the token param name and value), I get:

Update June 22, 2016: This issue seems to happen still when any param is added to the url (page_ref_id=nnn - from structures, or fullscreen=y to prevent disclosing information from the side modules that the user has access to, besides the content that would like to be shown frmo the central column).

Try r54437

Great, Jonny, this fixes the issue in 14.x (confirmed). Is this backportable to 13.x and 12.x "as-is"?

Update: Backported to 13.x in r55011 and to 12.x in r55012 (after testing in a production environment that the backport to 12.x worked as expected). Thanks again for fixing, jonnyb!

for 15.x, Try r58322
Fix unconfirmed for me in localhost with a snapshot of this site upgradeed to 15.x (rewrite rules do not work in show.t.o so SEF cannot be tested there). When attempting to view the site as anon. with the url (which includes the token param name and value), I get:

Update:

• fixed myself one issue ("My Page" taken as different frmo "My+Page" in the sefurl version of it) in trunk in r58953 & r58955 and backported to 15.x (not to 12.x since it's not a clean backport, and I can't invest time now into that type of backport to 12.x + testing, etc). Feel free anyone to backport if needed.
• But still pending to fix the issue when any param other than the page name is present in the url (page_ref_id=nnn - from structures, or fullscreen=y to prevent disclosing information from the side modules that the user has access to, besides the content that would like to be shown frmo the central column).

Tested in 21.x with Share and SEFURL and this error is gone. Closing. Thanks whoever fixed this Share feature!

It seems that when disabling SEFURL, Share access right with friends (at least), works as expected.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org

This bug has been demonstrated on show.tikiwiki.org

Please demonstrate your bug on show.tikiwiki.org