Category: Less than 30-minutes fix

add antibot captcha for anons to newsletters, calendars and tracker item comments

Add ip to syslog and/or action log, so that when anons (at least) are allowed to add content and it's spam (robots seem to be able to post with our current antibot captcha), there is way to identify the ip of the spammer.

So far, antibot captcha is added (in trunk, at least) to:
* wiki edit
* wiki page comments
* forum posts
* tracker item comments
* freetags
* calendar items
* newsletter subscription

The action of adding content on those features should be logged in syslog and/or action log and IP recorded.

We need to provide natural sorting of the -+Priority+- field in the bug tracker at dev.t.o
Example: click at sort bugs in the wishlist page by Priority in descending order:
https://dev.tiki.org/tiki-index.php?session_filters=y&tr_sort_mode1=f_138_desc&page=Wishlist

First, items with priority 90 are shown.

After that, items with priority 9 are shown. However, between 9 and 90 there are lots of priorities that should be shown before 9 is shown, if they were understood as numbers, not as characters.

See:
https://www.php.net/manual/en/function.natsort.php

Right now, if you have a multitiki installation with 10 sites, and you want to rebuild the unified search index for them all, you have to run 10 times the command with the "--site=" para adapted to each case.

However, when you run setup.sh, by default setup.sh runs for all sites in a multitiki installation.

It would be nice if console.php had the chance (by default or not) to be run once for all sites in that multitiki installation at once


with some param like "--site=all":
{CODE(colors="shell")}
php console.php d:u --site=all
{CODE}

I host several tiki sites on the same hosting service, so it would be nice if the daily reports included the site name in the subject line and body.

I did this with 3 minor changes:

1. templates/mail/report.tpl - add site to report template
### diff report.tpl.orig report.tpl.new
1c1
< {tr _0=$report_user}Report for %0{/tr}.{if $report_preferences.type eq 'html'}<br><br>{/if}
---
> {tr _0=$report_site _1=$report_user}Report on %0 for %1{/tr}.{if $report_preferences.type eq 'html'}<br><br>{/if}

2. lib/core/Reports/Send.php - add site to subject line (refactored)
### diff Send.php.orig Send.php.new
66,77c66,73
< if (is_array($reportCache) && count($reportCache) >= 1) {
< if (count($reportCache) == 1) {
< $subject = tr(
< 'Report from %0 (1 change)',
< TikiLib::date_format(
< $this->tikiPrefs['short_date_format'],
< $this->dt->format('U'))
< );
< } else {
< $subject = tr(
< 'Report from %0 (%1 changes)',
< TikiLib::date_format(
< $this->tikiPrefs['short_date_format'],
< $this->dt->format('U')),
< count($reportCache)
< );
< }
< else {
< $subject = tr(
< 'Report from %0 (no changes)',
< TikiLib::date_format(
< $this->tikiPrefs['short_date_format'],
< $this->dt->format('U'))
< );
---
> $subject = tr('Report on %0 from %1 ',
> $this->tikiPrefs['browsertitle'],
> TikiLib::date_format(
> $this->tikiPrefs['short_date_format'],
> $this->dt->format('U'))
> );
> if (!is_array($reportCache)) {
> $subject .= tr('(no changes)');
> } elseif (count($reportCache) == 1) {
> $subject .= tr('(1 change)');
> } else {
> $subject .= tr('(%0 changes)', count($reportCache));
> }

3. lib/core/Reports/Send/EmailBuilder.php - set site for report
# diff EmailBuilder.php.orig EmailBuilder.php.new
37c37,38
<
---
> $smarty->assign('report_site',
> $this->tikilib->get_preference('browsertitle'));

ex.:

# Redirects
# This is useful if you are migrating from an old site, and you want the old URLs to still work.
# Just uncomment and edit the line below.
Redirect 301 /oldpage.html /tiki-index.php?page=newpage

I had tested this successfully in version 3.3, but now with the upgrade to version 4.0 it does not seem to work. Here are the steps to recreate the issue:

1. Set up a TikiWiki so that users need to be validated by an Admin prior to actually logging in.

2. Register as a new user and get the following message:

Your account request has been stored and will be activated by the admin as soon as possible.
You'll receive email notification once your account is activated.
Please do not attempt to login until you receive the email notification.

3. Log in as 'admin' and navigate to Users page of admin tools. Push the round green checkmark graphic which has a hover display that says "Validate user: junkman". It sends me to this URL:

http://www.mywebsite.info/tiki-login_validate.php?user=junkman&pass=n

On that page the site returns a simple dialog box that says "Invalid username or password". Who's username & password? The Admin's?

At this point it wants to redirect me to the home page and I cannot get these new users validated.

On the admin page to enable/disable plugins (tiki-admin.php) paymentlist is missing the checkbox, instead only this text is displayed: "paymentlist: Show details of payments. The payments considered may be restrained by user or date.".

The result of this bug is that the plugin Paymentlist cannot be activated or de-activated! Whatever the setting is on your Tiki installation, you cannot alter it through the Admin UI.

After some bad experience (ours and from other users), Rick (Rick99) and I suggest:

^RFE should be that the following username should __not__ be changable or deletable:
* __admin__

And the following groupnames should __not__ be changable or deletable:
*__registered__
*__anonymous__

Additionally, there should be a usergroup __administrator__ that has ''all'' permissions. This would allow Tiki-admins to easily create new Admin logins, with their own usernames.
^

__added: ensure password reminder works out of the box__

A couple of usability issues could be fixed here.

a) remind/reset passwords is off by default - should be on?
b) no email is set on admin by the installer

this would prevent most newbie lost admin password issues i think. - mlpvolt


Last [http://tikiwiki.org/tiki-view_forum_thread.php?comments_parentId=24817&topics_threshold=0&topics_offset=0&topics_sort_mode=lastPost_desc&topics_find=&forumId=2|thread about it at tw.o here]


Related issue: http://dev.tikiwiki.org/tiki-view_tracker_item.php?trackerId=5&itemId=1074

Allow to reply messages to anonymous users (which provided their email) from the contact-us tracker (created through the corresponding profile in the profiles wizard) directly through some integrated tiki feature, and not necessarily through some external software.

Maybe PluginMail if it can receive the email from the PluginTrackerList with param checkbox properly configured (failed for me with current codebase), in a similar way to receiving username in meesu-compose.php for registered users.

I dunno when this stopped working, but it's definitively not working any more in Tiki12.

See the Featured profile: https://profiles.tiki.org/Personal_Blog_and_Profile_12x

See this:
{CODE(colors="yaml")}
objects:
-
type: blog
ref: personal
data:
title: $profilerequest:Blog Title$My Personal Blog$
description: $profilerequest:Blog Description$Random daily thoughts and travel stories$
user: $profilerequest:Blog Owner$admin$
allow_comments: y
{CODE}

However, once the profile is applied, comments are not allowed yet on that blog.

The documentation for the blog handler says both things comments and allow_comments:
https://profiles.tiki.org/Blog%20Handler

I tried both things, and none of them works for me.

Maybe some bug was introduced somewhere?

I had a look myself but unsure how to fix. (profile internals are not within my expertise)

Reproduced in the show instance:
u: admin
p: 12345

Applied the profile, and when the blog is edited, "Allow comments" is still unchecked:
http://xavi-9794-5157.show.tikiwiki.org/tiki-edit_blog.php?blogId=1

{syntax type="tiki" editor="plain"}
Editing a Wiki page i upload an image ({IMG(src="http://shocksite.com/pics/icons/pictures.png")}{IMG}) directly from the edit page. The code look like this :
{CODE(wrap="0",ishtml="0",ln="0",wiki="0",rtl="0",cpy="0")}{img fileId="1" thumb="y" alt="" rel="box[g]"}{CODE}

I have set perm "tiki_p_view_file_gallery" for anonymous.

Unlogged (anonymous) i can't see the picture (tested on several browsers win/mac).
Logged as admin i can see the picture.

I have checked what perm allow the picture to be displayed and found that only when the perm "tiki_p_download_files" is set for anonymous an un logged visitor can see the picture.

On tw.o, right now (at Friday 08 Jun, 2007 09:12 CET; 18:12 in Barcelona):

I got blank screen after submitting a new article submission on tw.o (user xavi, as plain registered user, using Firefox 2.0.0.4 under Window$), and some minutes later, from the same computer but using a different browser and user, I got blank screen after validating that article submission (user xavidp, SeaMonkey 1.1.2 under Window$)... However both actions succeded... (beyond the blank screen), even if they were posted more than once.

The article was submitted twice (as submission from user xavi), and, it's been posted three times when validated!

That's the article: http://tikiwiki.org/article150 (user xavidp cleaned the duplication in article submissions; sylvieg cleaned the 2 duplication in tw.o articles)

Can anybody confirm this is not any issue with my mouse or so?

Apparent bug of undocumented feature within the ARTICLESplugin, such that the "start" parameter does not seem to function.

In the example below, This was coded into the body of a wiki page. I was trying to have two ARTICLES columns, but show the first 5 (or so) articles on the left of the wiki page, then continue with articles 6 thru (say) 10 on the right column of the split wiki page.

Gary (chibaguy) suggested the code below (including the "start" parameter), but it appears that I get identical lists of articles, rather than one column listing articles 1 thru 5, and another parallel one listing articles 6 thru 10 (as expected). "Start" doesn't appear to be documented, but Gary chibaguy suggested it's use to me.

{CODE(caption="example code to reproduce problem")}

{SPLIT()}
{ARTICLES(start=1,max=5)}{ARTICLES}
---
{ARTICLES(start=6,max=10)}{ARTICLES}
{SPLIT}

{CODE}

Please see http://tikiwiki.org/tiki-view_forum_thread.php?forumId=4&comments_parentId=35859&thread_sort_mode=commentDate_asc#comments

Gary suggested that I submit this as a bug, so this is it. It would be awesome to be able to do a two column split of articles via the inline plug, but not when the lists are identical.

Thanks to you for looking into this!!! -sd :)

When you sort a listing of articles, you can have the results sorted on the size of the articles. But the result is illogical, which is more visible when sorting descending, but in principle ascending is affected as well: The sorting is done NOT numerical (which you would expect on a numerical value like size), but by string representation.

The result is e.g. that "456 bytes" is being considered larger than "1.2 kBytes"...

If you go to articles home, and have your articles listed, you can have the list sorted by clicking on the column header. By clicking that again, you can change sorting direction (ascending/descending).

This doesn't work with the ID of articles. They are always listed ascending. However, the small arrow indicating the order DOES change to descending, but the listing isn't altered at all.

Some users don't want to understand the difference between "Page Name" and Link when creating an internal link.

This attached patch makes the Page Name field automatically fill in whenever the Link field is changed. The patch was made against tw 4.1.

I think it should be up for debate if both these fields are necessary. Many users of the WYSIWYG feature may be new to the concept of creating links. Less is simpler, and I vote for removing one of these fields.

P.S. Sorry about spamming the mailinglist with this request. Next time I will only submit patch here.

Some users don't want to understand the difference between "Page Name" and Link when creating an internal link.

This attached patch makes the Page Name field automatically fill in whenever the Link field is changed. The patch was made against tw 4.1.

I think it should be up for debate if both these fields are necessary. Many users of the WYSIWYG feature may be new to the concept of creating links. Less is simpler, and I vote for removing one of these fields.

P.S. Sorry about spamming the mailinglist with this request. Next time I will only submit patch here.

Some users don't want to understand the difference between "Page Name" and Link when creating an internal link.

This attached patch makes the Page Name field automatically fill in whenever the Link field is changed. The patch was made against tw 4.1.

I think it should be up for debate if both these fields are necessary. Many users of the WYSIWYG feature may be new to the concept of creating links. Less is simpler, and I vote for removing one of these fields.

P.S. Sorry about spamming the mailinglist with this request. Next time I will only submit patch here.

It is very hard (if possible) to use the debugger console with default setting due to contrast issues.

{img fileId="1259" thumb="box"}

In /lib/prefs/feature.php is a help string that does not work in English __and__ makes life of translators hard, because it is badly escaped (actually, not at all):
In line 550 you will find:

{CODE(Colors="Tiki")}
'feature_comments_send_author_name' => [
'name' => tra('Add author name in From email header'),
'description' => tra('Add the name of the comment author in the email header "From", making the email look like sent from "John Doe <noreply@example.com>"'),
'help' => 'Comments',
'type' => 'flag',
'default' => 'n',
'tags' => ['basic'],
],
{CODE}

The problem is the mock sender's mail address contained in braces. It IS the notation most mail clients use, real name and address in less than and greater than signs. But tra() seems to be unable to handle this. Possibly tra() interprets it as HTML entity (?) and discards it, so output of this description stops after John Doe. The address is omitted, as well as the closing quote sign.

And for translators this is hard, because if you add the string that is displayed to your custom.php, the pattern matching won't find it.

{syntax type="tiki" editor="plain"}
Rule activated by dates
Rule active from
Rule active until
Upgraded tiki: Shows years 1969 till 2010
Clean install: Only gives the year 2010 to chose from
This year is almost over so whould be nice to have some later years to chose from.

{syntax type="tiki" editor="plain"}
"If a user upload a big avatar (more than 45x45 px) tiki 2.1 not 'avatarize' and show the big image in the forums. This problem may be very uncomfortable when you read a forum topic."

I can confirm that this still occurs on tiki.org and whatever Tiki version it is running presently, specifically with GIF images. -- ssanders

Review this blog entry on tw.o:
Using view_blog_post:
http://tikiwiki.org/tiki-view_blog_post.php?blogId=26&postId=300

Using view_blog:
http://tikiwiki.org/tiki-view_blog.php?find=&blogId=26#postId300


Notice that with view_blog_post, this line __is__ displayed:
And change it to:
<form enctype="multipart/form-data" method="post" action="tiki-editpage.php" id='editpageform' name="editpageform">

But with view_blog, the code is __not__ displayed.

Blog entries should be displayed identically, regarless if you are view the blog or blog post.

From my understanding and after a discussion with Gary.

Tiki25 is supposed to work with bootstrap 5.2.x
Tiki26 is supposed to work with bootstrap 5.3.x

As discussed in the matrix chat, it seems that setup.sh / composer has been updated to use Tiki26 dependencies.

{CODE()}
Bernard Sfez
I'm setting a theme on a brand new tiki25. (from git)
I'm facing several issues about Undefined variable...

$primary-text-emphasis-dark
$primary-bg-subtle-dark:
...

$min-contrast-ratio: 1.8

I tried to compile as is the tuften them and I have the same errors...

Some collisions between bootstrap5.2 tiki25 and tiki26 ?
---
gary_c-l
Those variables are new in Bootstrap 5.3, to support color modes .../...
---
Bernard Sfez
I see that tuften v25 is different from tuften v26 (variable_dark and others are missing)
---
gary_c-l
Interesting. I'm going to try compiling Tiki 25 Tuften in a Tiki 25 instance here.
gary_c-l
Well, tuften compiles without errors here, in branch 25.
---
Bernard Sfez
... did you run setup.sh ?
It is possible that the vendor package is updated (for bs5.3)
gary_c-l
Yeah, I didn't run setup .sh. The Bootstrap version in vendor is Bootstrap v5.2.2, in my branch 25 instance. Maybe composer isn't configured right, if setup .sh results in having the wrong Bootstrap files for branch 25.
{CODE}

Tiki25 code (composer packages) that is our last stable version should not be changed by Tiki26 requirement.

Tiki25 being the only Stable version between Tiki24 (old) and Tiki25 (unstable) it should be at least working as it was,
---
Below, just after a second fresh install (nothing else was done, not preference changed) I tried to compile an existing theme.
{img fileId="2065" thumb="box"}