Loading...
 
Skip to main content

Badly formed string in /lib/prefs/feature.php doesn't work in English and translations as well

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
Badly formed string in /lib/prefs/feature.php doesn't work in English and translations as well
Version
18.x
Category
  • Bug
  • Consistency
  • Easy for Newbie Dev
  • Less than 30-minutes fix
Feature
Admin Interface (UI)
Resolution status
Fix on the Way
Submitted by
hman
Lastmod by
Eutyche ODIMBA
Rating
(0)
Description

In /lib/prefs/feature.php is a help string that does not work in English and makes life of translators hard, because it is badly escaped (actually, not at all):
In line 550 you will find:

Copy to clipboard
'feature_comments_send_author_name' => [
			'name' => tra('Add author name in From email header'),
			'description' => tra('Add the name of the comment author in the email header "From", making the email look like sent from  "John Doe <noreply@example.com>"'),
			'help' => 'Comments',
			'type' => 'flag',
			'default' => 'n',
			'tags' => ['basic'],
		],


The problem is the mock sender's mail address contained in braces. It IS the notation most mail clients use, real name and address in less than and greater than signs. But tra() seems to be unable to handle this. Possibly tra() interprets it as HTML entity (?) and discards it, so output of this description stops after John Doe. The address is omitted, as well as the closing quote sign.

And for translators this is hard, because if you add the string that is displayed to your custom.php, the pattern matching won't find it.

Importance
4
Easy to solve?
10 easy
Priority
40
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
7439
Created
Friday 24 July, 2020 09:07:21 UTC
by hman
LastModif
Friday 07 January, 2022 09:33:07 UTC


Show PHP error messages