Loading...
 
Skip to main content

Bootstrap, Composer; Tiki25 is now set to use bootstrap 5.3.x while it shouldn't have been changed

Status
Closed
Subject
Bootstrap, Composer; Tiki25 is now set to use bootstrap 5.3.x while it shouldn't have been changed
Version
25.x
Category
  • Regression
  • Easy for Newbie Dev
  • Less than 30-minutes fix
Feature
Theme: Look & feel, Styles, CSS, Theme Control Center
Resolution status
Won't Fix
Submitted by
Bernard Sfez / Tiki Specialist
Volunteered to solve
Jean-Marc KADIMBA
Lastmod by
Bernard Sfez / Tiki Specialist
Rating
(0)
Description

From my understanding and after a discussion with Gary.

Tiki25 is supposed to work with bootstrap 5.2.x
Tiki26 is supposed to work with bootstrap 5.3.x

As discussed in the matrix chat, it seems that setup.sh / composer has been updated to use Tiki26 dependencies.

Copy to clipboard
Bernard Sfez I'm setting a theme on a brand new tiki25. (from git) I'm facing several issues about Undefined variable... $primary-text-emphasis-dark $primary-bg-subtle-dark: ... $min-contrast-ratio: 1.8 I tried to compile as is the tuften them and I have the same errors... Some collisions between bootstrap5.2 tiki25 and tiki26 ? --- gary_c-l Those variables are new in Bootstrap 5.3, to support color modes .../... --- Bernard Sfez I see that tuften v25 is different from tuften v26 (variable_dark and others are missing) --- gary_c-l Interesting. I'm going to try compiling Tiki 25 Tuften in a Tiki 25 instance here. gary_c-l Well, tuften compiles without errors here, in branch 25. --- Bernard Sfez ... did you run setup.sh ? It is possible that the vendor package is updated (for bs5.3) gary_c-l Yeah, I didn't run setup .sh. The Bootstrap version in vendor is Bootstrap v5.2.2, in my branch 25 instance. Maybe composer isn't configured right, if setup .sh results in having the wrong Bootstrap files for branch 25.


Tiki25 code (composer packages) that is our last stable version should not be changed by Tiki26 requirement.

Tiki25 being the only Stable version between Tiki24 (old) and Tiki25 (unstable) it should be at least working as it was,


Below, just after a second fresh install (nothing else was done, not preference changed) I tried to compile an existing theme.
Image

Importance
10 high
Easy to solve?
10 easy
Priority
99
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
8427
Created
Wednesday 21 June, 2023 05:56:13 UTC
by Bernard Sfez / Tiki Specialist
LastModif
Thursday 31 August, 2023 14:25:15 UTC


Show PHP error messages