Category: Less than 30-minutes fix

Everytime I use the maketoc inside a wiki page on a fresh tikiwiki 3.2 install the whole page content is duplicated every time I hit "save". Even if I delete all the content but one version and hit save the whole PREVIOUS page is duplicated again. Like I hit save: two times the page content. I delete all but one time the content, I hit save: three times the page content. I delete all but one time ... save ... four times the page content.
Only removing the maketoc makes it possible to get rid of the problem.
That was done with Opera browser on a page with 4 h1 headings but I doubt it is a browser problem. :)

In tiki-calendar_nav.tpl the display of calendar dates is formed (template), but in a IMHO rather bizarre mix of hard-coded and localizable syntax, which
a) does not make use and thus circumvents the existing user pref for date formats and
b) effectively makes correct localization impossible.

I quote from this template a code snippet:

{CODE(colors="tiki")}
{if $viewlist ne 'list' or $prefs.calendar_list_begins_focus ne 'y'}
{if $calendarViewMode eq 'month'}
{$daystart|tiki_date_format:"%B %Y"}
{elseif $calendarViewMode eq 'week'}
{* test display_field_order and use %d/%m or %m/%d *}
{if ($prefs.display_field_order eq 'DMY') || ($prefs.display_field_order eq 'DYM') || ($prefs.display_field_order eq 'YDM')}
{$daystart|tiki_date_format:"{tr}%d/%m{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%d/%m{/tr}/%Y"}
{else}
{$daystart|tiki_date_format:"{tr}%m/%d{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%m/%d{/tr}/%Y"}
{/if}
{else}
{$daystart|tiki_date_format:"%B %Y"} - {$dayend|tiki_date_format:"%B %Y"}
{/if}
{else}
{$daystart|tiki_date_format:"{tr}%m/%d{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%m/%d{/tr}/%Y"}
{/if}
{CODE}

So there is some testing for localized date format, but it assumes that only the order of day and month may be swapped through translation? This only works inside the USA or partly in the UK. It does not work in Germany, and not in Japan and possibly conflicts with other countries as well.

Germany uses
{CODE(colors="tiki")}
%d.%m.%Y
{CODE}

Japan uses
{CODE(colors="tiki")}
%Y-%m-%d
{CODE}

Look at the peculiar coding in tiki-calendar_nav.php. To magnify, I have extracted one example that clearly shows the logical error in it:

{CODE(colors="tiki")}
{$dayend|tiki_date_format:"{tr}%d/%m{/tr}/%Y"}
{CODE}

The year was excluded from translation and also the slash that comes before the year (at least in the USA...). So the slash cannot be removed by custom.php, because it is outside the translation. And it would be even worse for a localization into Japanese, because of their year leading the date...

It would be far better if date format was used in the form of the user pref that exists! But for a faster "quick resolution" moving the %Y into the translation braces would do the trick, and later introduce the "proper" way... Thanks.

On a wiki page, the "translate" and "manage translation" links under the little globe appear if 1. The person has permission to edit that page, but at the same time have no permissions to create new pages or edit other pages.

The links do not appear if the person does not have write access to the wiki page.


What should happen:

The "translate" and "manage translations" buttons should only appear if the user has permissions to create a translation, rather than edit the specific page they are on.

The issue I have come across is that the nav buttons are appearing when the page can not be edited, but the opposite problem is also likely (although I have not tested it) that a translation could be desired, on a page thats write permissions have been suspended.

This issue has also caused several translation & error pages to become crawled by bots and indexed in search engines. I will be proposing some new robots.txt rules to help prevent this in another ticket (to keep it all together with other suggestions)

Hope this is of interest for someone to tackle.

Hello,

I already reported my discovery in the forum. But here again for the formal way.

The problem:
If you want to use the feature "cookie" on a menu, it will not work.

Test Case:
Open up a menus sub structure, click on a link, and the menu is collapsed on the new site.

Reason:
tiki wiki checks if the menu cookie "menu.menu_structure_pageID" is existing and if so, it looks if it is opened or closed.

But, the cookies name is not "menu.menu" but "menu.menus".

Where is the problem:
/lib/menubuilder/menulib.php:468
$ck = getCookie('menu'.$params['id'].'__'.$option['position'], 'menu');

should be changed into:
$ck = getCookie('menus_'.$params['id'].'__'.$option['position'], 'menu');


Another problem is, that this only works for a flat hierachie (like in the bootstrap menu), but if you want to work properly in all menus, you have to change the else if statement too.
Same file, line 464:
} elseif ($option['type'] == 's') {

on every lower level, the option.type is not set. We commented it out, so we have a simple } else { and it works.

Add a feature to move files in between the file system and the database

This feature:
tiki-admin.php?page=trackers
tiki-admin.php?page=fgal
tiki-admin.php?page=wikiatt

should be added here:
tiki-admin.php?page=gal

(In fact, it should be backported from 1.10) "Move images from filesystem storage to database storage"

On at least two sites, running respectively 3.x and 4.x:

- jiamcatt.ourwiki.net (3.x)
- terminology.tikiwiki.org (4.x)

I noticed that if I change a wiki page and save it as a minor edit, email notifications are still being sent.

I think that this only happens when the user is part of a group for which a Group Watch has been set. When I tested on the 3.x site, that's the conclusion I had come to (this AM, UK time). But this PM (UK time), I tested on the 4.x site, and it seems that the minor edit is causing notification even if a user-defiined watch (i.e. as opposed to a group watch) is set.

BTW: This bug caused a minor incident on the JIAMCATT site. Someone did about 30 minor edits to a page that was being monitored by a large number of people, because he was a newbie and was trying to master the syntax for referencing a section inside a page. As a result, 30 notifications got sent to a hundred people, and some of them got pretty pissed off, and almost walked out on the site. One person asked to be "taken off this infernal web site".

So, if the bug can be fixed quickly, I can go back to this community and tell them that something was done to prevent that sort of problem in the future, which might diffuse the crisis.

When you use the I18n admin control panel for the first time to create a custom translation (/tiki-language-manage_custom_translations) , it create the custom.php file.

However translation are not performed as it miss at the end of the file (like in the sample file we distribute : custom.php_example)
~pp~$lang = array_merge($lang, $lang_custom);~/pp~

Once you paste it custom translation are working.

Update: Even if you paste it in the file it is removed each time a translation is saved.

On tiki-install.php, in the install menu "help" the first icon is missing as it refer to "img/favicons/favicon-16x16.png" and there is no such folder or file.

{img fileId="1109" thumb="box"}

{syntax type="tiki" editor="plain"}
When you add the module last_files, the tikiwiki can't be started anymore! Everything is blocked and that is it. The server load goes up to the maximum

Version 2.1 & 2.2

modules/mod-calendar_new.php displays strange month view when selecting LIST VIEW from tiki-calendar.php. The date (numerical) is placed several days backward in regards to day of the week (Monday - Sunday).

Screenshot (sorry so large for clarity):
{img src=show_image.php?name=calendarMODIssue20081023.gif }

This issue appears to be with the month view in mod-calendar_new.php assigned to variable $calendarViewMode. When I select $calendarViewMode='week' this issue does not arise.

I duplicated the function below in lib/calendar/calendarlib.php:

{img src=images/code.png}%%% {CODE()}
if ( $_SESSION['CalendarViewList'] == 'list' ) {
if ( is_array($listtikievents) ) {
foreach ( $listtikievents as $le ) {
if ( is_array($le) ) {
foreach ( $le as $e ) {
$listevents[] = $e;
}
}
}
}
}
{CODE}

I modified it to say:

{img src=images/code.png}%%% {CODE()}
if ( $_SESSION['CalendarViewList'] == 'calendar' ) {
if ( is_array($listtikievents) ) {
foreach ( $listtikievents as $le ) {
if ( is_array($le) ) {
foreach ( $le as $e ) {
$listevents[] = $e;
}
}
}
}
}
{CODE}

This caused it to be "fixed" but it broke in Internet Explorer by showing a full semester view in the calendar. Not so desirable effects. We've since switched to the week view in the mod-calendar_new.php module with no issues.

templates/modules/mod-events.tpl uses mktime and under php5 it needs to have all arguments as integers.
Simple patch:

see it best by:

- make a new tracker
- connect a module to it
- insert an item into the tracker

The module shows:
1)
2) Your item here

Later it is

1) Your item here
2) New item

When you create a new article and decide to __not publish it__ (which means actively removing the checkmark on the "published" checkbox), then it won't show up in articles module, and not on Home of articles (correct behaviour), but it does show up in the module "Since last visit". This is inconsistent...

{syntax type="tiki" editor="plain"}
Hi,

I have tested and look at dev of the module Action Calendar on 6.0 and 6.x trunk.
It need to be polished.
There are some misfit.
Who read this must understand that the function where not ended for 6.0
This note is technical sometime for a good link to dev team.

The item 3650 relates that the popup which shows action buttons can't be reached.

In fact as the function is not polished the buttons are the same as module calendar, but they have not corresponding available functions.

As I test to set these popup as "sticky" it function as the main calendar. After I test various issues :
#Action link on the cell of a day -> go to show a calendar of a full week. Can display thousands of events.
#Buttons on popup goes quite nowhere

!Module Action calendar
Note that any cell is related to several events then any action must leads to a list of events,
!!What can be wished :
!!!Global action buttons (nav.tpl):
Add a button to go directly to calendar for the current span of time (day,week, month..), two buttons : calendar or list (to earn time) in the future 7.x full page calendar
!!!Action on the link of the cell (day)
Display the list of "events" (sometimes truncated into the popup as it is desirable) for __the corresponding date "day".__
!!!The list offers
* Link to the object
* Add a comment to event (first column of list)
* type of event , not already made
!!!Action on popup buttons
Any button which have action opens and operates on the list of events of the day. *The buttons can't be the same as main calendar
*As the events are system events they can't be updated neither deleted.
*The update could be to add a comment to but as it is a list... for the day it is into the list.
**the events can't be edited, but an enhancement can be to have the capability to add comment
**the events can be listed for the day (the function is not edit_item but calendar with date="date" viewmode=day and listmode=list)
**a button on the popup can activate directly the calendar view with options of time span "day, week, month" or list with same options

!Module Main calendar
Note that any cell is related to several events then any action must leads to a list of events,
!!What can be wished :
!!!Global action buttons (nav.tpl):
Add a button to go directly to calendar for the current span of time (day,week, month..), two buttons : calendar or list (to earn time) in the future 7.x full page calendar. Options : view only, view and add comment (if rights opened), edit
!!!Action on the link of the cell (day)
Display the list of "events" (sometimes truncated into the popup as it is desirable) for __the corresponding date "day".__
!!!The list offers
* Button update
* Button delete
* Button copy and edit
* Button repeat the object (daily, weakly, monthly, trimestrial, yearly, fiexed date - checked on calendar) option edit list generated after
* Link to the object
* Add a comment to event (first column of list)
* type of event , not already made, edit types (a structure only for events classification), modify type (check on structure)
!!!Action on popup buttons
Any button which have action opens and operates on the list of events of the day. The buttons can be
*Show the list (right can be only "show_calendar items" and not "edit")
*Display the list in edit mode
*As there are several event they can't be updated neither deleted directly only defined upon the list.
*Depending of opened rights the update button could be "show full list : can add comment " if right opened
Notes :
**the events can be listed for the day (the function is not edit_item but calendar with date="date" viewmode=day and listmode=list)

!For 7.x :
!!Calendar with Gantt presentation
!!Calendar content can content several types of objects with various rights.
See corresponding text (the link to wished features projects for 7.x about calendar will be here soon ###)

The module editing has a language feature. Although I am thankful that such an option does exist, it it not fully thought through. It needs an extension, but one that is extremely easy to implement. Just lift the restrictions a little bit...
/lib/modules/modlib.php has this on lne 889:
{CODE(Colors="Tiki")}
'lang' => [
'name' => tra('Language'),
'description' => tra('Module is displayed only when the specified language(s) in use. Designate languages by two-character language codes. Separate multiple languages by semi-colons.'),
'separator' => ';',
'filter' => 'lang',
'section' => 'visibility',
],
{CODE}

Language Id is, according to ISO, not a two character designator (It is, but then you can only select major languages and not sub-languages), but five characters: Two designators of two characters separated by a period. Major and minor...

Example: With just two characters you can only select English as "en" and not specifically, for instance, British English, because that is en.gb... :-)

Module months_links is expected to show links to the months in the last year where posts occurred, but also display a link to the previous years, so that the user can click to the previous year to list the months that hold posts, etc.

The user expected to be able to list all months where there were posts, from the previous years, but it only display posts from the last 12 months.

The rows param by default gets the value 10 (like month october, our current month by the time of this writing)
Increasing the value shows more links (from previous years). However, it seems that Value max="-1" (show all posts, with no max limit) doesn't fetch them all.

Sometimes I am really at a loss when I want to translate Tiki Wiki, because I really do not understand the English original. For instance, there is a module "user list". The module itself is plain and straightforward, and does what the name implies, but as the saying goes "the devil is in the details.". There is a parameter under the tab "module" named "included groups". Shouldn't be that hard to guess what it could do. But what is the user supposed to fill in? The explanation is this:

::"Show only the users of the group group and of a group including group."::

Ahem? What was the artists intention with this sentence? :-)

You'll find it on line 81 of /modules/mod-func-users_list.php.

In the type "date and time" it may be necessery to be able to have only 'year' choise instead of year, month, day and hour


::: FRENCH :::
Dans le type "date and time" nous devrions pouvoir avoir seulement année (de x à x au choix), seulement mois/année ou seulement jour/mois/année. Pour plusieurs tracker, la suppression de l'heure est nécessaire, comme lorsqu'on demande la date de naissance d'un individu !

Mouseover plugin is cool

Some more stuff to make it cooler:

#Now, it sticky or not. Should be possible to set a number of seconds to stay open. It should stay open as long as my cursor is over the zone.
#If contained text is too long, it overlaps to the bottom (good), but background should extend automatically.
#If body empty, don't make clickable (people mouseover and see nothing)

Multiple divs show up in code when using the "all languages" feature.

The .top and .page-bar ids show multiple times when using this feature.

Navigate to wiki page, with multiple languages. Ensure the "all languages feature is enabled.

Look under #role_main to find the duplicate ID's

I had a screenshot, but don't see a way to attach it.

if you use the example of the mwtable plugin
{CODE()}{MWTABLE( wiki_classes=false )} style="width:50%", class="myclass"
|+style="font-style:italic;"|My caption
? width="30%;" ?? style="background-color:yellow;"
! style="background-color:grey;"| Name
! Address
|- style="background-color: red"
| style="color: blue;" | Bill
| The little house
|-
| Carol || The big house
{MWTABLE}{CODE}

you will get something like this:

{CODE()}<table style="" width:50%="" ,="" class="normal br">
<caption style="" font-style:italic;="">
My caption<br></caption>
<col 30%;="" width="">
<col style="">
<tbody><tr>


<th style="" background-color:grey;="">Name<br></th>
<th>Address<br></th>
</tr>
<tr style="" background-color:="">
<td style="" color:="">Bill<br></td>
<td>The little house<br></td>

</tr>
<tr>
<td>Carol</td>
<td>The big house<br></td>
</tr>
</tbody></table>{CODE}

you see that the attributes are not translated right.

as well there is a problem with a space like "color: blue"

and another addition: doesn't recognise colors in hexadecimal format (#rrggbb)

it happens in version 3.x and as well as in version 6.1 i am testing right now.

{syntax type="tiki" editor="plain"}
When Tiki adds the antibot code to a form or table, there is no specific class assigned to the TD or TR. Sometime this results in odd UI (because sometimes the table is NORMAL, sometimes FORM, someimtes FORMCOLOR, etc.)

{syntax type="tiki" editor="plain"}
Tiki plugin Tabs have stopped working within templates in 27.3 (but work in 27.2) if the name parameter is set. If name is not specified, tabs appear to work in 27.3 as well.

For example, this does not work anymore within a wiki template:

{TAB(name="user_tabset_01" tabs="Cases|Orders")}
Case
/////
Orders
{TABS}

I have deliberately misspelt the name of the Tiki plugin in order display the code here in this post

The template above is being called by Tiki plugin TrackerList

trackerlist trackerId="3" fields="50:51:52:53:54:55:56:215:64" wiki="zmatter-view" list_mode="n" showpagination="n" max="1" showlinks="n" silent="y"}

Here is the screenshot of erroneous output that I see in Tiki 27.3

{img fileId="3134"}

The correct output (in Tiki 27.2) and with the name parameter removed from plugin tabs (in Tiki 27.3) is

{img fileId="3135"}

If I have a login box module, and I visit tiki-login_scr.php, I get two places to login

Same thing with error pages which offer to login.

In the early days of TikiWiki, we used a bunch of modules (last_modified_wiki_pages, last_articles, Last this, Last that, etc.) to show recent changes to visitors. We ended up with many modules and it was cluttered.

All this became a lot better once the "Since your last visit" module came around to adding all the features. As a bonus, it checks permissions and shows the information since the user's last login. Very sweet.

Now, I am hoping to get to the same result for the many edit/input boxes.

In version 3.0, the quick_edit module checks (with Ajax) for names of existing wiki pages to edit. This avoids duplication. Great stuff. Wikipedia does something similar when you are searching for a page name.


I almost always have the search box on.

However, I also add "search page name" because the general search engine may not return the page I am looking for as the search result.

Here is an idea:

A new module which combines three modules:
search_wiki_page
search_new
quick_edit

See top right of http://moinmo.in/ for an example.

The action buttons are grayed out until text is entered in the text box. -> Very nice


Button should be WYSIWYCA


See top-right search box at:
http://www.ohloh.net/projects/tikiwiki
http://www.wikicreole.org/



__Alternatively, we could combine search page name and search text, and in the search results, we would first show pages names, and then, search text. This involves more work, but could be better for the end user UI.__

^I think the existing layout for the search top right in TW is fundamentally good. A text box, then a drop-down then a button. Why because the drop down is more future proof than any of the layouts from the other sites you reference.

If we make the contents of the drop down easy to customise or at the very least document how to add to it. For example the CRM function could add items to the drop down for "Contacts" and "Accounts", webmail could add "Mail Messages" and so on.

I do agree the wikipage create/edit module should be included in the top right search function.

I think this is an example of where considering the future openness of the solution would be very important - MatWho^

{THUMB(id=98)}{THUMB}