Loading...
 
Skip to main content

Nonsensical (at first look) "translation" of icons

  • Tracker item actions
Trackers
Items
Status
Open
Subject
Nonsensical (at first look) "translation" of icons
Version
18.x
21.x Regression
Category
  • Error
  • Easy for Newbie Dev
  • Less than 30-minutes fix
Feature
Toolbars, Quicktags and Smileys
Resolution status
New
Submitted by
hman
Lastmod by
hman
Rating
(0)
Description

In /lib/toolbars/toolbarslib.php several calls for icon FILES get translated. Why would the file names or paths of icon files be translated?

This is just a (very) minor issue, but unnecessarily inflates language.php in all target languages. Example:

Copy to clipboard
switch ($tagName) {
			case 'bold':
				$label = tra('Bold');
				$icon = tra('img/icons/text_bold.png');
				$iconname = 'bold';
				$wysiwyg = 'Bold';
				$syntax = '__text__';
				break;

With this, a translator could exchange toolbar icons (or their paths) in his/her translation. But what would be the use case for that? 22 icon file names are pumped through tra() in total... Maybe there is some deeper logic, but I don't get it 😉

Importance
1 low
Easy to solve?
10 easy
Priority
10
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
7723
Created
Saturday 10 April, 2021 20:30:35 UTC
by hman
LastModif
Monday 15 August, 2022 13:29:15 UTC


Show PHP error messages