Loading...
 
Skip to main content

Javascript toggle is broken

Status
Closed
Subject
Javascript toggle is broken
Version
2.x
Category
  • Error
Feature
Category
All / Undefined
Modules
Resolution status
Please retest
Submitted by
mrisch
Lastmod by
mrisch
Rating
(0)
Description

In tiki_categories-admin.tpl, the javascript function toggle is used to toggle tree nodes for subcategories. However, that function appears in two places - PHPLayers menu and tiki-js. Ouch.

This worked in 1.9 and is broken in 1.10



Same is true for the debug console and (I suspect) anything else that uses the toggle function.

I isolated the problem - I added the browse categories module - that includes phplayers-tiki.php, which includes lib/phplayers, which has the toggle function...

More tracking found the problem - it is in lib/phplayers/lib/treemenu.inc.php

the makeNewTree function looks for a menu_name variable that is added to the toggle function name. This works for the standard category view. However, somewhere along the line the name isn't passed properly in categories module.

The other complication is that the normal category browsing page doesn't work right with this module.


Oddly, phplayers is not included in the 1.10 head download, so I don't get it.

Solution
Please retest in latest 1.10 (HEAD)
Importance
5
Priority
25
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
748
Created
Thursday 08 June, 2006 20:18:33 UTC
by Unknown
LastModif
Saturday 07 June, 2008 12:58:15 UTC


Show PHP error messages