Loading...
 
Skip to main content

Should Watches report Minor changes to wiki web pages, or not? If not, fix.

Status
Closed
Subject
Should Watches report Minor changes to wiki web pages, or not? If not, fix.
Version
1.9.x
Category
  • Error
  • Documentation (or Advocacy)
Feature
Wiki (page view, edit, history, rename, etc)
Watch (email notifications of changes)
Submitted by
Bill White
Lastmod by
Philippe Cloutier
Rating
(0)
Description

Some versions of the Tikiwiki documentation suggest that a watch does not report a change to a web page that has been designated as a "minor" change. That does not appear to be the case for Tikiwiki 1.9.2.

If you ask me, the ability for a wiki user to make a Minor edit without bothering the "Watcher" crowd is a great idea and makes for a better community wiki dynamic.

Solution

Developers pick one:


OR

  • The old documentation is "correct" or "describes a very worthwhile specification" and the feature is "broken" or "should be implemented as specified", so fix it, and also conform the current documentation.



There are now 2 different watch events for wiki pages: wiki_page_changes and wiki_page_changes_incl_minor. As notificationemaillib shows:

// If it's a minor change, get only the minor change watches.
if( $minor ){
$emails = $notificationlib->get_mail_events('wiki_page_changes_incl_minor', $pageName); // look for pageName and any page
} else { // else if it's not minor change, get both watch types.
$emails1 = $notificationlib->get_mail_events('wiki_page_changes', $pageName); // look for pageName and any page
$emails2 = $notificationlib->get_mail_events('wiki_page_changes_incl_minor', $pageName); // look for pageName and any page
$emails = array_merge( $emails1, $emails2 );
}

The user should now get the behavior he wants if he uses the right watch event.

Importance
5
Priority
25
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
716
Created
Friday 12 May, 2006 20:53:12 UTC
by Unknown
LastModif
Thursday 30 December, 2010 00:02:03 UTC


Show PHP error messages