Loading...
 
Skip to main content

Add Autoprefixer script to SCSS to CSS workflow in trunk/pre-Tiki19

Status
Pending
Subject
Add Autoprefixer script to SCSS to CSS workflow in trunk/pre-Tiki19
Version
19.x
22.x
Category
  • Feature request
Feature
Theme: Look & feel, Styles, CSS, Theme Control Center
Resolution status
Please retest
Submitted by
Gary Cunningham-Lee
Volunteered to solve
Jonny Bradley
Keep informed
Roberto Kirschbaum
Lastmod by
Gary Cunningham-Lee
Rating
(0)
Description

As pointed out by Brendan/drsassafras (https://tiki.org/forumthread69192-CSS-Compatibility-Issues?topics_offset=14), the CSS files in trunk are missing vendor prefixes that Bootstrap 4 bootstrap.css normally has. This is because the Autoprefixer script isn't being used in Tiki's current stylesheets workflow. For better browser compatibility (so we aren't supporting only the latest browser versions), it would be good to integrate an Autoprefixer script in our workflow.

I found this script, which could be helpful: https://github.com/vladkens/autoprefixer-php . Or maybe there's another solution that works for the devs who compile SCSS to CSS.

Update: I added Release Blocker category to put this on the front burner. The solution doesn't have to be the script I found, but some solution is needed for Tiki 19 to have maximum browser support.

Update 3/16/2020: This isn't fixed in my local installation; I'd like us to have another look at it.

Update 9/22/2020: This seems to be less an issue as legacy Edge and IE browser usage declines. I can't test IE10 and other instances of vendor prefixes aren't critical. I'm removing the blocker category and changing the status to pending for now, and will check again when we update to Bootstrap 5.

Solution

I added an issue on the scsphp project here - we shall see if that does any good. In the meantime i guess we have no other option but to add the js prefixfree package for now...

Seems that someone has made a PHP CSS prefixer that should work ok with leafo/scssphp compiler, some info was added here: https://github.com/leafo/scssphp/issues/610#issuecomment-459274640 - looks worth trying, i will one day if no one else gets to it first 😉

Workaround

I added the js prefix free lib to 19.x for testing in r68037

Importance
8
Easy to solve?
8
Priority
64
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
6699
Created
Wednesday 13 June, 2018 08:17:53 UTC
by Gary Cunningham-Lee
LastModif
Monday 21 September, 2020 16:22:58 UTC


Show PHP error messages