Priority Review of master-only [FIX] commits missing from 30.x
Generated by Claude AI analysis (prompted by jonnyb). Commits grouped by priority based on security impact, data integrity, fatal errors, and breadth of effect.
Please note
This AI generated analysis seems to have lots of false positives (most of the stuff is already cherry-picked to 30.x) so it should be taken with a grain of salt.
Commits tagged [FIX][UI] and PHPUnit warning fixes — real but lower production impact. Includes theme tweaks (Tikiben, jQui, Darkshine, Cypht), minor admin UX polish, and test output cleanup.
24133be388 [FIX][UI] Improve visibility of links in non-color-switch areas in Tikiben... --- * [FIX][UI] Improve visibility of links in non-color-switch areas in Tikiben theme and other small visual improvements in that theme and the Darkshine theme. Todo: Tikiben needs its theme thumbnail.
41044cee50 [FIX] ShowTikiOrg: Improve SSH connection handling and error reporting --- * [FIX] ShowTikiOrg: Improve SSH connection handling and error reporting
3ffb14b148 [FIX] DateTime: avoid validating invalid raw request values --- * [FIX] DateTime: avoid validating invalid raw request values
fec020aea4 [FIX] Noisy warnings and notices in the PHP unit test output --- * [FIX] Fix warnings and notices in the PHP unit test output
f2b7725d82 [FIX] Bootstrap Smartmenus: Correct SEF URL handling for submenu items --- * [FIX] Bootstrap_smartmenu.tpl: Correct SEF URL handling for submenu items
b60d1c2b40 [FIX][REF] Devtools - Update English Strings: Fix script failure due to missing dependencies + refactor to preserve formatting --- * [FIX][REF] Fix script failure due to missing dependencies and preserve formatting
1719c66595 [FIX] Tracker field encryption: fix key gate and unlock flow --- * [FIX] Encryption: prevent global ajaxError from closing key-entry modal on 409
d443414eb7 [FIX] forums: Fix fatal error when "freetags" were enabled --- * [FIX] forums: Fix fatal error when "freetags" were enabled I think another casualty of !8658 because now the code in `lib/setup/freetags.php` fails to run as now `$section` is only set after tiki-setup.php runs and is needed within it.
bd0318670b [FIX] Action Calendar: fix CalendarLib loading and module focus date when feature_calendar is disabled --- * [FIX] Action Calendar: fix CalendarLib loading and module focus date when feature_calendar is disabled
d2a5895cca [FIX] Page Edit: Update "Cancel edit" button handling for improved functionality in case we have the edit buttons location set to both (top and bottom) --- * [FIX] Update cancel edit button handling for improved functionality
d87d9d51c0 [FIX] Permissions Admin: Exclude treetable subHeader rows from listfilter (keep group labels always visible when filtering by perm name) --- * [FIX] Add filterExclude parameter to TreeTable and update object permissions template
735c0d33ca [FIX] Tracker item - missing titles when SEFURLs is enabled --- * [ENH] Add test for tracker item SEFURL titles
b8714d65c0 [FIX] maps: Fix basic feature colour when only "color" is provided (lost from failed MR !9936)
f750361a64 [FIX] mail: Function `addTextHeader` unsurprisingly requires a text string as the value. --- * [FIX] mail: Function `addTextHeader` unsurprisingly requires a text string as the value. !9094 converted all header values to an array which results in fatal errors (for instance on tiki-remind_password.php, thanks @Bernard Sfez / Tiki Specialist)
226e00b088 [FIX] Blog importer: prevent duplicate category addition --- * [FIX] Blog importer: prevent duplicate category addition
f97fdd3b49 [FIX] Preferences: Unable to enable preferences for custom modules containing special characters like spaces or dots. --- * [FIX] Code Correct
3f13da13f3 [FIX] Correct SQL error when wrong or invalid sort_mode in the URL --- * [FIX] Correct SQL error when wrong or invalid sort_mode in the URL
474f3ebf2b [FIX] Improve YouTube URL parsing and support additional formats in PluginYouTube --- * [FIX] Relax assertions in YoutubeTest.php to tolerate empty or alert returns
ec98dc96cc [FIX] Restore native SmartMenus scrolling --- * [FIX] Updated menu arrows to point correctly and added RTL support
ca978fbc05 [FIX][UI] Remove unnecessary card-body padding in fixed-width layout side... --- * [FIX][UI] Remove unnecessary card-body padding in fixed-width layout side column menu modules to reduce text-wrapping and overflow
aafefe3b17 [FIX] Tracker item history: pre-render field values before template to avoid "Too late to modify headers" --- * [FIX] Tracker item history: pre-render field values before template to avoid "Too late to modify headers"
9eb715bc83 [FIX] ObjectSelector js: allow using a beforeSearch handler to modify searched string - useful when users paste various kinds of data in the search form and there should exist some custom logic to reformat the data before searching
01b1ced2a0 [FIX] Manticore: handling wildcards in regex --- * [FIX] Manticore: handling wildcards in regex resulted in parse error or incorrect regex syntax when fulltext was scaled down to regex due to missing fulltext field index
3df17e2f33 [FIX] TrackerRules: The Invert Actions doesn't save the correct Action that is that is supposed to be the opposite of Else --- * [FIX] TrackerRules: The Invert Actions doesn't save the correct Action that is supposed to be the opposite of Else
b8085a1d92 [FIX] ToolbarFileRecording: wave bars, camera preview, and recording timer not showing up --- * [FIX] ToolbarFileRecording: wave bars, camera preview, and recording timer not showing up
ceeff0b3bd [FIX] tiki-check: session.save_path "not writable" when session.use_strict_mode is enabled --- * [FIX] tiki-check: session.save_path "not writable" when session.use_strict_mode is enabled
83e6d0adfb [FIX] TrackerRules: Selecting items from the list doesn't work and requires multiple clicks --- * [FIX] TrackerRules: Selecting items from the list doesn't work and requires multiple clicks
a928d50eae [FIX] Load CodeMirror CSS early to prevent broken editor in Ajax/Smarty context --- * [FIX] Load CodeMirror CSS early to prevent broken editor in Ajax/Smarty context
799e5bb8eb [FIX] Activity Rules page to use admin layout and add documentation links --- * [UPD] Fix Activity Rules page to use admin layout and add documentation links
84afda8b05 [FIX] Date Time field: the year display by defaut was too way behind --- * [FIX] Date Time field: the year display by defaut was too way behind
48f12cc609 [FIX] search: Fix on error reporting on an edge case issue found with... --- * [FIX] search: Fix on error reporting on an edge case issue found with elasticsearch v9 (`reason` is now inside `caused_by`)
e3acb65b35 [FIX][UX] Calendar: preserve active view when date picker changes date --- * [FIX][UX] Calendar: preserve active view when date picker changes date
fc49936a0f [FIX] Tabular: tracker selector not rendered on Create Import-Export Format page --- * [FIX] Tabular: fix object_selector type filter lost in AJAX query serialization
bc7cc30a7c [FIX] duplicate key collision in sefurl migrations --- * [FIX] restore dl for file type and refactor sefurl migrations
5abab8ca18 [FIX] Trackers: fixing column shifts in the trackerItems list --- * [FIX] Trackers: fixing column shifts in the trackerItems list
fda5106718 [FIX] lib/core/Feedback.php: Stop trying to send headers in command line. This silences phpunit warnings, although it's likely developpers tried to use the Feedback class in code that isn't meant to always run in a web context.
3f04e1103a [FIX] lib/core/Services/Wiki/Controller.php incorrectly called asArray as a filter
6d7992cd69 [FIX] phpunit: Clear warning Undefined array key HTTP_REFERER in lib/core/Services/Wiki/Controller.php when running unit tests
b0eb6fe001 [FIX] modlib.php: Fix intermittent Warning: Undefined array key "cookie_consent_feature" in unit test caused by unitialized preferences
a471b8b5cc [FIX] Fix phpunit test warning introduced in !8090
b5488d008d [FIX][REF] Themes: admin theme incorrectly applied site-wide + refactor setup/theme.php to ThemeLib --- * Update MarkdownParserTest::html fixture to match Iconset initialization changes, but this isn't ideal
7f46299930 [FIX] 3D file Url encoding when feature_sefurl is set --- * [FIX] avoid corrupted fgal model downloads by using raw file route
1beea81635 [FIX] CalendarController: Prevent one-day backward shift for date-only tracker fields in non-UTC timezones --- * [FIX] JsCalendar: Improve date normalization logic for form submissions
159b5bf723 [FIX] Generally use Plyr to play audio recordings as Glightbox does not support audio --- * remove unecessary imports
6d88604ee2 [FIX] download and preview file unified permission checks --- * [FIX] download and preview file unified permission checks
eb4931894a [FIX] Manticore: flush buffered queries before final optimization stage - prevents arbitrary queries getting lost or executed on the wrong index after rebuild which resulted in duplicate object_type/object_id items in the index
e73ffa7cbd [FIX] ical export - observe rfc formats for datetime metadata and other fixes --- * [FIX] ical export - observe rfc formats for datetime metadata, fix newlines escaping issue, switch to utf8
e4609a9512 [FIX][UX] Calendar: Calendar change field refresh and new-event modal save --- * [FIX][UX] Calendar: Calendar-change field refresh and new-event modal save
8305738b6e [FIX] Fixed a type error in the executeOrQueueIndexRebuild() method of SearchIndexRebuilder --- * [FIX] Fixed a type error in the executeOrQueueIndexRebuild() method of SearchIndexRebuilder
842afff69e [FIX] composer: ignore phpunit security advisories PKSA-5jz8-6tcw-pbk4 --- * [FIX] composer: ignore phpunit security advisories PKSA-5jz8-6tcw-pbk4
bc3c1a7b2d [FIX] Modlib: undefined array key module-last-modif-tracker-comments
e03f57b1df [FIX] textarea: avoid unsaved-change prompt on simple admin and tracker forms --- * [FIX] search_stored: let textarea infer syntax instead of forcing tiki
a21fe5c1e0 [FIX] Tiki-register: Fix TypeError in tracker plugin when action parameter is a string --- * [REF] Make separator processing a plugin concern
b30d71ffdf [FIX] File gallery uploader: prevent premature close and ensure all file IDs... --- * [FIX] File gallery uploader: prevent premature close and ensure all file IDs are inserted in wiki page
ef33065e6c [FIX] Perspectives: Fix object selector initialization in perspective edit form to display the preferences input fields --- * [FIX] Fix object selector initialization in perspective edit form to display the wikiHomePage input
a7bbad303d [FIX] Fix meta keywords not showing when only tags are set --- * [FIX] Fix meta keywords not showing when only tags are set
3881ee8305 [FIX] Fix maxWidth form handling in file gallery page view --- * [FIX] Fix maxWidth form handling in file gallery page view
4152961737 [FIX][UI] My misplaced div closing tag in MR 9815 caused commments to go... --- * [FIX][UI] My misplaced div closing tag in MR 9815 caused commments to go sideways - literally. Thanks, luci.
92bf8cbc29 [FIX] prefs/textarea.tpl: remove double |escape causing HTML-escaping corruption on save --- * FIX: add comment explaining why {.value} is not escaped in textarea.tpl
ec118e7c8a [FIX] Cypht: Remove already defined var breaking left menu --- * [FIX] Cypht: Remove already defined var breaking left menu
bbb6a41c93 [FIX] move wysiwyg inline editor block after is loaded --- * [FIX] move wysiwyg inline editor block after is loaded
8803f12a7a [FIX] textarea : WYSIWYG active overwrites code admin fields (Custom CSS, JS, etc.) --- * [FIX] prefs/textarea.tpl: add _wysiwyg=n to prevent WYSIWYG from overriding admin code fields
e72d882d98 [FIX] Initialize pending and notpending arrays in wikiplugin_group to fix... --- * [FIX] Initialize pending and notpending arrays in wikiplugin_group to fix index rebuild when {GROUP} uses notgroups without pending/notpending
dc7e91308b [FIX][UI] Fixed some style issues and adjusted file content in jQui theme and child themes. --- * [FIX][UI] Fixed some style issues and adjusted file content in jQui theme and child themes.
f5db1c8231 [FIX] Inconsistency of result in the Search (Formatter) when using more than one filter --- * [FIX] Allow multiples filter work for plugin customsearch
7d08f39ec8 [FIX] Class Name Case Violations --- * [FIX] Fedex: use single-line phpstan-ignore to avoid PHPCS docblock error
e21c358a36 [FIX] Correct SQL error when wrong or invalid sort_mode in the URL --- * [FIX] Correct SQL error when wrong or invalid sort_mode in the URL
05efc9ad5b [FIX][REF] Unified Admin Backend: Add new section constant for admin/management pages which should appear in the UAB layout --- * clarify the code comment
f9a1973bde [FIX] Modules: handle modules wrapped in additional containers (e.g., topclass) in drag & drop --- * [FIX] Modules: handle modules wrapped in additional containers (e.g., topclass) in drag & drop
1735fc7213 [FIX] Modules Admin: Assigning a new module has UI problems --- * [FIX] Fixed behavior of the Preview button.
e7efdee944 [FIX] Popovers hidden behind fixed-top navbar --- * Fix: Popovers hidden behind fixed-top navbar
73e40bda79 [FIX] Restore login dropdown width --- * [UI] Refine login dropdown width for better responsiveness
29f36d3bec [FIX] Set SameSite attribute to 'Strict' for non-embedded Tiki content --- * [FIX] Set SameSite attribute to 'Strict' for non-embedded Tiki content
fc81d6c837 [FIX] Refactor modules adminbar and contributors to avoid too late to modify headers --- * [FIX] Refactor modules adminbar and contributors to avoid too late to modify headers
cb0710f97a [FIX] installer: Initialise feature_webservices to avoid warnings (regression from !9798 thanks @rodriguezny)
0a55c3a73c [FIX] theme: Make the header optionally fixed width (remove incorrect dependency, apologies)
938a2d9863 [FIX] trackers: For the mysql engine at least, provided fields cannot be optional and need to be declared for all uses. So for Files fields to work when indexed as geometry data, we must provide the field names for all options. => Error: Commit body is empty after tags. (stupid husky rule won't allow a blank line?) Should fix https://doc.tiki.org/PluginMap when in 30.x
bf565620e6 [FIX] elfinder: Avoid warnings
52794ecf4c [FIX] Tracker: missing layout on tracker fields admin page --- * [FIX] Tracker: missing layout on tracker fields admin page
522411b67c [FIX] Fix module admin top spacing in social/classic layouts --- * [FIX] Fix module admin top spacing in social/classic layouts
f2afbb50e1 [FIX][UI] Adding files that were meant to be committed in earlier revamp of... --- * [FIX][UI] Adding files that were meant to be committed in earlier revamp of jQui theme to test styling with CSS variables a set of no-compile child themes.
7786270ea3 [FIX] cypht: color bug fix for the list of folders and messages --- * [FIX] cypht: color bug fix for the list of folders and messages
d6d0e84731 [FIX] update: Add a new status for patches `FAILED` and only record these as... --- * [FIX] update: Add a new status for patches `FAILED` and only record these as being executed if not successful when using the `auto-register` option, instead of marking all 'NOT_APPLIED' patches as "skipped"
7af2cd0dd7 [FIX] Enable viewing of multiple module calendars simultaneously and fix the... --- * [FIX] Enable viewing of multiple module calendars simultaneously and fix the display of the tracker list calendar view
57a3209503 [FIX] tiki-check.php: Add short timeout for Composer availability check --- * [FIX] Composer: Improve timeout detection and error diagnostics in tiki-check
4c3b682cc9 [FIX] trackers: Files field upload breakage when in inline mode, regression from ffbbb9c7 since 26.x it seems
4b7b59a085 [FIX] Tracker Rules: The Clear All button doesn't update the data (Conditions, Actions and Else) after clearing and upgrade ui-predicate-vue3 --- * [FIX] The Clear All button doesnt update the datas (Conditions, Actions and Else) after Clearing
38e8cae784 [FIX] Prevent wrong user deletion from user preferences page --- * [FIX] prevent wrong user deletion from user preferences page
d532b4f943 [FIX] PreferencesLib:getPreference() did not use preferences defaults, and... --- * [FIX] PreferencesLib:getPreference() did not use preferences defaults, and could return incompatible types if a preference is unset. Not a full fix because I am currently working on a branch. Only fixes what I can directly observe.
39aaefcf51 [FIX] Validate and restore basic cookie functionnality. Among other things, it was impossible to change consent from the the tiki-user_preferences.php (and likely anywhere else). Make sure consent lookup is all done from the same code, and spot check that is is obeyed
86b3f376b0 [FIX] wrap tracker field name placeholders with for translation support --- * [FIX] wrap tracker field name placeholders with for translation support
f443aa4ad0 [FIX] Tracker: Empty modal when editing tracker field after import --- * [FIX] Tracker: Empty modal when editing tracker field after import
2e4ada4872 [FIX] Rsslib: Undefined variable $result called in `loadRss()` --- * [FIX] Rsslib: Undefined variable $result called in `loadRss()`
d6bb20e95e [FIX][UX] Calendar: style disabled Today button and rename event action Copy to Duplicate --- * [FIX][UX] Calendar: rename event action Copy to Duplicate
3e6cb513d7 [FIX] elfinder: Selecting a was file in trackers broken --- * [FIX] phpcs: Stupid rule
9871fe6dce [FIX][UX] Review the detailed presentation of a calendar event --- * [FIX][UX] Review the detailed presentation of a calendar event
739229c27c [FIX][ENH] enhance parserlib heading and autonumbering --- * [FIX] parserlib: preserve legacy heading spacing for unnumbered headings
ddc3353ccc [FIX] User Information: popover displaying wrong user info --- * [FIX] User information: The pop-up window displays "Never connected" for any user other than the user themselves.
1863a93c5c [FIX] Make 2FA work with option nobox=='y'
3f4004075e [FIX] shorturl: Prevent undefined index error when tiki-setup.php is included from `tiki_route_attempt_custom_route_redirect()`
7ddac04863 [FIX] shorturl: Fix js error due to missing semicolon
5a2588d0a1 [FIX][UI] Use border-color CSS variable for menu options configuration... --- * [FIX][UI] Use border-color CSS variable for menu options configuration borders, for optimal color contrast and theme color match.
119ff4543c [FIX] Fix double HTML escaping in Smarty {title} block across templates --- * [FIX] Fix double HTML escaping in Smarty {title} block across templates
a375156935 [FIX] WantedPages: Ensure semantic links Page are ignored within \~ np\~ tags --- * [FIX] WantedPages: Ensure semantic links Page are ignored within ~ np~ tags
ffb4d26a4d [FIX][UX] Calendar: fix prefilled new-event date, save and calendar selector regressions --- * [FIX][UX] Calendar: fix prefilled new-event date, save and calendar selector regressions
e323375c2d [FIX][UI] Fix incorrect syntax (in my commit ed4a2a0f) to add class 'no-box'... --- * [FIX][UI] Fix incorrect syntax (in my commit ed4a2a0f) to add class 'no-box' to the module div when the module has 'no-box' set to 'y'.
e70aaaf34f [FIX] FAQs: restore comment toggle behavior and align title length validation --- * [FIX] restore docblock for MAX_FAQ_TITLE_LENGTH constant
63cda6c867 [FIX] Module: order property override and rows property reset issues --- * [FIX] Module: order property override and rows property reset issues
85ba335f6c [FIX] cypht: visual changes to the left/right columns --- * [FIX] cypht: visual changes to the left/right columns
e97a31c801 [FIX][UI] Minor admin-section color and style improvements in several themes. --- * [FIX][UI] Minor admin-section color and style improvements in several themes.
616ac60409 [FIX] Captcha, CAPTCHA questions and answers involving text string is not working anymore --- * [FIX] Captcha, CAPTCHA questions and answers involving text string is not working anymore
f7b198f816 [FIX] Article field: the Preview button doesnt show the selected articles --- * [FIX] Article field: the Preview button doesnt show the selected articles
bb5fa70e49 [FIX] inline editable lazy render - bypass npn-parsable blocks --- * [FIX] inline editable lazy render - bypass npn-parsable blocks as formatter handles the context switch (between html/wiki) and adds necessary ~ np ~ tags only when needed; otherwise, we end up with nested ~ np ~ tags which parserlib does not (yet) support properly
212e6f76e1 [FIX][UI] Remove unnecessary side-column divs (and background color) that were... --- * [FIX][UI] Remove unnecessary side-column divs (and background color) that were removed earlier in commit 3da6c0d4 but were unintentionally restored.
06f4f0f79f [FIX][UI] Commented out a rule that could potentially misapply the dropdown... --- * [FIX][UI] Commented out a rule that could potentially misapply the dropdown background color to navbars (effectively reverts MR6966).
f2b68cf99f [FIX] PluginController: safeFileExistsInPath missing second argument --- * [FIX] PluginController: safeFileExistsInPath missing second argument
ba076ecb99 [FIX][UI] Fix sidebar search icon centering and mobile content padding in Admin UI --- * [FIX][UI] Remove manual padding-left override on .col1
344ae1e8d5 [FIX] Tracker fields edit: table overflow issue because the table-responsive class should be on a wrapper --- * [FIX] Tracker fields table overflow issue
fbc2991605 [FIX] customsearch: trigger live filtering on input without TableSorter --- * [FIX] customsearch: trigger live filtering on input without TableSorter
5a53f1b3e8 [FIX] Object Permissions: Correct input filter types for feature_filter and group_filter --- * [FIX] Object Permissions: Correct input filter types for feature_filter and group_filter
6749786988 [FIX] Newsletter unsubscribe and confirm_subscription input filters were set to 'bool', casting MD5 hash codes to 1 and breaking both unsubscribe and subscription confirmation links
6edf4b8f7e [FIX] trackers: Correct typo in var for show fields description --- * [FIX] trackers: Correct typo in var for show fields description (regression originally from 386e5fdb - him again! 😉
0341b4b2b8 [FIX][UI] Improved color contrast between admin sidebar accordion buttons and... --- * [FIX][UI] Improved color contrast between admin sidebar accordion buttons and dropdowns in some themes (thanks, Bernard) and made other admin color adjustments. Todo: check Fivealive and Fivealive-lite theme options.
4adf53a4eb [FIX][ENH] Url.php: make stricter validation for URL tracker field optional --- * [FIX] trackerfield URL: remove conditional strict validation for wiki syntax feedback display
89e4b4ef4e [FIX] Admin Modules: Fix left/right column modules hidden on tiki-admin_modules.php --- * [FIX] Tiki-admin_modules: Fix left/right column modules hidden on Admin Modules page
27c2535db1 [FIX][REF] Calendar: restore event modals and fix filter form reload --- * [FIX][REF] Calendar: restore event modals and fix filter form reload
64bf0b5de1 [FIX][UI] Updated wiki page and comment rating forms to use Bootstrap classes... --- * [FIX][UI] Updated wiki page and comment rating forms to use Bootstrap classes and added fieldset and legend elements to improve accessibility standards compliance. Also fixed bad spacing on tiki-forum_rankings.php.
45b6b0e602 [FIX] Navbar width regression caused by `feature_fixed_width` coupling --- * [FIX] Navbar width regression caused by `feature_fixed_width` coupling
151ebe04ed [FIX] param: Ensure 'name' parameter is required because the plugin does nothing if the name is not specified Partial revert of !8616 - no need to preserve buggy and senseless behaviour (imho)
22963df2d6 [FIX] Partial revert of !8600 - why should all menus only be 40% of the viewport height? Also why aren't we using the bootstrap classes for menus any more? For instance `.dropup` menus should be done like this: https://getbootstrap.com/docs/5.3/components/dropdowns/#dropup no?
97c8e5d51e [FIX] Partial emergency revert of !8551 - don't hard code values like this in templates, especially ones in layouts!
d3dfc87517 [FIX] Menus: use Bootstrap dropdown-divider for separators --- * [FIX] Reuse strong placeholders in admin menu separator tip
989943b23e [FIX] webservices: Fix the parsing/compilation of templates for webservices --- * [FIX] webservices: Fix the parsing/compilation of templates for webservices, lost in the upgrade to Smarty 5
f6ff5f4298 [FIX] PluginCategory: restore language filtering behavior for lang parameter --- * [FIX] PluginCategory: restore language filtering behavior for lang parameter
3d8f62a45b [FIX] Articles: prevent image loss when editing article --- * [FIX] Articles: prevent image loss when editing article
6ab4572519 [FIX] console: If TikiLib fails to load in tiki-setup.php for some reason,... --- * [FIX] console: If TikiLib fails to load in tiki-setup.php for some reason, `captureException` fails silently leading to spurious and misleading error messages being reported, so better to reveal the initial message
b1e48e0894 [FIX][UX] Checkboxes: implement bi-directional sync and indeterminate state --- * [FIX][UX] Checkboxes: implement bi-directional sync and indeterminate state
b109cd375a [FIX] EmailAction: use RFC-compliant address parsing via Symfony Mime --- * Fix EmailAction test PHPCS violations
