Loading...
 
Skip to main content

Calls to plugins inside calls to WYSIWYG plugin with use_html disabled generate no output (invisible)

  • Tracker item actions
Trackers
Items
Status
Open
Subject
Calls to plugins inside calls to WYSIWYG plugin with use_html disabled generate no output (invisible)
Version
14.x
14.x Regression
15.x
17.x
18.x
Category
  • Regression
Feature
WYSIWYG (What You See is What You Get)
Resolution status
Fix on the Way
Submitted by
Philippe Cloutier
Lastmod by
Philippe Cloutier
Rating
(0)
Description

Calls to plugins which are inside a call to the WYSIWYG plugin produce no output (which usually means that their effect is invisible). Some plugins, such as FOOTNOTE, have effects other than causing output, so calls to these may keep part or all of their effect.

This bug was introduced by the changes to wikiplugin_wysiwyg.php in r50752. Tiki versions 14 to 18+ are affected.

The following call to WYSIWYG demonstrates:

Copy to clipboard
{WYSIWYG(use_html="n")}
This dummy content is visible.{FOOTNOTE()}Note which is invisible, but should be indicated by a number which is actually invisible{FOOTNOTE}
{GROUP(groups="Admins")}This should be visible for admins{GROUP}
{FADE(label="This should be visible")}Hidden{FADE}
{WYSIWYG}



This happens because plugin_execute() calls ParserLib::convert_plugin_for_ckeditor() since ck_editor is true, and therefore returns an empty string to parse_first(), and therefore to parse_data(). That parse_data() has its ck_editor option true, since it is called by parseToWysiwyg(), called by wikiplugin_wysiwyg().

Unfortunately, the revision bringing this regression also fixes WYSIWYG edition. So going back to the previous situation breaks edition again. One can only choose between working visualization and working edition.

I believe the way to fix is to go back to parse_data(), but re-parse the plugin call's content differently when editing.

Files
  1. WYSIWYG Fix Display
Solution
A patch against a modified version of Tiki 15 is attached.
Importance
7
Easy to solve?
4
Priority
28
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
6551
Created
Wednesday 24 January, 2018 14:28:37 UTC
by Philippe Cloutier
LastModif
Saturday 06 July, 2024 10:21:44 UTC


Show PHP error messages