Loading...
 

Edit through WYSIWYG plugin is quietly lost if plugin call follows an inclusion

Status
Open
Subject
Edit through WYSIWYG plugin is quietly lost if plugin call follows an inclusion
Version
12.x
15.x
17.x
Category
  • Bug
Feature
WYSIWYG (What You See is What You Get)
Resolution status
New
Submitted by
Philippe Cloutier
Volunteered to solve
Philippe Cloutier
Lastmod by
Philippe Cloutier
Rating
(0)
Description

Any WYSIWYG edit to a WYSIWYG zone (defined using the WYSIWYG plugin) fails quietly if the call to the plugin follows an inclusion (made using the INCLUDE plugin). CKEditor goes away as expected and the contents of the zone are displayed, but instead of the new contents, the old content shows.

This bug exists in Tiki 12 and persists in trunk as of r64360.

If wiki page Parent includes page Child, the following WYSIWYG zone causes the wysiwygPlugin() function to be called at page load with its page parameter set to "Child" instead of "Parent" as should be the case. Which causes the AJAX calls to action_replace() from edits to have the wrong value for their page parameter, causing them to have no effect, and action_replace() to return simply "[]".

wysiwygPlugin's parameter is wrong because wikiplugin_wysiwyg()'s $sourcepage variable has the wrong value, because it is wrongly set to $wikiplugin_included_page instead of $page. This is due to a parser context management issue.

Solution

The part about error reporting was fixed in the following commits.
trunk: https://sourceforge.net/p/tikiwiki/code/64473/
17 https://sourceforge.net/p/tikiwiki/code/64474/
15: https://sourceforge.net/p/tikiwiki/code/64493

The patch attached is an actual fix, but is against Tiki 15, and relies on considerable parser changes which are not in the Tiki community's repositories (see thread "Parsing context and inclusions").

Importance
8
Easy to solve?
4
Priority
32
Demonstrate Bug (Tiki 19+)
Please demonstrate your bug on show2.tiki.org
 About show2.tiki.org

To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tiki.org instance. To start, simply select a version and click on "Create show2.tiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tiki.org.

Version: Create show2.tiki.org instance
Demonstrate Bug (older Tiki versions)
Please demonstrate your bug on show.tikiwiki.org
 About show.tikiwiki.org

To help developers solve the bug, we kindly request that you demonstrate your bug on a show.tikiwiki.org instance. To start, simply select a version and click on "Create show.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show.tikiwiki.org.

Version: Create show.tikiwiki.org instance
Ticket ID
6476
Created
Thursday 02 November, 2017 14:19:17 GMT-0000
by Philippe Cloutier
LastModif
Tuesday 04 December, 2018 21:20:51 GMT-0000

Attachments

 filenamecreatedhitscommentversionfiletype 
WYSIWYG_plugin_EDIT_despite_inclusions.diff 20 Apr 18 20:30 GMT-00000


Keywords

The following is a list of keywords that should serve as hubs for navigation within the Tiki development and should correspond to documentation keywords.

Each feature in Tiki has a wiki page which regroups all the bugs, requests for enhancements, etc. It is somewhat a form of wiki-based project management. You can also express your interest in a feature by adding it to your profile. You can also try out the Dynamic filter.

Accessibility (WAI & 508)
Accounting
Administration
Ajax
Articles & Submissions
Backlinks
Banner
Batch
BigBlueButton audio/video/chat/screensharing
Blog
Bookmark
Browser Compatibility
Calendar
Category
Chat
Comment
Communication Center
Consistency
Contacts Address book
Contact us
Content template
Contribution
Cookie
Copyright
Credits
Custom Home (and Group Home Page)
Database MySQL - MyISAM
Database MySQL - InnoDB
Date and Time
Debugger Console
Diagram
Directory (of hyperlinks)
Documentation link from Tiki to doc.tiki.org (Help System)
Docs
DogFood
Draw -superseded by Diagram
Dynamic Content
Preferences
Dynamic Variable
External Authentication
FAQ
Featured links
Feeds (RSS)
File Gallery
Forum
Friendship Network (Community)
Gantt
Group
Groupmail
Help
History
Hotword
HTML Page
i18n (Multilingual, l10n, Babelfish)
Image Gallery
Import-Export
Install
Integrator
Interoperability
Inter-User Messages
InterTiki
jQuery
Kaltura video management
Kanban
Karma
Live Support
Logs (system & action)
Lost edit protection
Mail-in
Map
Menu
Meta Tag
Missing features
Visual Mapping
Mobile
Mods
Modules
MultiTiki
MyTiki
Newsletter
Notepad
OS independence (Non-Linux, Windows/IIS, Mac, BSD)
Organic Groups (Self-managed Teams)
Packages
Payment
PDF
Performance Speed / Load / Compression / Cache
Permission
Poll
Profiles
Quiz
Rating
Realname
Report
Revision Approval
Scheduler
Score
Search engine optimization (SEO)
Search
Security
Semantic links
Share
Shopping Cart
Shoutbox
Site Identity
Slideshow
Smarty Template
Social Networking
Spam protection (Anti-bot CATPCHA)
Spellcheck
Spreadsheet
Staging and Approval
Stats
Survey
Syntax Highlighter (Codemirror)
Tablesorter
Tags
Task
Tell a Friend
Terms and Conditions
Theme
TikiTests
Federated Timesheets
Token Access
Toolbar (Quicktags)
Tours
Trackers
TRIM
User Administration
User Files
User Menu
Watch
Webmail and Groupmail
WebServices
Wiki History, page rename, etc
Wiki plugins extends basic syntax
Wiki syntax text area, parser, etc
Wiki structure (book and table of content)
Workspace and perspectives
WYSIWTSN
WYSIWYCA
WYSIWYG
XMLRPC
XMPP




Useful Tools