I noticed after pulling the latest code from SourceForge that certain icons in the WYSIWYG and Wiki editors were not being set properly. A condition inside an if statement in /lib/toolbars/toolbarslib.php on the line 1709 was setting several icons to the plugin.php icon.
I began looking for the cause of the issue and discovered a series of several commits that had caused the bug. The icons in question are the features 'Image', 'File', 'Mouseover', 'Insert Module', 'HTML', 'Include', 'Code', and 'Remarks Box'.
The problem code for each of the above features can be found in the lib/wiki-plugins/ directory and is attributed to a single line of code in each file. The structure of the hash tables located in these files appears to have been changed from using
'icon' => 'path/to/icon'
'iconname' => 'iconset_definition'
Unfortunately, this has caused the regression on my site. To fix this, I can simply comment out the line with 'iconname', and replace it with the previous 'icon' line, however this increases the number of customizations on my site I would need to keep track of, and would prefer not to go down that route.
The revision numbers and files for the features in question are as follows:
'Image' = r56275 — /wiki-plugins/wikiplugin_img.php
'File' = r56269 — /wiki-plugins/wikiplugin_file.php
'Mouseover' = r56280 — /wiki-plugins/wikiplugin_mouseover.php
'Insert Module' = r56280 — /wiki-plugins/wikiplugin_module.php
'HTML' = r56273 — /wiki-plugins/wikiplugin_html.php
'Include' = r56276 — /wiki-plugins/wikiplugin_include.php
'Code' = r56254 — /wiki-plugins/wikiplugin_code.php
'Remarks Box' = r56291 — /wiki-plugins/wikiplugin_remarksbox.php
I looked into the new iconset definitions as well, and didn't notice any issues with it, so this is why I'm am submitting the bug report. Let me know if there is anything I can help with!
Hopefully r56351 will do it for the normal wiki toolbars, still trying to work out a fix for WYSIWYG...
Thanks for the excellent bug report!
Show.tiki.org snapshot creation is in progress... Please monitor http:///snapshots/ for progress. Note that if you get a popup asking for a username/password, please just enter "show" and "show".
Password reset was successful
Password reset failed
Show.tiki.org instance destruction is in progress... Please wait...
The public/private keys configured to connect to show2.tiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
Unable to connect to show2.tiki.org. Please let us know of the problem so that we can do something about it. Thanks.
Show.tiki.org is currently under maintenance. Sorry for the inconvenience.
Unable to get information from show2.tiki.org. Please let us know of the problem so that we can do something about it. Thanks.
Show.tiki.org is in the progress of creating the new instance. Please continue waiting for a minute or two. If this continues on for more than 10 minutes, please let us know of the problem so that we can do something about it. Thanks.
To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tiki.org instance. To start, simply select a version and click on "Create show2.tiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tiki.org.
The URL for the show2.tiki.org instance that demonstrates this bug is at: http://. Note that if you get a popup asking for a username/password, please just enter "show" and "show". This is different from the initial login and password for a new Tiki which is "admin" and "admin".
For the install log, see http:///info.txt
Note that if you see PHP errors or a Tiki claiming to be missing third party software, the instance creation is probably not finished. Please wait a couple minutes and reload.
Snapshots are database dumps of the configuration that developers can download for debugging. Once you have reproduced your bug on the show2.tiki.org instance, create a snapshot that can then be downloaded by developers for further investigation.
Snapshots can be accessed at: http:///snapshots/. Note that if you get a popup asking for a username/password, please just enter "show" and "show".Create new snapshot
|No attachments for this item|