Loading...
 
Skip to main content

Table of contents entries (maketoc) in wrong order when wiki pages are included

  • Tracker item actions
Trackers
Items
Status
Open
Subject
Table of contents entries (maketoc) in wrong order when wiki pages are included
Version
12.x Regression
15.x
18.x
Category
  • Conflict of two features (each works well independently)
  • Regression
Feature
Wiki Plugin (extends basic syntax)
Resolution status
Confirmed
Submitted by
smb@purdue.edu
Volunteered to solve
Jonny Bradley
Lastmod by
Philippe Cloutier
Rating
(0)
Related-to
Description

Upgraded Tik 9.3 to Tiki 12.2 in our test environment. We have a few wiki pages where we use PluginInclude to incorporate portions of other pages into another wiki page (mainly because the combined page ends up being too long for the database to store). The included text contains section headings that are nested to the proper levels. However, the maketoc plugin on the main page produces a mangled table of contents (all the included section headings are listed before the ones on the main page). Under 9.3, this worked as expected — the included headings are listed in the proper place inline with those from the containing page. Note this behavior appears to be present in the version running doc.tiki.org as can be seen at http://doc.tiki.org/PluginMaketoc?structure=HomePage+PluginsQuestion. Notice that the Example section shows what the maketoc output for the current page would look like and the "Related Pages" heading is out of place.

Example

Assuming that "HomePage" contains titles, a page with the following source would suffice to demonstrate the bug:

Copy to clipboard
{maketoc}

! Main section 1
Dummy content

! Main section 2
{include page="HomePage"}


The bug can be observed on this test pageQuestion.

This is a regression from Tiki 12.1, due to revision 48937Question.

Files
  1. Wikiplugin Include.php
Solution

One solution would be to build the TOC client-side: https://dev.tiki.org/TOC-revampQuestion

r66644Question in trunk?

Workaround
Starting from Tiki 19 (following r66644Question), the INCLUDE plugin will have a "parse_included_page" parameter allowing to choose between this bug and the bug fixed by r48937Question (possible failure to honor the included page's "Allow HTML" property). This change exposes/introduces several bugs which are discussed on the thread about r66644 on the tikiwiki-cvs mailing list.
Importance
7
Easy to solve?
4
Priority
28
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
5496
Created
Friday 31 October, 2014 13:48:55 UTC
by smb@purdue.edu
LastModif
Saturday 06 July, 2024 10:21:44 UTC


Show PHP error messages