12.x: Send email to let user validate account doesn't send email if user previously created

• Usability
• Consistency
• Less than 30-minutes fix

Send email to let user validate account doesn't send email if user previously created.

Use case: a user register to a tiki site with a non-working email (defective address or server rejecting emails from that server to that email domain, etc).

Admin changes email for that user (after admin magically finds out in some cases what happened and what is another email for that user), and clicks at the checkbox:

"Send an email to the user in order to allow him to validate his account" (in tiki-adminusers.php?user=N)

Use doesn't get any email. Once the tiki site was configured to save mail info in tiki logs, you noticed that tiki logs didn't record any info of any email sent by that action.
You log out, and go as anon to: tiki-remind_password.php to type the username and click at click at "Request Password Reset".
This does effectively send the email, so that it confirms that there is no problem with the server setup sending emails, but with tiki failing to send that email when "Send an email to the user in order to allow him to validate his account" was checkd, if the user already existed in the users list.

When as admin you create a new user account and in the same action you select Send an email to the user in order to allow him to validate his account, then the email is sent effectively.

To reprroduce:

1. Go here: http://xavi-9794-5213.show.tikiwiki.org/tiki-adminusers.php?user=2
2. login as
   • u: admin
   • p: 12345
3. change that email for an email of your own, and tick at the checkbox: Send an email to the user in order to allow him to validate his account
4. Check tiki logs (tiki-syslog.php), and you will see no record of the email expected to be sent
5. Check you email account, and same, no email
6. CReate a new account with an email of yours, while at the same time you tick at the box Send an email to the user in order to allow him to validate his account.
   • You 'll see the record at the tiki logs tiki-syslog.php
   • you'll receive the email with the link to validate your account

See r51144 & r51156: (better than nothing, imho)

[bp/r51143][FIX]Usability. While bug5213 is not fixed properly, disable at least the checkbox for admins so that they realize that emails are not to be sent when willing to let users validate their account in cases when that user account existed already beforehand.
[bp/r51155][FIX]Oups, fixing 51143 (wrong checkbox) and writing more standard syntax (previous was working too in my tests and copied from other sites). Thanks jonnyb

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org