userlink does not return a link for the current user if user information pref != 'Public'
- Status
- Closed
- Subject
- userlink does not return a link for the current user if user information pref != 'Public'
- Version
- 6.x
7.x
8.x
9.x
10.x - Category
- Error
- Less than 30-minutes fix
- Feature
- Templates (Smarty)
- Submitted by
- DavidBright
- Volunteered to solve
- DavidBright
- Lastmod by
- DavidBright
- Rating
- Description
- The smarty function that generates a user link (lib/smarty_tiki/modifier.userlink.php) will only return an actual link if the user's user_information preference is set to 'public'. In the case where the user link is to the currently logged-in user, however, there is no reason not to display the link even if that preference is set to 'private' as the user should be able to view their own preferences. This is easy to demonstrate; set your user_information preference to private and then look at your name in login module. The name will not be a link to your user preferences.
- Solution
The fix is also easy. In lib/smarty_tiki/modifier.userlink.php, line 88 in the current trunk, this line:
if ($userlib->user_exists($other_user)&&(!empty($friend) || $tikilib->get_user_preference($other_user, 'user_information', 'public')=='public')) {
should be modified to:if ($userlib->user_exists($other_user)&&(!empty($friend) || $tikilib->get_user_preference($other_user, 'user_information', 'public')=='public' || $user == $other_user)) {
Fixed in r45676 (trunk only)- Importance
- 6
- Easy to solve?
- 9
- Priority
- 54
- Demonstrate Bug
-
This bug has been demonstrated on show2.tikiwiki.org
Please demonstrate your bug on show2.tikiwiki.org
Version: Create show2.tikiwiki.org instanceAbout show2.tikiwiki.org
To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tikiwiki.org instance. To start, simply select a version and click on "Create show2.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tikiwiki.org.
- Ticket ID
- 4440
- Created
- Monday 22 April, 2013 14:41:04 GMT-0000
- LastModif
- Monday 22 April, 2013 17:49:58 GMT-0000
Attachments
| filename | created | hits | comment | version | filetype | ||
|---|---|---|---|---|---|---|---|
| No attachments for this item | |||||||
;){kind=link}
;){kind=link}
- Better Editor or at least better FADE function.
- Forum post preview deletes post content
- Update Tracker Field Types Page
- Extended support for additional user input controls like checkboxes and dropdowns (single/multi selections)
- Fivealive-lite theme options: wrong bg color of top menu bar on dev.tiki.org
;){kind=link}
;){kind=link}