TIKI 5.0 (and prev) crash restoring a session which data contain quotes

• Conflict of two features (each works well independently)
• Consistency
• Error
• Regression

Hello,

I have yet redacted quite the same text three month ago, about 4.1, 4.2... Because i could never start these versions, try to find bugs... submit but no answers.

My original text has been lost because of the bugs of the bugs reports management (author not stored - corrected, no capability to sort the items by date, no capability to sort anyway and search) nevertheless, too much to do elsewhere...

Lest's go to the problem, which is a major one :

The fact :

If any fields which is stored into sessions->data contains an " ' ", it is impossible to restart TIKI (always automatically and by evidence crashes if TIKI tries to restore these session.

The reason :

The text is stored with is " ' " and included "simply" into the query which resets the prefs.
By evidence this simple quote " ' " creates a query error and a crash of tiki (often APACHE).
this " ' " is interpreted as the end of the query, and the remaining a non-sense.

Example :

With 5.0 if you are just installing with an upgrade of database, into the session query you will find the third data_text-block

...
alt:
required: false
name: Alternate text
description: Alternate text that displays image doesn't load.
...

the " ' " of "doesn't" crashes the first run.

The same happens when you have a header page with a title containing a simple quote " ' "

Solution :

technical point of view

I have just found a lonely solution :

• the first, simple : any sessions->data content must be pre-translated with doubled simple quotes (which is the SQL syntax).
• any read of sessions->data doubled simple quotes must be set back to a unique one.

A back translation after reading is not need only in some cases (the prefs restoration for example), for a search query the results will come back with their simple quotes...

Who acts ?

It is very simple.
There are not many place where the problem occurs;
But I I have lost so much time because of the bug of 4.x and now 5.0RC and 5.0 Stable that I could not make the work I had programmed to do.
In my opinion it should be better that people who have written the SQL requests, make the change.

If they are not ready, I can submit patches (tikisession particularly)

Bye

trebly

Opened into the text.
Need to know who will do the job.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org

This bug has been demonstrated on show.tikiwiki.org

Please demonstrate your bug on show.tikiwiki.org