Loading...
 
Skip to main content

Tikiwiki mailin is broken in 1.8.5; patches are simple, and attached

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
Tikiwiki mailin is broken in 1.8.5; patches are simple, and attached
Version
1.8.x
Category
  • Error
  • Patch
Feature
Wiki (page view, edit, history, rename, etc)
All / Undefined
Modules
Mail-in
Resolution status
Out of Date
Submitted by
swampfox
Volunteered to solve
swampfox
Lastmod by
Beestje
Rating
(0)
Description

In 1.8.5, the mailin feature doesn't work properly. It may work for some combination of mail systems, but not for others. And it does not properly handle multiple mailed-in messages when a page load is attempted.

Specifically, some combination of mail client and mail server caused the email address extraction to leave a newline on the end, which should be trimmed.

Also, in determining the type of message, a case-sensitive string comparison is done against "text/html", which won't match for upper or mixed-case.

Finally, there's a bug (probably a minor design flaw) in the way the histlib object is created in lib/tikilib.php, such that if the code is executed twice in the same session, it will fail the second time because the $histlib object isn't created.

Last but not least, after parsing the message, if there are no parts found, the loop that attempts to process them assumes that $output->parts exists, which it may not.

Files
  1. Tiki
Solution

strip() the email address to remove the new line.

strtolower() the message type ('text/html') before doing the comparison.

Manually create the $histlib object if it does not exist after 'include_once'.

Check to see if $output->parts exists before using it.

For patch, see attachments to this bug report.

Importance
5
Priority
25
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
320
Created
Friday 15 July, 2005 15:43:12 UTC
by Unknown
LastModif
Saturday 06 July, 2024 10:21:44 UTC


Show PHP error messages