Loading...
 
Skip to main content

misplaced quotes in remarksbox.tpl

Status
Closed
Subject
misplaced quotes in remarksbox.tpl
Version
4.x
Category
  • Error
Feature
All / Undefined
Submitted by
Nowell VanHoesen
Volunteered to solve
Philippe Cloutier
Lastmod by
Philippe Cloutier
Rating
(0)
Description

While digging through some html I found the following:

Copy to clipboard
<div class="rbox-data"">


the line in remarksbox.tpl is:

Copy to clipboard
<div class="rbox-data{$remarksbox_highlight}"{if !empty($remarksbox_width)} style="width:{$remarksbox_width}{/if}">


When the second if statement evaluates to false an extra double-quote is still output.

Solution

Change line 16 of remarksbox.tpl to:

Copy to clipboard
<div class="rbox-data{$remarksbox_highlight}"{if !empty($remarksbox_width)} style="width:{$remarksbox_width}"{/if}>


Just moved the last double-quote to the other side of the end if tag.

This is fixed in r24096 (for Tiki 5).

Importance
4
Priority
20
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
3055
Created
Thursday 25 February, 2010 21:35:06 UTC
by Nowell VanHoesen
LastModif
Thursday 25 February, 2010 22:01:40 UTC


Show PHP error messages