Loading...
 
Skip to main content

Patch for Plugin ATTACH bug reported in bug tracker id 2474

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
Patch for Plugin ATTACH bug reported in bug tracker id 2474
Version
2.x
3.x
Category
  • Patch
Feature
Wiki Plugin (extends basic syntax)
Resolution status
Fixed or Solved
Submitted by
lindon
Lastmod by
luci
Rating
(0)
Description
As noted in bug tracker id 2474, bullets parameter doesn't create a bulleted list. "All" list is poorly formatted with page links that don't work.
Solution

Below is the patch to fix these issues in lib/wikiplugins/wikiplugin_attach.php. If I'm able to post an attachment after I submit this patch, I'll attach the entire file with the fixes.

Below are the changes:

Line 226 and 238: Concatenation "." added so that bullets appear when elected
Copy to clipboard
Line 226:
$link.= '<img src="tiki-download_wiki_attachment.php?attId='.$atts['data'][$n]['attId'].$url.'" class="wiki"';

Line 238:
$link.= '<a href="tiki-download_wiki_attachment.php?attId='.$atts['data'][$n]['attId'].$url.'&download=y" class="wiki"';
Line 278-280: Fixed link to pages when all parameter is used
Copy to clipboard
Lines 278-280 replaced with:
$pageall = strip_tags($atts['data'][$n]['page']);
if( isset( $all ) ) {
    $link.= " attached to ".'<a title="'.$pageall.'" href="'.$pageall.'" class="wiki">'.$pageall.'</a>';
}
Line 292: Changed separator to create a new line for each attachment
Copy to clipboard
Line 292 setting of $separator variable replaced with:
if ( isset( $bullets ) && $bullets ) {
     $separator = "\n";
} else {
     $separator = "<br />\n";
}
Importance
4
Priority
20
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
2475
Created
Saturday 02 May, 2009 19:47:08 UTC
by Unknown
LastModif
Friday 08 May, 2009 01:35:06 UTC


Show PHP error messages