module google adsense -> module needs to be updated to new google variable names
- Status
- Open
- Subject
- module google adsense -> module needs to be updated to new google variable names
- Version
- 1.9.x
24.x - Category
- Error
- Regression
- Usability
- Feature request
- Feature
- Admin Interface (UI)
Modules - Resolution status
- Reviewed
- Submitted by
- Marc Laporte
- Volunteered to solve
- luci
- Lastmod by
- Bernard Sfez / Tiki Specialist
- Rating
- Description
Google changed their formula. module should now deal with:
google_ad_client = "pub-xxxxxxxx";
google_ad_slot = "02353245";
google_ad_width = 468;
google_ad_height = 15;
While we are playing here, the module should be re-organized and default should be a public service advertisementCurrent Adsense module is too complicated to set-up as we can read here:
http://tikiwiki.org/Module+AdsenseThere are way too many forum posts for something which should be really simple to set up:
http://tikiwiki.org/tiki-searchindex.php?highlight=adsense&where=forumsSo, I suggest:
The public service advertisement should appear instead of the current "You forgot your Google ad_client number !" message. So people would know right away that the connection with Google is OK.
By default, it should be a fairly small ad so it fits nicely in a module.
And if the user is admin level (check for tiki_p_admin), then, add a link to documentation on how to set pub-xxxxxxxxxxxx and others...
http://doc.tikiwiki.org/tiki-index.php?page=Module+adsenseSo, if no pub-xxx number is set, use pub-xxxxxxxxxxxx (which provides the public service advertisement) with a warning for admins.
If the admin specifically wants a public service advertisement, he can set the pub number as pub-xxxxxxxxxxxx. In which case, there should not be a warning to admins on how to set.
Finally, if the pub number is set normally (ex.: pub-1234...), no admin warning should appear.
- Files
- Importance
- 7
- Priority
- 35
- Demonstrate Bug on Tiki 19+
-
This bug has been demonstrated on show2.tiki.org
Please demonstrate your bug on show2.tiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show2.tiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Demonstrate Bug (older Tiki versions)
-
This bug has been demonstrated on show.tikiwiki.org
Please demonstrate your bug on show.tikiwiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show.tikiwiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Ticket ID
- 1306
- Created
- Monday 13 August, 2007 11:29:07 UTC
by Unknown - LastModif
- Saturday 06 July, 2024 10:21:44 UTC