Loading...
 
Skip to main content

Category: Patch

When you submit a fix, either by attaching a file or by posting a diff of the code
Patch
Show subcategories objects

Name Type
Mail doesn't work for wiki
I configured the mail-in service for the wiki,I tried with wiki-append, wiki,... configuration but the mail-in doesn't work as aspected. The page, if needed, is created but the body is not updated

I tried with outlook 2003 from the local intranet and also from the web interface of GMail.

thanks
Christian
tracker item
Mailman WikiPlugin
With this Wiki-plugin it's very easy to subscribe to Mailman mailinglists. You can determine if you want to put a Name field or only the input for the email address. The plugin might need some polish, esp. in the smarty template but works fine so far.
tracker item
Mail-In to Forum does not follow thread when original post has moved
I am using tikiwiki for a project at work, and one of the features we needed was the "mail-in" forum posting. The way we use this is a sales rep will e-mail an issue to a PDL. One of the e-mail addresses in the PDL is the pop account for one of the forums for our site. The site moderator reads the new "post" (e-mail) and decides which forum the discussion belongs in and moves the post to the "correct" forum.

The problem is that once moved, replies via the PDL do not follow the original thread (to the moved forum). The best case is that they end up in the "mail-in" forum location.
tracker item
Minify and cache js and css files, with an admin panel to refresh
Productization: Create admin preference to enable/disable minify
https://bugzilla.mozilla.org/show_bug.cgi?id=502092

Implement Admin panel/setting to flush/rebuild Minify cache
https://bugzilla.mozilla.org/show_bug.cgi?id=497703

[https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=minify&product=support.mozilla.com&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=|All "minify" related]

This cache should also be deletable


http://code.google.com/p/minify/
tracker item
Minor Stats bug in tiki-setup.php
Tiki login page wrongfully increments tiki_pageviews hit count
tracker item
Missing translation tag in tiki-upload_file.tpl
File /templates/tiki-upload_file.tpl
row 284

{CODE(wrap="0" colors="smarty")}<label for="filetype">File Type:</label>{CODE}

Translation tag is missing. Should be:

{CODE(wrap="0" colors="smarty")}<label for="filetype">{tr}File Type:{/tr}</label>{CODE}
tracker item
Mod GMAP - File Correction in 4.2
Current mod GMAP does not work in 4.2.

Not sure about other versions
tracker item
module forum_last_topics shows wrong forum name with rigth topics
The module forum_last_topics mixes wrong forum names with rigth topic names.
tracker item
multiple forumlists
{syntax type="tiki" editor="plain"}
I want to have multiple forums or (forum_lists) in tikiwiki, because, for example, I want my users to contribute exclusively under the gfdl in one forumlist, but may post copyrighted content in another forumlist.

Current situation: From the menu, the users can click on the forums link which leads them to tiki-forums.php. This displays a list of all the forums the user has the right to see listed, with sections.

The idea is to add an extra argument in the url which specifies which forumlist the user wants to see. example: tiki-forums.php?bigforum=gfdlforum and tiki-forums.php?bigforum=copyrightedstuff
A forum can "belong" to only one "bigforum", or forumlist, so this means an extra column in tiki_forums in the db.

Modifications to tiki-forums.php, right after

{CODE()}
// This shows a list of forums everybody can use this listing
include_once ("lib/commentslib.php");
$commentslib = new Comments($dbTiki); {CODE}

I put

{CODE()}

// Check for bigforum attribute in url, and assigns it to bigforum variable. If not, display an error page. this means tiki-forums.php displays an error page.

if (isset($_REQUEST["bigforum"])) {
$bigforum = $_REQUEST["bigforum"];
} else {
$smarty->assign('errortype', 401);
$smarty->assign('msg', tra("Permission denied you cannot view this page"));

$smarty->display("error.tpl");
die;
} {CODE}

And in commentslib.php, in the list_forums function, after

{CODE()} if ( $res['forumId'] != '' && $this->user_has_perm_on_object($user, $res['forumId'], 'forum', 'tiki_p_forum_read') ) { {CODE}

I put

{CODE()} if ( $bigforum == $res['bigforum'] ){ {CODE}
with an extra closing } somewhere down the road.


The bigforum attribute must be manually added in the db, but appart from that it works. better integration with the rest of Tiki would be awesome, url rewrite could give something like tiki.org/forums/IDorNAMEoftheBigforum/


All of this is just broken hacking and my first attempt at doing something, so don't be too harsh ;)
tracker item
Multiple IE fixes for tiki-js.js and tiki-jquery.js TikiWiki V4.2
{syntax type="tiki" editor="plain"}
Multiple problems exist with TikiWiki tiki-js.js and tiki-jquery.js scripts in relation to editing wiki pages with the Wiki editor. The problems vary by IE version:

* IE requires the 'label' property to be set in 'Option' objects
* IE editing requires use of textRanges
tracker item
not possible to ADD new task into user tasks in user-task module
if you enable user-task module and you are on URL with some querty, like http://server/tiki-index.php?page=xxxxx and you try to add new user taks, you will get errror

because the string which is created as action for form submit is wring
tracker item
Object accessed as array causes fatal error
Installer fails at the end with the following error:

"Fatal error: Cannot use object of type stdClass as array in
/tiki/lib/core/Search/Indexer.php on line 64"
tracker item
One can not put more then one RSS feed on a wiki page
One can not put more then one RSS feed on a wiki page. Following patch fixes that.
tracker item
Only let the admin change the admin details
There is a very common use case where a specific Group should be given User admin permission, ie tiki_p_admin_users, so that the setting up of new users can be delegated.

However this permission allows the user with these added permissions to edit the admin details and therefore be in a position to assign new users and themselves to the Admins Group - which has 'security' (in the broadest sense) implications.

Changes that avoid this are needed so that the admin details can only be changed by the admin.

FIXED
tracker item
Out of memory bug in tiki-edit_templates.php
Hi,

I've just been testing Tiki to see if it will suit my needs. Came across the following bug in tiki-edit_templates.php whenever I tried to edit any templates or CCS.

Whenever I tried to click on the Edit Button for templates I got the following error:

PHP Fatal error: Allowed memory size of XXX bytes exhausted (tried to allocate XX bytes) in tiki-5.1/lib/init/initlib.php on line 185

System setup

System: FreeBSD 8.1
Web Server: Apache 2.2.16
Php: 5.3.3

Key issue was when looking for templates to list - around line 112 in tiki-edit_templates.php. The code would get stuck in an endless loop trying to get the files a directory that failed to open, exhausting stack size. The following directories would attempt to be opened:

tiki-5.1/templates - opened OK
tiki-5.1/templatesmodules - failed to open causing loop to get stuck.

The templatesmodules directory would fail to open.
tracker item
Pages with spaces in their names cannot be accessed from a Wiki dump.
{syntax type="tiki" editor="plain"}
If I have a wiki page SomePage that has a link "Page With Space" in it, when I dump the wiki, the generated HTML in SomePage.html doesn't have a correct hyperlink in it to get to Page With Space.html.

The hyperlink contains plus signs instead of spaces (or %20) like Page+With+Space.html, but the target page on disk is called Page With Space.html. Clicking on the link in SomePage.html generates a file not found error.
tracker item
Patch for aulawiki.1.6 to run on tikiwiki.2.2
patch for aulawiki.1.6 to run on tikiwiki.2.2
tracker item
Patch for Plugin ATTACH bug reported in bug tracker id 2474
As noted in bug tracker id 2474, bullets parameter doesn't create a bulleted list. "All" list is poorly formatted with page links that don't work.
tracker item
Patch to allow support for Active Directory authentication via LDAP
Active Directory doesn't allow for anonymous searches of its structure. Instead, an username and password for an account with search access must be given when connecting.
tracker item
Patch to bug report 3727
{syntax type="tiki" editor="plain"}
The attached file updates the SQL wiki plugin so that the user has a choice whether the returned data should be Wiki parsed or not instead of just preventing it. Parsing is the default with "noparse=>1" preventing the parsing. There are also two additional features added to the code:
# "raw=>1" will eliminate any headers or formatting.
# "delim=>'|'" will set the data delimiter for columns to being an "or" bar. Any other separator can be used.

These additional features are useful when selecting summary data like "count(*)" and resultant headers are unwanted or when selecting data normally, but wanting to format the output aside from the standard SQL return.

There is a remaining issue with the submitted patch. While I have updated the help array at the top I don't know how to make the new parameters reflected in the GUI help system as seen by the user when accessing the plugin through the help system.

I will update the SQL plugin documentation on the Tiki site if this patch is accepted. Doing so before-hand will only set false expectations for functionality not yet there.

--Steve
tracker item
Patch to staging & approval
Staging & Approval fails if incorrect $edit_minor parameter type is supplied to the function update_page. This is the case in Tiki 6.3

This causes the whole staging & approval mechanism to fail.
tracker item
Patch: setup_smarty.php get_filename fails if tikidomain is empty
{syntax type="tiki" editor="plain"}
tikiwiki-5.0.Beta1\setup_smarty.php, line 251, in function get_filename:
$file = '';
may be replaced by
$file = '/';
tracker item
Plugin DBReport with mPDF enhancement
Hi Devs!

My setup:

Tiki: 18.0
PHP: 7.0.32
Linux: CentOS 7
mPDF: v7.0.3

One feature that bothered me was the lack of repetition of the header in PLUGIN DBReport when generated in PDF (usually via PLUGIN LISTEXECUTE) in tables that were divided into more than one page.

Reading the mPDF [https://mpdf.github.io/tables/tables.html#repeating-table-header-row-on-new-page|documentation] I discovered that the header line that was wrapped around the < thead> TAG is repeated on each page that the table is split.

!!Repeating Table Header row on new page
''If a table is split onto more than one page, the first row of the table will be repeated at the top of the new page if < thead> or < tfoot> is defined''


I changed the code in /lib/wiki-plugins/wikiplugin_dbreport.php file as the snippet below:

{CODE()}
615 public function header_row_html($data)
616 {
617 $html = '';
618 // generate a new table
619 if (isset($this->style)) {
620 $html .= '<table' . $this->style->attributes() . '>' . "\n" . '<thead>' . "\n";
621 } else {
622 $html .= '<table>' . "\n" . '<thead>' . "\n";
623 }
624 // write headers
625 $style_index = 0;
626 if (isset($this->headers)) {
627 $html .= $this->line_row_html($this->headers, $data, true);
628 }
629 $html .= '</thead>';
NEW return $html;
630 }
{CODE}

After this change, all tables generated by PLUGIN DBReport that split on more than one page in the PDF file automatically repeats the header.

I believe that other PLUGINS that generate tables (like PLUGIN LIST, for example) can benefit from this functionality (thead TAG involving the header line).

I have helped in something.

Salutes from Brazil!

tracker item
Plugin to display the toc of a selected page.
For multipage wikis the display of the "table of content" using __maketoc__ isn't ideal as this statement requires to be placed on every page otherwise it wouldn't be visible for other pages.
Usually this "table of content" is used for quick navigation purposes. Therefore an alternate to the __maketoc__ statement should be provided which should allow to specify the wikipage which shall be outline. Such a statement can then be used in a module nearby the original wikipage.
tracker item
pretty tracker wiki-parses all fields
Inefficient and it is perhaps also a security leak.
See
[http://irc.tikiwiki.org/irclogger_log/tikiwiki?date=2010-10-12,Tue&sel=56#l52|irc log]

tracker item
Show PHP error messages