Category: Upgrade Blocker

I am currently testing a __Tiki 24 trunk as a local office software__ on my work laptop.
The Tiki is still in the process of configuration, setup and testing.

I use a Mint/Ubuntu 18 Linux. I use a standart Apache2 / Mysql/PHP (7.4/8.0) installation, each part installed with the command line (not a prepacked Xampp/Lampp).
Side note to PHP version:
I could not install Tiki with PHP 8.0 (WSOD issue) and did install it then with PHP 7.4 running
Later when I installed a number of Packages, Tiki requested PHP 8.0 and it stopped working with PHP 7.4 (WSOD). Thus this Tiki 24-trunk is currently running on PHP 8.0

''I have also a number of file permission errors and some issue with a search index error message, which I will report later on in the forums or with another bug report.''

Tiki is installed __via SVN__ and runs in __/var/www/html/tiki__ .

One of several issues with my Tiki trunk installation is, that instantly after installing __Tesseract OCR in Tiki via Packages__, I get the following type of error messages:

{CODE()}
Fatal error: Uncaught thiagoalessio\TesseractOCR\TesseractNotFoundException: Error! The command "sh: 1: where: not found" was not found. Make sure you have Tesseract OCR installed on your system: https://github.com/tesseract-ocr/tesseract The current $PATH is /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin in /var/www/html/tiki/vendor/thiagoalessio/tesseract_ocr/src/FriendlyErrors.php:40 Stack trace: #0 /var/www/html/tiki/vendor/thiagoalessio/tesseract_ocr/src/TesseractOCR.php(85): thiagoalessio\TesseractOCR\FriendlyErrors::checkTesseractPresence() #1 /var/www/html/tiki/lib/ocrlib.php(278): thiagoalessio\TesseractOCR\TesseractOCR->executable() #2 /var/www/html/tiki/lib/ocrlib.php(208): ocrLib->newTesseract() #3 /var/www/html/tiki/tiki-check.php(1995): ocrLib->getTesseractLangs() #4 {main} thrown in /var/www/html/tiki/vendor/thiagoalessio/tesseract_ocr/src/FriendlyErrors.php on line 40
{CODE}

I have definitely Tesseract installed on my laptop, but I do not (yet) know the installation path:

{CODE()}
Torsten@Linux:/var/www/html/tiki$ tesseract
Usage:
tesseract --help | --help-extra | --version
tesseract --list-langs
tesseract imagename outputbase [options...] [configfile...]

OCR options:
-l LANG[+LANG] Specify language(s) used for OCR.
NOTE: These options must occur before any configfile.

Single options:
--help Show this help message.
--help-extra Show extra help for advanced users.
--version Show version information.
--list-langs List available languages for tesseract engine.
{CODE}

I create a new Tiki 24 from git 6188b548 · [REL] Closing 24.0 beta release · 16 hours ago from scratch.
I created a duplicate database to install it with previous data.
Tiki successfully detect the database connection.
The installer didn't proposed me the usual choice (update or create).
I continued to check and ended with a database emptied and reseted.

This is a critical as new admin may not understand there is a problem here and proceed.

See the video here: {file type="gallery" fileId="1730" showicon="y"}

I retried with a different database and it was the same.

See second video here: {file type="gallery" fileId="1731" showicon="y"}

I upgraded a Tiki21.4 from SVN that was using Chosen to a Tiki23.x from Git using Select2 instead.

If I look at some multiselect tracker fields type, I see that there is no more "Multiples-selection Checkboxes" option and that field values where it was set have been emptied.

I suspect this is a regression introduced when we removed Chosen for Select2.

If you don't touch it, checkboxes are displayed and the tracker items seems ok.
If you select the only option available you can't get back checkboxes till you empty the selection... ?
It is quite confusing.

{img fileId="1673" thumb="box"}
{img fileId="1674" thumb="box"}

On a tracker with a file field create an item.
Upload a file or browse for an existing file in your file gallery.
When you click on the select button (label should be "save the file" or "insert file or...) the modal close and you lost everything you entered in the form.

The picture is however uploaded to the relevant file gallery.

It was working fine not so long ago...

https://share.vidyard.com/watch/p77y8bHmKaJSvM67AppFkM?
https://share.vidyard.com/watch/RYDLTaz48zzjWZXqJfpr7s?

I upgraded a Tiki18 to Tiki21 to find out that textArea multilingual is not filtered in the plugin List.

All languages are displayed in a customSearch instead of displaying the only language that correspond to the actual language. (I suspect it will be the same in a List plugin).

Here the tracker edit view showing different languages for different fields (title, abstract, ...)
{img fileId="1418" thumb="box"}

Here the tracker view with English language selected (content is displayed for english only that’s correct)
{img fileId="1419" thumb="box"}

Here the customSearch view with English language selected but all languages are displayed for the field Abstract (note that title, a text field, is working fine)
{img fileId="1417" thumb="box"}

On a multilingual Tiki23 that was working fine and regularly updated and tested I have for a tracker item name 3 values (for each language):
en = Web App
fr = App Web
he = ווב אפ׳

{img type="fileId" fileId="1702" thumb="box"}

By default the title used by the unified index is the English one "Web App".
And the following filters in a plugin list was working fine no matter which language is selected by the user
{CODE()}{filter field=tracker_id content=16}
{filter field=title exact="Web App"}{CODE}

Since a few commits it is not working anymore and return a "no result found". (tested on Safari and Chrome)
The default title for an item used now is the French one and not the English one as previously. (no matter the language selected on the site)

{img type="fileId" fileId="1703" thumb="box"}

On a Tiki24 and Tiki25 I use 2 trackers to create an item in a third tracker.

Tracker A : Store the holidays name, their start/end dates (user display)and an item list of days from Tracker B.
Tracker B : Store each date as item for a specific Holiday, The name (item link from tracker A) and the date selected.
Tracker C : Store orders, user select a Holiday (item link) and a list of available days is proposed (dynamic item list with items from Tracker B)

It has been used for years (since 2018 with the different Tiki versions)
It was working fine with Tiki25 in March 2023.
I suspect that a commit related to this tracker field was made the dynamic item list in Tracker C is not working (not populated) anymore.

https://gitlab.com/tikiwiki/tiki/-/merge_requests/2500
Now I beleive that it has been backported to Tiki24: https://gitlab.com/tikiwiki/tiki/-/merge_requests/2511


Test videoshoot using Tiki24.3 (last update in December). As we can see in that video the dynamic list field is populated properly (I don't even had to refresh the index)
{file type="gallery" fileId="2045" showicon="y"}

Test videoshoot using Tiki25 (last update 19/04/2023). As we can see in that video the dynamic list field is empty and not populated properly (I did rebuilt the index)
{file type="gallery" fileId="2046" showicon="y"}

I have a Tiki running elasticSearch set to use the time zone Asia/Jerusalem and the sample on the settings page displays correct information.
{img fileId="1775" thumb="box"}

I have trackeritems with a date field (picker) to select dates.
For exemple I have an item (5761) with a human readable value of : 7/04/2022
{img fileId="1776" thumb="box"}

However the value displayed for this date displayed from the unified index ===is the 6/04/2022===
I can see it in the database
I can see it in the plugin list test tool
And of course in the plugin list used to display the value to the visitors

{img fileId="1778" thumb="box"}
{img fileId="1779" thumb="box"}
{img fileId="1780" thumb="box"}

The index is being rebuilt properly and I don't see any warning there:
{CODE()}2022-03-08T06:27:07+00:00 INFO (6): addDocument trackeritem 5761 {"memoryUsage":"33.4 MiB"}{CODE}

Additional informations:
When I call the value from a different trackers (using a Dynamic Items List) the value displayed for the date is correct:
{img fileId="1781" thumb="box"}

In my smarty template I use dates format:
{CODE()}
<span class="font-weight-bold">{tr}{$days.tracker_field_holidaycampsDayDay|date_format:"%A"}{/tr}</span> <span class="small">{$days.tracker_field_holidaycampsDayDay|date_format:"%d"}/{$days.tracker_field_holidaycampsDayDay|date_format:"%m"}</span>
{CODE}

This was working fine on Tiki23 and is a major regression

Clicking on the first option of a file gallery, admin (tiki-list_file_gallery.php?galleryId=11&view=admin) results in an uncaught exception:

Fatal error: Uncaught --> Smarty: undefined extension class 'Smarty_Internal_Runtime_CheckPlugins' <-- thrown in MYDIRECTORY/tiki-18.6/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_undefined.php on line 62

It appears that from v18.10 to v18.11 the path to "jquery.ui.nestedSortable.js" changed from:
vendor_bundled/vendor/jquery/plugins/nestedsortable/jquery.ui.nestedSortable.js
to:
vendor_bundled/vendor/jquery-plugins/nestedsortable/jquery.ui.nestedSortable.js
(Note the sub-folder vs. the dash "jquery-plugins")

But the code is still looking for it in the old location.

In the Admin Structures interface, this results as a 404 error on the js console and breaks the feature. It's impossible to drag any items in the Structure or page list in the Admin Structures interface.

I've upgraded today to latest 20.x (to r71082, from svn code from 1-2 months ago or so) and attempting to insert wiki code to display a file in a wiki page (just after file upload) fails: not the full syntax is written, just "file", and no fileId either.
File seems to get uploaded successfully indeed, but the popup helper (open through the toolbar icon to upload files) fails to display the information that the file was uploaded successfully, not to insert the right syntax to that file.

{img fileId="1329"}

Reproduced with updated Firefox and Chrome, on Ubuntu GNU/Linux 64 bits (in case it matters)
And reproduced in dev.t.o also (provided that the tool -+tikifile+- has been added to the editor toolbar.{sign user="xavi" datetime="2019-09-27T11:06:15+00:00"}

Using standard file gal interface (not elfinder), and standard wiki editor toolbar, and using toolbar icon -+tikifile+-.
Same process to upload images works as usual, as expected.

https://doc.tiki.org/tiki-admin.php?page=wiki is broken:
{CODE()}Fatal error rendering template resource tiki.tpl
TypeError: Cannot access offset of type string on string in /home/tiki-doc/public_html/temp/templates_c/en_social^ea0943f75a262d8be544059ae17e04e9602d1469_0.file.header.tpl.php:65
Stack trace:
#0 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_64ff5e10934248_92322649()
#1 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
#2 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(217): Smarty_Template_Compiled->render()
#3 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(386): Smarty_Internal_Template->render()
#4 /home/tiki-doc/public_html/temp/templates_c/en_social^0c780eb23ca96bccad634bcfe8b1582ea34cbefc_0.file.layout_view.tpl.php(40): Smarty_Internal_Template->_subTemplateRender()
#5 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_64ff5e1268df80_55684014()
#6 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
#7 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(217): Smarty_Template_Compiled->render()
#8 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(386): Smarty_Internal_Template->render()
#9 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_runtime_inheritance.php(116): Smarty_Internal_Template->_subTemplateRender()
#10 /home/tiki-doc/public_html/temp/templates_c/en_social^a242164352b905110d239d535f6a556a33d17bf9_0.file.tiki.tpl.php(38): Smarty_Internal_Runtime_Inheritance->endChild()
#11 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_64ff5e121411a2_61382528()
#12 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode()
#13 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_template.php(217): Smarty_Template_Compiled->render()
#14 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(238): Smarty_Internal_Template->render()
#15 /home/tiki-doc/public_html/vendor_bundled/vendor/smarty/smarty/libs/sysplugins/smarty_internal_templatebase.php(134): Smarty_Internal_TemplateBase->_execute()
#16 /home/tiki-doc/public_html/lib/init/smarty.php(492): Smarty_Internal_TemplateBase->display()
#17 /home/tiki-doc/public_html/tiki-admin.php(515): Smarty_Tiki->display()
#18 {main}
{CODE}

Adding wiki syntax in a custom modules will broke it:
* Changes are not always saved (editing is lost)
* Throw error
* Reload the page

Check http://bsfez-11581-7774.show2.tikiwiki.org
Try to add/edit one of the top message module.

On a real server using Debian 10 + Virtualmin as set following : https://bsfez.com/article58-Install-Tiki-Wiki-from-Git-Virtualmin-and-Debian-10-on-AWS-EC2-instance Hebrew and French accent are now broken in module only (so far).

{img fileId="1727" thumb="box"}

Same on a fresh local Tiki24 Beta

{img fileId="1728" thumb="box"}

On both case I used to upgrade an existing database. (tiki22 and tiki24alpha)


I created an instance on show2 where it is working fine.
I compared http://bsfez-11581-8080.show2.tikiwiki.org/tiki-check.php with mine https://www.bernardsfez.com/tiki-check.php and there are quite the same about encoding.
Version 10.3.31-MariaDB-0+deb10u1 (my server)
Version 5.7.34 (my local)
Version 10.1.48-MariaDB-0ubuntu0.18.04.1 (show instance)

I reverted the last update and things are back to normal (this ticket).
So the use is caused by one of these:
Prevent too-narrow side columns when fixed-width pref is set; update...
Gary Cunningham-Lee authored 1 day ago
dc087cb8
Revert "Fixed custom module name update creates new custom module"
Jonny Bradley authored 3 days ago
f1a4233b
[UPD][FIX] Kanban: added feature user permissions control; UI minor updates and fixes
Andon Andonov authored 4 days ago
bf3b6f1f
[FIX] Fix issue with constant TIKI_PATH already defined with installing tiki
Jorge Sá Pereira authored 4 days ago and Jorge Sá Pereira's avatar Jorge Sá Pereira committed 4 days ago
117d8b00
[FIX] Translate tags on installer page
Henock authored 1 week ago and Jorge Sá Pereira's avatar Jorge Sá Pereira committed 4 days ago
7ec89d7a
[FIX] freetags: Limit the query getting tag suggestions to the $max number...
Jonny Bradley authored 6 days ago
aeb630dd
[FIX] categories: Cache the category tree html, takes a while to build with over 1,000 categories
Jonny Bradley authored 6 days ago
4c75359c
[FIX] modules: Check if there are any divs in a module's output first before using one
Jonny Bradley authored 6 days ago
59278409
[FIX] Fix module printing bugs
Henock authored 1 week ago and Jonny Bradley's avatar Jonny Bradley committed 6 days ago
f795cb4d
[FIX] i18n: Don't ask which language to use for a new wiki page but there is...
Jonny Bradley authored 6 days ago
6a88b93b
[FIX] lastmodif_pages: Make the number of days to search for modified pages...
Jonny Bradley authored 6 days ago
11811b22
[FIX] login: Start a session when showing the login module if...
Jonny Bradley authored 6 days ago
290475a2
[FIX] imagegals: Even more tidyup from image gallery removal (was breaking rename username)
Jonny Bradley authored 1 week ago
fc0a57ec
Fix broken pipelines
Jorge Sá Pereira authored 1 week ago
e1ab4c0f
[UPD] Updated composer.lock
Henrique Borba authored 1 week ago and Marc Laporte's avatar Marc Laporte committed 1 week ago
0ce38db9

On a Tiki21.4 the feature Category is enable.
This Tiki has 362 category with many child (child) categories.
Some Categories contains non alphanumeric characters.
Like :
* A) Music, 1) Albums, etc
* 1. Joe, 2. Jack, etc
* Archive : blabla, Archive : dododo

In the Control Panel => Categories. the option "Limit wiki page categories to those under this category" (feature_wiki_mandatory_category) is set to "All".
It is possible to add a plugin using the tools on a customised toolbar or using the help tools (on the toolbar)

---

After an upgrade to Tiki23 It is NOT possible anymore to add a plugin using the tools on a customised toolbar or using the help tools (on the toolbar). The existing plugins are working and copy/paste is working.
If I switch "Limit wiki page categories to those under this category" to none everything is working as expected.

I tried to reproduce on the instance attached to the ticket. But I was stopped in my attempts.
If I create a category with a colon ":" the instance crash with a 500.

It is weird that plugin insertion is broken due to something in the category...
They may be some "invisible" limit of the number of Categories you can have to avoid this bug.
It may be related to the character allowed in a category name.

This will be a problem for people upgrading from Tiki21.4 (LTS) to Tiki 23 and Tiki24 (I guess)
Wiki pages and Categories are popular features.

On Tiki26 and master if the look and feel, site layout (tiki-admin.php?page=look#contentadmin_look-2) is not set to "single container" the edit modal for a wikiplugin is not displayed.

Tested on a local and remote Tiki26.x (26.0 and 26.1).
Reproduced at https://next.tiki.org/Community

{mediaplayer src="display2123"}

See: https://dev.tiki.org/item8387-Wiki-edit-help-plugin-modal-not-displaying

{syntax type="tiki" editor="plain"}
You can't see or edit the left or right column modules on tiki-admin_modules.php any more (without clicking show hidden modules, and when you save anything they get hidden again).

Critical regression, release blocker!

In tiki-calendar_nav.tpl the display of calendar dates is formed (template), but in a IMHO rather bizarre mix of hard-coded and localizable syntax, which
a) does not make use and thus circumvents the existing user pref for date formats and
b) effectively makes correct localization impossible.

I quote from this template a code snippet:

{CODE(colors="tiki")}
{if $viewlist ne 'list' or $prefs.calendar_list_begins_focus ne 'y'}
{if $calendarViewMode eq 'month'}
{$daystart|tiki_date_format:"%B %Y"}
{elseif $calendarViewMode eq 'week'}
{* test display_field_order and use %d/%m or %m/%d *}
{if ($prefs.display_field_order eq 'DMY') || ($prefs.display_field_order eq 'DYM') || ($prefs.display_field_order eq 'YDM')}
{$daystart|tiki_date_format:"{tr}%d/%m{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%d/%m{/tr}/%Y"}
{else}
{$daystart|tiki_date_format:"{tr}%m/%d{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%m/%d{/tr}/%Y"}
{/if}
{else}
{$daystart|tiki_date_format:"%B %Y"} - {$dayend|tiki_date_format:"%B %Y"}
{/if}
{else}
{$daystart|tiki_date_format:"{tr}%m/%d{/tr}/%Y"} - {$dayend|tiki_date_format:"{tr}%m/%d{/tr}/%Y"}
{/if}
{CODE}

So there is some testing for localized date format, but it assumes that only the order of day and month may be swapped through translation? This only works inside the USA or partly in the UK. It does not work in Germany, and not in Japan and possibly conflicts with other countries as well.

Germany uses
{CODE(colors="tiki")}
%d.%m.%Y
{CODE}

Japan uses
{CODE(colors="tiki")}
%Y-%m-%d
{CODE}

Look at the peculiar coding in tiki-calendar_nav.php. To magnify, I have extracted one example that clearly shows the logical error in it:

{CODE(colors="tiki")}
{$dayend|tiki_date_format:"{tr}%d/%m{/tr}/%Y"}
{CODE}

The year was excluded from translation and also the slash that comes before the year (at least in the USA...). So the slash cannot be removed by custom.php, because it is outside the translation. And it would be even worse for a localization into Japanese, because of their year leading the date...

It would be far better if date format was used in the form of the user pref that exists! But for a faster "quick resolution" moving the %Y into the translation braces would do the trick, and later introduce the "proper" way... Thanks.

When changing a wiki structure with drag and drop in tiki-edit_structure.php, the 'save' button doesn't appear as it does in Tiki 18/19.
It's keeps being hidden by css with display:none, beside that it also doesn't work; it will not save the changes.

Please see as showed here, it's possible to drag a new page in to the structure but there is no save button.
http://wobow-11900-7179.show2.tikiwiki.org/tiki-edit_structure.php?page_ref_id=1

On Tiki23, Tiki24 and master there is a regression as the user preferences "Language" is "forced" by default to French.

On a new installation ===as soon=== as I enable Multilingual features the tiki displays in French. (the other options like default language are still on English).

{img fileId="1707" thumb="box"}
{img fileId="1708" thumb="box"}

It seems the user preferences are set by default with the French language and are taking over even if I didn't set anything.

{img fileId="1709" thumb="box"}

It is also possible as the option "Users can choose the language of their interface" that is enable by default (even if multilingual is disable) BUT this setting is not accessible for the user as "User preferences screen " is disable by default. They are needed together !
If "Users can choose the language of their interface" then obviously they should be able to do it (User preferences screen should be enable) else they will be stuck with a possible language selection they can't change. (like what we have now).

In Tiki23 a new dropdown was added to improve the UX and action selection.
Something nice BUT once you upgrade it will resets the previous and existing scheduled tasks without warning.

See : https://gitlab.com/tikiwiki/tiki/-/commit/a77af6f7da9f41e647de91693d8f0edbe0110616

We receive many issues while people try to register. So I went to test out what is going on... While testing new user registration in new incognito mode Chrome I got this when I submitted the filled in form:
{img fileId="1361" thumb="box"}

Not a good feedback to the user trying to register :(

Steps to reproduce:

# open new incognito window
# go to https://tiki.org/login
# click the Register link in the login form which brings you to https://tiki.org/tiki-register.php?key=randomstring
# fill in the form and click "Register" button
# you get the error screen

__Anyway, the user was created.__
As an admin I received immediately a watch notification email first:
^__User joined Registered__
The user lucitest joined Registered%%%
at: Sun 23 Feb 2020 17:13 CET^

Then --after some minutes (17:21 CET)-- 17:14 CET I received "Community Members Information" tracker email about the Item Creation too __with no link to validate the user__ (but at that time I validated the test user manually already).

We also receive many registration attempts (in comparison as seen while watching user joining Registered group) __without__ any tracker or validation link emails coming out / being received at all.
---
Confirmed sadly {sign user="jonnybradley" datetime="2020-03-09T17:22:33+00:00"}

Same as Bernards report but creating a Show Instance for Tiki 21x (if that's possible)

See https://dev.tiki.org/item7496-Not-possible-to-add-a-file-in-a-tracker-item-tracker-field-file-Data-is-lost