Loading...
 
Skip to main content

module google adsense -> module needs to be updated to new google variable names

  • Tracker item actions
Trackers Items
Status
Open
Subject
module google adsense -> module needs to be updated to new google variable names
Version
1.9.x
24.x
Category
  • Error
  • Regression
  • Usability
  • Feature request
Feature
Admin Interface (UI)
Modules
Resolution status
Reviewed
Submitted by
Marc Laporte
Volunteered to solve
luciash d' being 🧙
Lastmod by
Bernard Sfez / Tiki Specialist
Rating
(0)
Description

Google changed their formula. module should now deal with:
google_ad_client = "pub-xxxxxxxx";
google_ad_slot = "02353245";
google_ad_width = 468;
google_ad_height = 15;


While we are playing here, the module should be re-organized and default should be a public service advertisement

Current Adsense module is too complicated to set-up as we can read here:
http://tikiwiki.org/Module+Adsense

There are way too many forum posts for something which should be really simple to set up:
http://tikiwiki.org/tiki-searchindex.php?highlight=adsense&where=forums

So, I suggest:

The public service advertisement should appear instead of the current "You forgot your Google ad_client number !" message. So people would know right away that the connection with Google is OK.

By default, it should be a fairly small ad so it fits nicely in a module.

And if the user is admin level (check for tiki_p_admin), then, add a link to documentation on how to set pub-xxxxxxxxxxxx and others...
http://doc.tikiwiki.org/tiki-index.php?page=Module+adsense

So, if no pub-xxx number is set, use pub-xxxxxxxxxxxx (which provides the public service advertisement) with a warning for admins.

If the admin specifically wants a public service advertisement, he can set the pub number as pub-xxxxxxxxxxxx. In which case, there should not be a warning to admins on how to set.

Finally, if the pub number is set normally (ex.: pub-1234...), no admin warning should appear.

Files
  1. Mod Newadsense
  2. Mod Newadsense
Importance
7
Priority
35
Demonstrate Bug on Tiki 19+
Please demonstrate your bug on show2.tiki.org
Demonstrate Bug (older Tiki versions)
 Show.tiki.org is currently unavailable

Unable to connect to show.tikiwiki.org. Please let us know of the problem so that we can do something about it. Thanks.

Ticket ID
1306
Created
Monday 13 August, 2007 11:29:07 GMT-0000
by Unknown
LastModif
Saturday 06 July, 2024 10:21:44 GMT-0000