Fullscreen
Loading...
 
Skip to main content

Using Editing icons doesn't work with Tiki29.x

Status
Open
Subject
Using Editing icons doesn't work with Tiki29.x
Version
29.x
Regression from 28.x to 29.x
Category
  • Regression
  • Easy for Newbie Dev
Feature
Edit interface (UI)
Wiki (page view, edit, history, rename, etc)
Resolution status
New
Submitted by
Bernard Sfez / Tiki Specialist
Lastmod by
Bernard Sfez / Tiki Specialist
Rating
(0)
Description

On a Tiki29.x (tested before and after Tiki29.1 release) when I use the Wiki page, Action, Edit icons nothing happens.

On a Tiki Wiki 29, when I try to edit a plugin using the plugin edit icon it doesn't open the dialog.

In the console I see it create a 500.

I see in the PHP error logs:

Copy to clipboard
[Sun Feb 08 20:34:34.809307 2026] [proxy_fcgi:error] [pid 3852014:tid 140443887073024] [client 127.0.0.1:53564] AH01071: Got error 'PHP message: PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function TikiLib::safeFileExistsInPath(), 1 passed in /var/www/vhosts/mydomain.org/httpdocs/lib/core/Services/Edit/PluginController.php on line 273 and exactly 2 expected in /var/www/vhosts/mydomain.org/httpdocs/lib/tikilib.php:7314\nStack trace:\n#0 /var/www/vhosts/mydomain.org/httpdocs/lib/core/Services/Edit/PluginController.php(273): TikiLib->safeFileExistsInPath()\n#1 /var/www/vhosts/mydomain.org/httpdocs/lib/core/Services/Broker.php(140): Services_Edit_PluginController->action_edit()\n#2 /var/www/vhosts/mydomain.org/httpdocs/lib/core/Services/Broker.php(27): Services_Broker->attemptProcess()\n#3 /var/www/vhosts/mydomain.org/httpdocs/tiki-ajax_services.php(53): Services_Broker->process()\n#4 /var/www/vhosts/mydomain.org/httpdocs/route.php(400): include('...')\n#5 {main}\n thrown in /var/www/vhosts/mydomain.org/httpdocs/lib/tikilib.php on line 7314', referer: https://mydomain.org/Mypage


I checked PluginController.php, safeFileExistsInPath.

The function safeFileExistsInPath() requires two parameters: the file and the directory to check it against. But in PluginController.php, it's only being called with one parameter.

Solution

At PluginController.php line 273 I replaced:

if ($file = TikiLib::lib('tiki')->safeFileExistsInPath($file)) {
With
if ($file = TikiLib::lib('tiki')->safeFileExistsInPath($file, 'modules/')) {

Fixed the issue.

Workaround
Importance
7
Easy to solve?
7
Priority
49
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
8915
Created
Sunday 08 February, 2026 20:14:13 UTC
by Bernard Sfez / Tiki Specialist
LastModif
Sunday 08 February, 2026 20:15:54 UTC


Show PHP error messages