Wiki page title (pagetitle) display has some problems

• Regression
• Developer Training
• Easy for Newbie Dev

The first problem is that even when the admin preference to display the page title is turned off, there is still an empty h1 tag and heading link in the page. This takes up vertical space and the link icon is visible if the space is hovered over. Turning off the page title display should also "turn off" the heading and link code in the template. When the pref to display the page title is activated, the page title text that displays does have an h1 tag but it has no link code or icon.

The second problem is that the preference option "Display page name as page title" causes the page title to be displayed above the main element. This is not good HTML or DOM structure, not good for accessibility, etc.

The third problem is that the preference option "Display the page name inside the page content" doesn't actually cause the page name to be displayed inside div class="content". It's not clear to me why this div was added when there was already an article element and a div id="page-data" (or why the "content" class wasn't added to the div id="page-data"), but IMO the preference name and HTML should be consistent. (Usually there's no visible difference, but a theme might give the page content a different style than the rest of the page, so in this case it's a significant distinction.) The h1 heading tag and link icon that has no text, described in the first paragraph, is actually located correctly, inside div class="content", IMO.

Comparing to versions 27 and 28, it looks like to me that the admin handling of the wiki page title display hasn't been good for a while now so I can understand the motivation to make some changes but there appears to be more work to do.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org

This bug has been demonstrated on show.tikiwiki.org

Please demonstrate your bug on show.tikiwiki.org