Fullscreen
Loading...
 
Skip to main content

Smarty icon function returns green question mark images instead of intended icons

  • Tracker item actions
Trackers
Items
Status
Open
Subject
Smarty icon function returns green question mark images instead of intended icons
Version
18.x
Category
  • Bug
Feature
All / Undefined
Resolution status
New
Submitted by
Philippe Cloutier
Lastmod by
Philippe Cloutier
Rating
(0)
Description

I have seen twice in the last 2 weeks the same bug pattern involving the Smarty icon function. When the global $iconset variable read by the function is not defined as expected, the function may fallback to $params['_id'] = 'green_question'; even if the name parameter was specified, so a green question mark displays instead of the icon supposed to show.

I have seen this:

  1. On tiki.org, following a report on tikiwiki-develQuestion
  2. On this show instanceQuestion, for at least 3 icons (those for the Modules, Permissions and Plugin approval entries of the Quick admin menu)


This persists until the server cache is cleared. I do not know how to reproduce after.

The impact is amplified by improper handling of smarty_function_icon() when it fails to find the requested icon. There should at the minimum be a PHP notice logged, and the question mark image should have a clear label such as "Unknown icon", not "Question".

Importance
3
Priority
15
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
6702
Created
Thursday 14 June, 2018 18:56:28 UTC
by Philippe Cloutier
LastModif
Tuesday 19 February, 2019 16:04:03 UTC


Show PHP error messages