Loading...
 
Skip to main content

setup.sh: Hardcoded "php" entries

Status
Pending
Subject
setup.sh: Hardcoded "php" entries
Version
17.x
Category
  • Consistency
Feature
Installer (profiles, upgrades and server-related issues)
Resolution status
Fix on the Way
Submitted by
aexoxea
Lastmod by
aexoxea, luci
Rating
(2)
Description

When locally testing use of setup.sh with a custom PHP binary location (i.e. using the -p option), I found two instances of hardcoded "php" invocations. All other invocations are done using the "${PHPCLI}" variable, so I figure these are oversights.

At this writing, trunk/setup.sh is at r64051. The hardcoded references are at:

Line 553
Copy to clipboard
curl -s https://getcomposer.org/installer | php -- --install-dir=temp

Line 556
Copy to clipboard
php -r "eval('?>'.file_get_contents('https://getcomposer.org/installer'));" -- --install-dir=temp
Solution
Fixed in https://sourceforge.net/p/tikiwiki/code/66223
Workaround
In each line, replace "php" with "${PHPCLI}". This is also the fix (unless there's something I don't understand).
Importance
3
Easy to solve?
9
Priority
27
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
6460
Created
Sunday 01 October, 2017 12:22:42 UTC
by aexoxea
LastModif
Monday 30 April, 2018 08:55:27 UTC


Show PHP error messages