Loading...
 
Skip to main content

tikilib user_watches does not filter on event

Status
Open
Subject
tikilib user_watches does not filter on event
Version
12.x
13.x
Category
  • Error
Feature
Watch (email notifications of changes)
Resolution status
New
Submitted by
oldelvet
Lastmod by
oldelvet
Rating
(0)
Description

I have noticed that the forum watch notification "eye" icons on the tiki-view_forum.php screen are both set if either of the two forum watch options are set.

Looking at function user_watches in lib/tikilib.php the code tests whether $event is an array. If it is not an array then it does not filter the watches on event.

Adding

$conditions'event' = $event;

to the else part of the array test corrects the problem.

This is confusing my users in 12.x

I think this should be an easy fix. The only concern is whether $event is ever set to anything other than an array or a string.

Easy to solve?
7
Priority
35
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
5515
Created
Wednesday 10 December, 2014 20:47:36 UTC
by oldelvet
LastModif
Wednesday 10 December, 2014 20:47:36 UTC


Show PHP error messages