Loading...
 
Skip to main content

13.x: applying a profile from Profiles Wizard doesn't send the user to the "Step2" indicated in the url (some steps anchors gone?)

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
13.x: applying a profile from Profiles Wizard doesn't send the user to the "Step2" indicated in the url (some steps anchors gone?)
Version
13.x Regression
Category
  • Regression
  • Community projects
Feature
Admin Interface (UI)
Installer (profiles, upgrades and server-related issues)
Wizards - Profiles Wizard
Resolution status
Fixed or Solved
Submitted by
Xavier de Pedro
Lastmod by
Xavier de Pedro
Rating
(0)
Description
13.x: applying a profile from Profiles Wizard doesn't send the user to the "Step2" indicated in the url (some steps anchors gone?)
Solution

gezza, it seems that it was you who introduced this regression in r50507. It seems that when you indent jq code it stops working as expected (or working at all?): the no indentation was in purpose in:

Copy to clipboard
{jq}
if ($("#profile-0").length > 0) {
	$(".quickmode_notes").hide();
	$(window).scrollTop($("a[name=step2]").offset().top);
} else {
	$(".quickmode_notes").show();
}
$("#repository, #categories").change(function(){
	if ($(this).val()) {
		$(".quickmode_notes").hide(400);
	} else {
		$(".quickmode_notes").show(400);
	}
});
									{/jq}


Reverting that jq code to no extra indentation fixed the issue.
The apply button is not styled as the rest, but at least nowadays the user is shown just one single submit button in the screen, and in the right section.

Fix commited in r52344

Workaround

r52083 - adding missing divs to make tables look better. Also removing text Step3 (there is no Step 1 and Step 2 anymore).

Page could use some more rework in a later release, code is messy and things are overexplained,

gezza, the regression issue still remains:
(1) the user is not sent to the right place after clicking to "apply profile" in the profiles wizard.
(2) moreover, default style doesn't highlight the button to apply the profile

Importance
3
Easy to solve?
8
Priority
24
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
5309
Created
Thursday 10 July, 2014 19:30:49 UTC
by Xavier de Pedro
LastModif
Friday 15 August, 2014 09:32:12 UTC


Show PHP error messages