tiki-pagehistory.php URLS are long & ugly (but we need diff urls working)
- Status
- Closed
- Subject
- tiki-pagehistory.php URLS are long & ugly (but we need diff urls working)
- Version
- 14.x
14.x Regression
15.x
15.x Regression - Category
- Feature request
- Feature
- History (wiki, tracker item, sheet...)
Search Engine Friendly URLs (SEFURLs)
Wiki (page view, edit, history, rename, etc) - Resolution status
- Fixed or Solved
- Submitted by
- Marc Laporte
- Volunteered to solve
- manivannans
- Lastmod by
- Xavi (as xavidp - admin), Marc Laporte
- Rating
- Description
Here is a URL:
http://suite.tiki.org/tiki-pagehistory.php?page=Tiki+Suite+SlideshowSay I want to check the history and share a URL, I click "history" and then "compare", I get:
http://suite.tiki.org/tiki-pagehistory.php?page=Tiki+Suite+Slideshow&history_offset=1&diff_style=sidediff&diff_style=sidediff&show_all_versions=y&compare=Compare&newver=0&oldver=125&tra_lang=sq&paginate=on&history_pagesize=200This is long and has things which are not useful to share the link.
So let's look at the params:
page=Tiki+Suite+Slideshow Needed history_offset=1 Not needed diff_style=sidediff Needed only if different than the default diff diff_style=sidediff this is there twice show_all_versions=y Not needed compare=Compare Why do we need this? newver=0 Needed. 0 seems to be for latest. So if ommitted, it should oldver=125 Needed tra_lang=sq Not needed paginate=on Not needed history_pagesize=200 Not needed
So diff_style=sidediff is there twiceI would want the simple one to be like this:
Compare version 120 to current:
http://suite.tiki.org/tiki-pagehistory.php?page=Tiki+Suite+Slideshow&oldver=120Compare any two versions:
http://suite.tiki.org/tiki-pagehistory.php?page=Tiki+Suite+Slideshow&newver=124&oldver=120And if diff style is different from site default:
http://suite.tiki.org/tiki-pagehistory.php?page=Tiki+Suite+Slideshow&newver=124&oldver=120&diff_style=unidiffThanks!
- Solution
Unwanted parameters are removed from tiki-pagehistory.php URL.
Please check this commit id: 49450
Regressions introduced. See comments to this item, please, and revert or fix properly. Thanks!
- Importance
- 2
- Easy to solve?
- 4
- Priority
- 8
- Demonstrate Bug on Tiki 19+
-
This bug has been demonstrated on show2.tiki.org
Please demonstrate your bug on show2.tiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show2.tiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Demonstrate Bug (older Tiki versions)
-
This bug has been demonstrated on show.tikiwiki.org
Please demonstrate your bug on show.tikiwiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show.tikiwiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Ticket ID
- 4943
- Created
- Sunday 17 November, 2013 16:56:06 UTC
by Marc Laporte - LastModif
- Monday 16 January, 2017 19:36:45 UTC