Loading...
 
Skip to main content

colon in definition lists

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
colon in definition lists
Version
10.x
Category
  • Usability
  • Feature request
  • Patch
Feature
Wiki Syntax (text area, parser, external wiki, etc)
Submitted by
dlech
Lastmod by
dlech
Rating
(0)
Description
When you are using definition list plugin, if you want to use a colon in the definition, there is no way to do this that I know of because the colon is used to separate the term from the definition. If you have a second colon on the line, the second colon and everything after it is cut off (not displayed).
Solution

To keeps things constant, I have added a ~colon~ literal. Here is the patch:

patch
Copy to clipboard
diff --git a/lib/core/JisonParser/Wiki/HtmlCharacter.php b/lib/core/JisonParser/Wiki/HtmlCharacter.php
index 54a8f14..b2d2784 100644
--- a/lib/core/JisonParser/Wiki/HtmlCharacter.php
+++ b/lib/core/JisonParser/Wiki/HtmlCharacter.php
@@ -22,6 +22,7 @@ class JisonParser_Wiki_HtmlCharacter
 		'lt'    => array('exp' => '/~lt~/i',    'output' => '<'),
 		'gt'    => array('exp' => '/~gt~/i',    'output' => '>'),
 		'rm'    => array('exp' => '/[{]rm[}]/i','output' => '‏'),
+		':'	=> array('exp' => '/~colon~/',	'output' => ':'),
 		// HTML numeric character entities
 		'num'   => array('exp' => '/~([0-9]+)~/','output' =>'&#$1;'),
 	);
diff --git a/lib/parser/parserlib.php b/lib/parser/parserlib.php
index adc03ef..bf737e9 100644
--- a/lib/parser/parserlib.php
+++ b/lib/parser/parserlib.php
@@ -164,6 +164,7 @@ class ParserLib extends TikiDb_Bridge
 		$data = preg_replace("/ -- /", " — ", $data);
 		$data = preg_replace("/~lt~/i", "<", $data);
 		$data = preg_replace("/~gt~/i", ">", $data);
+		$data = preg_replace("/~colon~/", ":", $data);
 
 		// HTML numeric character entities
 		$data = preg_replace("/~([0-9]+)~/", "&#$1;", $data);
diff --git a/lib/test/core/JisonParser/OutputTest.php b/lib/test/core/JisonParser/OutputTest.php
index cdcb4ab..9460b5d 100644
--- a/lib/test/core/JisonParser/OutputTest.php
+++ b/lib/test/core/JisonParser/OutputTest.php
@@ -125,6 +125,7 @@ class JisonParser_OutputTest extends JisonParser_Abstract
 			'dash2'             => array(' -- ', ' — '),
 			'lt'                => array('~lt~', '<'),
 			'gt'                => array('~gt~', '>'),
+			'colon'             => array('~colon~', ':'),
 			//$content = preg_replace("/~([0-9]+)~/", "&#$1;", $content);
 
 			//block level syntax
diff --git a/templates/tiki-edit_help.tpl b/templates/tiki-edit_help.tpl
index 806309f..99b767e 100644
--- a/templates/tiki-edit_help.tpl
+++ b/templates/tiki-edit_help.tpl
@@ -96,6 +96,7 @@
 {literal}~rsq~{/literal} ’,
 {literal}~--~{/literal} —,
 {literal}~bs~{/literal} \,
+{literal}~colon~{/literal} :,
 {tr}numeric between ~ for HTML numeric characters entity{/tr}</td></tr>
 </table>
Importance
3
Easy to solve?
10 easy
Priority
30
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
4394
Created
Monday 11 March, 2013 02:09:07 UTC
by dlech
LastModif
Monday 11 March, 2013 02:11:28 UTC


Show PHP error messages