Permission on Newsletters using Group Permissions

• Error
• Feature request
• Patch

Hi,

as written to the dev list, I had the problem to restrict access to some newsletters but not to all. I found a solution, but I am not sure, if this breaks nothing else. Here is the problem:

I want to set up some newsletters: One with access from anybody (anonymous users can subscribe and view the archive) and some others with access only for special groups of users.

On global permission page I set 'tiki_p_list_newsletters' and 'tiki_p_subscribe_email' for anonymous users (this permissions are not available on the object permission page).

On the object permission page for the single newsletter (accessible through /tiki-admin_newsletters.php and the key icon of every newsletter) I activate 'tiki_p_subscribe_newsletters' and 'tiki_p_view_newsletter' for the group of users with permissions on this newsletter.

With this settings I would expect, that an anonymous user browsing page tiki-newsletters.php would see the list of newsletters, in this case showing only the public newsletter. But in this case there is an error (You are not logged in). As a privileged user (allowed to see all newsletters) the page is accessible but empty, not showing any newsletter.

1. Newsletter Patch

The problem, not seeing any newsletter on tiki-newsletters.php is solvedby setting 'tiki_p_subscribe_newsletters' on global permissions for anybody. But I get a still the problem to put restrictions on the archives.

I was thinking, that setting "tiki_p_view_newsletter" to get access to the archives is the key. I set this permission on the object permissions only. But this is not working. Accessing 'tiki-newsletter_archives.php" is impossible for anonymous users, regardless of parameter nlId set to
the correct newsletter or not. Access is granted only, if permission 'tiki_p_view_newsletter' is set as global permission. But then there are no restrictions possible.

I found a solution by patching some code. I am not sure, that the solution I found has n side effects on other parts, so I put it here for discussion.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org

This bug has been demonstrated on show.tikiwiki.org

Please demonstrate your bug on show.tikiwiki.org