Loading...
 
Skip to main content

Image "Upload New Version" does not update the various references to it

  • Tracker item actions
Trackers
Items
Status
Pending
Subject
Image "Upload New Version" does not update the various references to it
Version
7.x
Category
  • Conflict of two features (each works well independently)
  • Consistency
  • Less than 30-minutes fix
Feature
File Gallery (elFinder or standard UI)
Resolution status
Please retest
Submitted by
alain_desilets
Lastmod by
Philippe Cloutier
Rating
(0)
Description

I TRIED TO SUBMIT THIS BUG BUT I CAN'T FIND IT AFTER SUBMIT. SO I AM TRYING TO RESUBMIT IT AGAIN. SORRY IF IT CAUSES A DUPLICATE.

I upload an image to the File Gallery, which gets assigned id=19.

Then I go to a page and insert the following Tiki markup:

[tiki-download_file.php?fileId=19]

{img fileId="19"}


To (a) provide a link to download the image, and (b) insert the image inside the page.

Works up to here.

But then, I do:

  • File Galleries > List Galleries > Browse Images
  • I locate the image I just uploaded, and click on the the wrench icon, and then on "Upload New Version".
  • I upload a new version of the image
  • If I go back to File Galleries > List Galleries > Browse Images, I see that indeed, the old image has disappeared, and it has been replaced by the new version


The problem however, is that the new image has id=20, not the old id=19. But the id has not been changed on the link and IMG plugin that I inserted on the page. So they still point to the old image with id=19.

The weird thing is that I can still download image id=19 (even after clearing my cache), eventhough I can't see that image in the gallery anymore. In other words, the image is still in the DB and can still be accessed.

This is definitely not how things should work. If I upload a new version of an image, then all references to that image should be updated accordingly, and I should not be able to access the old version, except in a "view history" kind of context. No?

Solution

It appears that this is not a bug per se, but rather a bad choice of default for a preference.

Indeed, if you set the following preference:

  • Admin Home > File Galleries > General Settings > Keep the same fileId for the latest version of a file

Then TikiWiki behaves as I (and I suspect most users) expect. When you upload a new version of the file, it keeps the old fileID, and replace the file's content with the new version. All references to the file or image therefore point to the new content.

Unfortunately, this option is not active by default, eventhough in my opinion, it corresponds to what 99% of users would want.

The solution is simple: just make that option be set to on by default.

Marc Laporte pointed out also that there is another option that allows you to keep prior versions of the file in some form of history. This option is supposedly off by default. I couldn't find it, but if it exists, then it should probably be set to "on" by default (unless we are concerned about increasing the size of the DB because of keeping many versions of large binary objects).

Could this be working in recent Tiki versions? Please retest.

Importance
7
Easy to solve?
8
Priority
56
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
4076
Created
Thursday 08 December, 2011 15:00:10 UTC
by alain_desilets
LastModif
Tuesday 28 May, 2019 20:39:00 UTC


Show PHP error messages