Loading...
 
Skip to main content

Tiki Forum email reply links incorrectly populate the post/reply input box

Status
Closed
Subject
Tiki Forum email reply links incorrectly populate the post/reply input box
Version
3.x
6.x
7.x
Category
  • Error
Feature
Forum
Resolution status
Fixed or Solved
Submitted by
jhamell
Lastmod by
Ushindi Gedeon
Rating
(0)
Description

Setup: Running 6.4, on Debian. Recently upgraded from 3.x, bug was present in previous version too.

1. In our TikiWiki forums, all discussion is emailed to an external address
2. At the footer of each email message, the Tiki appends a "Reply Link".
3. When a user receives the notification email, and follows the link, the Forum's "Reply to the selected post" fields are incorrectly populated. The "Title" field is for an enitrely different forum + thread, and the reply box contents are also not correct.

Subjectively (not exhaustively tested), this appears to only happen for posts after the first within a thread, e.g. the reply link for the original post functions correctly, but reply link for all following posts does not.

The 'correct' top post reply links are in the form:
<host>/tiki/tiki-view_forum_thread.php?forumId=14&comments_parentId=2994#form
While the 'incorrect' reply posts are:
<host>/tiki/tiki-view_forum_thread.php?forumId=14&comments_reply_threadId=14&comments_parentId=2994&post_reply=1#form

I suspect reply_threadId may be improperly populated with the forumId.

Thanks in advance.

Solution

It looked like the code for 7.2 (STABLE) was also affected.

For 6.4, in tiki/lib/comments/commentslib.php, line 2615, I modified the call into sendForumEmailNotification. The second argument is fixed as $params'forumId', but I believe that is only accurate when notifying of a new topic. To cover subsequent posts, I modified the second argument to
empty($params'comments_reply_threadId')? $params'forumId' : $threadId

Workaround
Importance
5
Priority
25
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
4032
Created
Monday 07 November, 2011 23:26:13 UTC
by jhamell
LastModif
Friday 03 July, 2026 10:05:29 UTC


Show PHP error messages