Allow redirect plugin to use fragment identifiers (section/anchor ids) (patch included)

• Feature request
• Patch

This patch provides a new parameter called "section" which can be set to the anchor id (not including the "#"). I decided to add this new parameter instead of better parsing of the "page" parameter to be consistent with the fragment syntax for internal links ( ((Foo|#bar)) - note how it's not ((Foo#bar)))

--- wikiplugin_redirect.php.old	2009-04-29 07:02:08.000000000 -0500
+++ wikiplugin_redirect.php	2009-05-20 12:22:21.028250000 -0500
@@ -6,7 +6,7 @@
 // @author damian aka damosoft 30 March 2004
 
 function wikiplugin_redirect_help() {
-        return tra("Redirects you to another wiki page").":<br />{REDIRECT(page=pagename [,url=http://foobar])/}";
+	return tra("Redirects you to another wiki page").":<br />{REDIRECT(page=pagename [,section=section_id] [,url=http://foobar])/}";
 }
 
 function wikiplugin_redirect_info() {
@@ -22,6 +22,11 @@
 				'name' => tra('Page Name'),
 				'description' => tra('Wiki page name to redirect to.'),
 			),
+            'section' => array(
+                'required' => false,
+                'name' => tra('Section/anchor id'),
+                'description' => tra('Id of section/anchor within wiki page to redirect to (see id attribute of <a> elements in HTML source of wiki page).'),
+            ),
 			'url' => array(
 				'required' => false,
 				'name' => tra('url'),
@@ -43,11 +48,15 @@
 	} else {
 		/* SEO: Redirect with HTTP status 301 - Moved Permanently than default 302 - Found */
 		if (isset($page)) {
-			header("Location: tiki-index.php?page=$page&redirectpage=".$_REQUEST['page'], true, 301);
+			if (isset($section))
+				$section = '#'.$section;
+			else
+				$section = '';
+			header('Location: tiki-index.php?page='.urlencode($page).'&redirectpage='.$_REQUEST['page'].$section, true, 301);
 			exit;
 		}
 		if (isset($url)) {
-			header("Location: $url");
+			header("Location: $url", true, 301);
 			exit;
 		}
 	}

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org

This bug has been demonstrated on show.tikiwiki.org

Please demonstrate your bug on show.tikiwiki.org