Loading...
 
Skip to main content

wiki tag "file" rendering issue

  • Tracker item actions
Trackers
Items
Status
Pending
Subject
wiki tag "file" rendering issue
Version
2.x
Category
  • Error
Feature
Wiki Syntax (text area, parser, external wiki, etc)
Resolution status
New
Submitted by
poorman
Lastmod by
poorman
Rating
(0)
Description

Following code inserted into wiki page is causing problems.

No such attachment on this page

In TikiWiki 1.9 was name of file shown with link to file. In TikiWiki 2.x only single closing bracket (i.e. '}') is shown instead.

Following wiki code gives expected result in both 1.9 and 2.x versions (please note space before closing bracket)

No such attachment on this page

File tag is parsed in file lib/tikilib.php in function parse_data(). Tag file is translated to call of ATTACH wiki plugin. It seems that essential is call of split_tag() method with cleanup parameter set to FALSE (in tikilib.php revision 1.801.2.92 it's line 5474). In branch 1.9 was cleanup hardcoded to TRUE in split_tag() body. Setting cleanup to TRUE 2.x gives expected result.

I can see that optional cleanup parameter of split_tag() method was introduced in tikilib.php revision 1.602. At the same revision was cleanup value in file tag parsing section set to FALSE. Commit comment says "Minor tweak to preserve ' in links.". I don't know idea behind it so I'm not able to correctly fix file tag rendering issue. Simple change of cleanup parameter to TRUE would probably cause regression of another bug.

Importance
3
Priority
15
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
1951
Created
Wednesday 13 August, 2008 09:49:31 UTC
by Unknown
LastModif
Wednesday 13 August, 2008 09:49:31 UTC


Show PHP error messages