Category: Comment

At https://dev.tiki.org/item8242-Comments-I-replied-to-a-comment-and-tiki-showed-another-user-as-the-author I create a ticket for a bug but after it happens to me again I'm trying to re-think and re-evaluate. Obviously, I'm doing something wrong (sorry) and I revisited the user interface to understand why I could have been confused.

I'm more and more working on mobile screen also so placement and size with touch screen can be more tricky than with a desktop sized screen.

{img fileId="1878" thumb="box"}

{img fileId="1877" thumb="box"}

I suggest:

* The danger colour shouldn't be the same as secondary
* The destructive actions should be separated from the others (same line start - end ?)
** Reply and Post a new comment together (not the same color)
** Edit, Delete (or cancel) together
* Edit, Delete (or cancel), the editing actions may be small buttons to emphasis the difference between editing actions vs adding content

---

With the above in mind, this also can be improved.

{img fileId="1879" thumb="box"}

10 possible actions:
* 2 primary - Scarlet (light red)
* 7 secondary - Bordeaux (dark red)
* 1... Danger (very light soft-pink) ? ?

In my mind would should have distinction between
* Adding content often used tools (Edit)
* Adding content secondary tools (Comments, Files)
* Collaborative / User tools (comments)
* Editing tools (Rename, History, Source)
* Helpers/Admins tools (Translation, Permission, Remove)

''Translation can be seen as an adding content tool or editing tool (not 100% sure about this one, I would say that the dropdown is fine as we have it usually somewhere else)''

Distinction can be Made with colors, position (start - end) size (btn - btn-sm), design (outlined) and semi-hidden (dropdown)
https://doc.tiki.org/Documentation is different and offer a 4th (or 5th) color which help a bit.

{img fileId="1880" thumb="box"}

Hello,

I replied to a comment using this link : https://dev.tiki.org/item8238-Wiki-page-Markdown-Carriage-return-are-not-displayed#mentioned-Bsfez-section-1

After saving the comment the author is Jonny instead of me.

{img fileId="1860" thumb="box"}

Some things I remember about it;
* The page open all the day (I visited in the morning and the event occurred in the afternoon)
* I received a notification in my mail that my username was mentioned in a comment
* I refreshed the page to see the comment __OR__ I clicked the link from the notification https://dev.tiki.org/item8238-Wiki-page-Markdown-Carriage-return-are-not-displayed#mentioned-Bsfez-section-1
* I typed my reply and saved

For wiki pages, we have this option. It would be nice to port to comments so we could open our blogs to anonymous comments without getting spammed.

In comments (on wiki pages for example), there is a bar:

Style: Sort: Threshold: Search:


This seems like clutter when there are only a few comments.


Suggestion:
Only have this bar if number of comments is high enough that a comment pagination is needed (ex.: 10)


Related:
{wish id=937}

comzone, the cookie that save the show/hide of comments on tikiWiki pages, isn't being updated properly. Once comments are shown they remain shown.

To reproduce the issue, follow the following instructions:
- activate comments for you TikiWiki page, through your admin controls
- Open a new session of your web browser. I'll assume you're using Firefox from now on
- Navigate to one of you wiki pages
- Scroll down to the bottom of your wiki page
~ Notice how the 'Post New Comments' comments section is hidden
- Click the link to add comments and make the 'Post New Comments' visible
- In Firefox, select Tools-> Options. Go to the privacy section and click on Show Cookies. Search for your site or site subdomain (type the first letter of the domain or subdomain to jump to that letter) where your tikiWiki is. Expand the folder and search for comzone. Notice that comzone is set to 'o'. Close out the cookies and option window.
- Browse to another page on your tikiWiki site and scroll down to the bottom of the page
- Notice that the 'Post New Comments' section is still visible
- Click on the add comment link to collapse the comments section.
~ At this point the comzone cookie should have changed.
- Check on the content of comzone and see if it is something other than 'o'. You will find that it doesn't change.
- Delete the comzone cookie and refresh the wikipage and you'll see that comments get hidden.

The problem occurs when strings like..

img src="img/icons/world_edit.png" alt="Edit" width="16" height="16" title="Toggle interactive translation on" class="icon"

... are added as a comment.

Please check the comments of this case for an example of the bug

I edited a comment on a ticket from dev tracker 5 and on save (the area seems to reload or to be updated) nothing was changed.
It take a few refresh (if not unlucky like in the video ?) to properly update the comment for the contributor user.

{file type="gallery" fileId="1946" showicon="y"}

(after a few minutes I could load the page)
{img fileId="1947" thumb="box"}

I experienced this here : https://dev.tiki.org/item8179-Button-colors-can-t-be-changed

I replied to a comment here : https://dev.tiki.org/tiki-view_tracker_item.php?itemId=8071&threadId=10284&cookietab=1#threadId10286

I inserted two user tags and the display is wrong...

{CODE()}@john.chishugi{CODE}
Only john is a link and it is broken

{CODE()}@chibaguy{CODE}
Display the user full "real" name

{img fileId="1763" thumb="box"}

{img fileId="934"}

See this page:
http://dev.tiki.org/tiki-view_tracker_item.php?itemId=5386&threadId=3936&cookietab=2#threadId3936

{syntax type="tiki" editor="plain"}
I replied to a comment in the page WikiPedia. At that moment, there were already two comments. When I published my comment, the two other comments disappeared. The page still says there are three comments, but My browser can only see either zero or one (mine)

Folks would probably use external wiki abbreviations more if they and their full equivalents were displayed on the editing screen. Even better if there were an explanation of what they are for, how to use them. Maybe a tooltip?

for users with tiki_p_wiki_view_comments perm only, it displays the ~np~[comment]~/np~ link on the wiki page bar even when no comments there yet to read, so clicking it does literally nothing...

When editing a comment assigned to a trackeritem, the comment doe not update after save.
This happens only when codemirror is used.
When toogle "Highlighter" two times before hitting save, then the updated comment will be saved.
The reason seems to be that upon save, the updated comment is not read from the codemirror data structure, but from the initially loaded content saved in the textarea.

I was able to debug to the point where the POST request happens. That is tiki-jquery.js arround line 1740. There the wrong value is taken. Mabye also autosave.js is involved as well.

There is an empty comment from Adrien at https://dev.tiki.org/tiki-view_tracker_item.php?itemId=7935&threadId=9839
It is displayed as "" in the plugin Since last visit...

{img fileId="1642" thumb="box"}
{img fileId="1643" thumb="box"}

This improvement in Tiki would be very welcome. After spammers add noise to your site (in one day, 10 comments to different places in your tiki from 10 different ip's!), it would be nice if there was the chance that the tiki admin can ban all those 10 ip's with a minimum number of clicks (besides removing many spam comments at once, which can be done already).

This is some possible way to add if (from the interface point of view):

{img src=img122}

Self explicative?
User selects multiple checkboxes, and clicks on some button below which sends all that information (those ip's from those comments) to fill admin banning data (storing the data already for the 10 ip's at once).
Alternatively, one by one, prefilling the interface one by one.

{img src=img123}

tiki-list_comments.php shows up blank even though I have comments. This only happens in 1.10 when I set my feature preferences to 1.10 feature styles instead of 1.9 feature styles. Do I need to run an db update if I switch? PHP errors shows:

PHP (5.2.3) ERROR (E_WARNING):
File: tiki-list_comments.php
Line: 51
Type: in_array() [function.in-array]: Wrong datatype for second argument

The entire PHP error list is:
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 20
Type: Undefined variable: feature_wiki_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 22
Type: Undefined variable: feature_article_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 24
Type: Undefined variable: feature_blog_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 24
Type: Undefined variable: feature_blogposts_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 26
Type: Undefined variable: feature_file_galleries_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 28
Type: Undefined variable: feature_image_galleries_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 30
Type: Undefined variable: feature_poll_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 32
Type: Undefined variable: feature_faq_comments
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 50
Type: Undefined index: types
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 51
Type: Undefined index: types
PHP (5.2.3) ERROR (E_WARNING):
File: tiki-list_comments.php
Line: 51
Type: in_array() [function.in-array]: Wrong datatype for second argument
PHP (5.2.3) NOTICE (8):
File: tiki-list_comments.php
Line: 98
Type: Undefined index: types
PHP (5.2.3) NOTICE (8):
File: en^%%08^089^089CC76C%%tiki-list_comments.tpl.php
Line: 84
Type: Undefined index: string_types
PHP (5.2.3) NOTICE (8):
File: en^%%08^089^089CC76C%%tiki-list_comments.tpl.php
Line: 87
Type: Undefined index: string_types
PHP (5.2.3) NOTICE (8):
File: en^%%08^089^089CC76C%%tiki-list_comments.tpl.php
Line: 90
Type: Undefined index: string_types
PHP (5.2.3) NOTICE (8):
File: en^%%08^089^089CC76C%%tiki-list_comments.tpl.php
Line: 93
Type: Undefined index: string_types
PHP (5.2.3) NOTICE (8):
File: en^%%08^089^089CC76C%%tiki-list_comments.tpl.php
Line: 96
Type: Undefined index: string_types
PHP (5.2.3) NOTICE (8):
File: en^%%08^089^089CC76C%%tiki-list_comments.tpl.php
Line: 99
Type: Undefined index: string_types
PHP (5.2.3) NOTICE (8):
File: en^%%08^089^089CC76C%%tiki-list_comments.tpl.php
Line: 170
Type: Use of undefined constant cant_pages - assumed 'cant_pages'
PHP (5.2.3) NOTICE (8):
File: en^%%4B^4B8^4B839B3D%%user_module.tpl.php
Line: 7
Type: Undefined index: modules_params
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%9E^9E2^9E21ED1B%%mod-login_box.tpl.php
Line: 6
Type: Undefined index: do_not_show_login_box
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%18^188^18826D51%%mod-change_category.tpl.php
Line: 6
Type: Undefined index: page
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%4B^4B8^4B839B3D%%user_module.tpl.php
Line: 7
Type: Undefined index: modules_params
PHP (5.2.3) NOTICE (8):
File: en^%%F8^F87^F8728316%%module.tpl.php
Line: 80
Type: Undefined index: module_error
PHP (5.2.3) NOTICE (8):
File: en^%%F7^F7F^F7F34188%%header.tpl.php
Line: 11
Type: Undefined index: language
PHP (5.2.3) NOTICE (8):
File: en^%%F7^F7F^F7F34188%%header.tpl.php
Line: 12
Type: Undefined index: language
PHP (5.2.3) NOTICE (8):
File: en^%%F7^F7F^F7F34188%%header.tpl.php
Line: 142
Type: Undefined index: mootools_windoo
PHP (5.2.3) NOTICE (8):
File: en^%%F7^F7F^F7F34188%%header.tpl.php
Line: 145
Type: Undefined index: mootab
PHP (5.2.3) NOTICE (8):
File: en^%%F7^F7F^F7F34188%%header.tpl.php
Line: 175
Type: Undefined index: msgError
PHP (5.2.3) NOTICE (8):
File: en^%%F7^F7F^F7F34188%%header.tpl.php
Line: 176
Type: Undefined index: section
PHP (5.2.3) NOTICE (8):
File: en^%%86^863^863C42B0%%tiki-ajax_header.tpl.php
Line: 6
Type: Undefined index: xajax_js
PHP (5.2.3) NOTICE (8):
File: en^%%97^977^977F80C8%%tiki-top_bar.tpl.php
Line: 10
Type: Undefined index: feature_calendar
PHP (5.2.3) NOTICE (8):
File: en^%%97^977^977F80C8%%tiki-top_bar.tpl.php
Line: 17
Type: Undefined index: feature_debug_console
PHP (5.2.3) NOTICE (8):
File: en^%%97^977^977F80C8%%tiki-top_bar.tpl.php
Line: 20
Type: Undefined index: feature_phplayers
PHP (5.2.3) NOTICE (8):
File: en^%%8C^8CD^8CD0DF4C%%tiki-bot_bar.tpl.php
Line: 99
Type: Undefined index: feature_babelfish
PHP (5.2.3) NOTICE (8):
File: en^%%8C^8CD^8CD0DF4C%%tiki-bot_bar.tpl.php
Line: 99
Type: Undefined index: feature_babelfish_logo
Tiki Debugger Console [x]
Current URL: /tiki/tiki-list_comments.php
Command:
Type help to get list of available commands

Just got an error in debugging console of IE10 when posting comment here:
{CODE()}
//Synchronize textarea and codemirror before comment is posted
$(".comment-form>form").submit(function(event){
var $textarea = event.target.find("textarea.wikiedit"); //retrieve the text area from the form that is submitted
if (typeof syntaxHighlighter.sync === 'function') {
syntaxHighlighter.sync($textarea);
}
});
{CODE}
It said something like -+"find method is not available here"+- (sorry it was in Czech and not copypasted with the code snipped here).

luci

Feature to discuss wiki pages in forums sends a notification email (user watches) each time the use clicks at the button 'Start discussion' (even if the discussion and thread was already started by someone else previously)

Reproduced:

http://xavi-9794-6188.show.tikiwiki.org/tiki-index.php?page=HomePage
u: admin
p: 12345

u: user1
p: user1

Mail sending is logged in the syslogs
Login as user1 and click at access discussion of the homepage (link above bottom bar). Registered users (through group watches) will receive an email as if you started the thread. But thread was started already, and you didn't post anything else to trigger a new email sent.

Tiki 1.9.x forums have improved nicely over the last few months. One more thing to make them cleaner is to make the default threading to plain.

Let's face it, it looks cleaner :-)


{img src=images/code.png}%%% {CODE()}
===================================================================
RCS file: /cvsroot/tikiwiki/tiki/comments.php,v
retrieving revision 1.31.2.50
diff -c -r1.31.2.50 comments.php
*** comments.php 11 May 2007 23:15:50 -0000 1.31.2.50
--- comments.php 31 May 2007 04:01:10 -0000
***************
*** 386,392 ****

if (!isset($_REQUEST["comments_style"])) {
// TODO: Make this an option.
! $_REQUEST["comments_style"] = 'commentStyle_threaded';
} else {
$smarty->assign('comments_style_param', '&comments_style='.$_REQUEST['comments_style']);
$comments_show = 'y';
--- 386,392 ----

if (!isset($_REQUEST["comments_style"])) {
// TODO: Make this an option.
! $_REQUEST["comments_style"] = 'commentStyle_plain';
} else {
$smarty->assign('comments_style_param', '&comments_style='.$_REQUEST['comments_style']);
$comments_show = 'y';

{CODE}

In forums:

Topics are first level (discussion starters)
Message are replies. This uses the same code as comments (used in wiki pages, image gallery, etc) and has threading.

In 1.9.x, an admin can move a reply to another topic. This is of limited use. It is as if the admin decides "Your answer is more suited to another question"...

What would be much more useful:
To change a topic (and all threaded replies) to another forum.

So an admin could start with one general forum, and create more specific forums if/when the volume of messages justifies it. Right now, the admin has to plan all these forums in advance. And a list of empty forums is not very inviting...

If someone starts a thread in the wrong forum, it should be easy to correct.

{syntax type="tiki" editor="plain"}
Try it here:
http://tikiwiki.org/Hosting+company

Related:
{wish id=2554}

If you take a close look at a long bug report like my "umbrella bug report", you'll see that it bears so many comments, their display gets paginated. That's a good idea. But one would expect that the first comment on page "2" is one following the last on page "1".

But that isn't the case... The last on page 1 is dated August 31st, the first on page 2 is from August 22, 2020...

And yes, I did reload the page to be sure that I do not see old data...

Thanks
hman

Please see image

Nowadays the voting on forums is confusing in educational or e-democracy scenarios, since it's not easy to understand why a voting of ! makes just 0.40, or a voting of 5 make 1.60, etc. as it may happen nowadays, since voting on forums seems to be linked to karma or score system.

There should be an option to unlink them, so taht a vote of 1, makes 1, and an option of 5 makes 5 to be included in the mean which is shown at the end on the rate value.

If a valid wikilink is included within a comment on a wiki page, that link is reported by BACKLINKS on the page being linked to.

{CODE(caption="Test_MRB_01")}This page uses the BACKLINKS plugin to show pages with links to it -
{BACKLINKS()}{BACKLINKS}{CODE}

{CODE(caption="Test_MRB_02")}This page has three source lines, the second of which is a comment.
~tc~((Test_MRB_01|This link to Test MRB 01 is in a comment))~/tc~
This is the third line, but only two lines visible when viewed.{CODE}