Category: Less than 30-minutes fix

{syntax type="tiki" editor="plain"}
Tracker plugin:
Imagine we would like to offer modification of a dynamic list field without offering modification of its reference field. In this case, the dynamic list should fall-back to a simple list with no selectValue calls in the js.

This setting:
User Messages
here: tiki-admin.php?page=features

And these ones:
Users can opt-out internal messages:
Users accept internal messages by default:
Maximum mailbox size (messages, 0=unlimited):
Maximum mail archive size (messages, 0=unlimited):
Maximum sent box size (messages, 0=unlimited):
here: tiki-admin.php?page=login

Should be added to a new admin tab "Inter-user message":
tiki-admin.php?page=inter-user_message

IMHO, it is OK for options/settings to be in more than one admin panel, if relevant to both.

The toolbar editor calls for an icon for the smiley tool that does not exist (/img/smiles/icon_smile.png). This results in the text "smile" being displayed instead of the proper icon.

However, a /img/smiles/icon_smile.gif exists (GIF instead of PNG).

I did not find a particular PHP or .tpl that calls this icon as a PNG, so I suspect the entirety of tool icons are called by name and added extension .png. So instead of searching for the bug in the source code, and coding an exception just for the smiley icon, it would be much easier to simply create a copy of /img/smiles/icon_smile.gif in PNG format in /img/smiles directory to rectify this...

Using strasa.css in demo.t.o/11.x (reproduced else where also)

Log in as admin
Edit a wiki page,
click at a tool in the toolbar (help icon clicked in the screenshot below)
popup box is shown under the text area, no button are shown, most controls are hidden, etc.

See screenshot

{img fileId="288" thumb="y" rel="box[g]"}

{syntax type="tiki" editor="plain"}
Editing a calendar item via
tiki-calendar_edit_item.php
resets its hours and minutes to strange values.

This is my first bug report here, I could not find the issue somewhere and believe some experienced developer should review my fix.

{syntax type="tiki" editor="plain"}
I have a problem, i dont know how fix it
In tiki4.2 in wiki pages (others doesn’t show this error) editor wysiwyg, does insert an image but it change the code with this code
{…}, (I know cos I saw it , in the html view)
But when I save it doesn’t recognize the image, If I return to the html editor and change the {…} With <…>, it works

Somebody can help me??
(:wink:)

If you are in a site with some "documentation" activity (a bunch of images already in the default folder), it's not easy for the end user to insert the image he/she has just uploaded to Tiki thorugh the toolbar icons/actions.

With the former file gallery interface to upload a file, you see the thumbnail or icon of the image/file just uploaded, so that it's very easy to find it and click on it to get the corresponding wiki syntax inserted in the text area, so that the file is used within the text.

With elFinder, this simple task becomes difficult, annoying, and time consuming (plus irritating at some times, if you can't seem to find the image you have just uploaded and you KNOW it's there somewhere).

Usual case (can be easily reproduced in doc.t.o):
# Log in doc.t.o
# Edit a documentation page
# Click at the toolbar icon to insert a new image from your local harddisk. elFinder interface is shown.
# Click at the icon to insert the file from your harddisk. Select your file, upload it.
# Once the file has finished uploading, you have no clue where the image is, and it's way more complicated to have your image inserted for you in your wiki page or text area.
** You have to start scrolling and scrolling there in the elFinder window to look for something... I know my image was called (real example from today) "tiki13_tracker_events_00.png".
** I typed "tiki13_tracker_events" in the search box, and nothing was shown (!).
** I typed "tiki13_tracker" in the search box, and nothing was shown (!).
** I typed "tiki13" in the search box, and dozens of images where shown (!!!).

At this time, my annoyance started to increase quite a lot, as you can image...

We need to make the lifer easier for the end user (and for the *.t.o Tiki contributor)

^ Expected behavior with elFinder:
* Once the file has finished uploading, we expected to have elfinder automagically search for that file name ("tiki13_tracker_events_00.png"), and display the end user JUST the icon/thumbnail of that file just uploaded, so that this human being can easily click on it to have it inserted.
^

Thanks for improving this lovely elFinder interface! :-) {sign user="xavi" datetime="2015-01-26T10:13:55+00:00"}

If you write a wiki article for example and want to insert a image or picture you already uploaded you use the button for picture.
Then you select file galleries as the data source and want to select a file directly within the file gallery.
That's not the real problem. But as soon as you use elFinder for file gallery view you still can select a image but it will always insert a whole code tag within the "image id" field (eg. {img fileid="34" ...}) and not only the fileid itself.

The fix is really easy, you just need to edit the file [yourtikihome]/templates/tiki-list_file_gallery.tpl at line 294 and replace this line with the following:
{CODE(caption="templates/tiki-list_file_gallery.tpl")}window.opener.insertAt('{{$filegals_manager}}', data.fileId);{CODE}

Maybe you should fix this in a following version, as it's really annoying to fix the form every time.

-------

the patch doesn't seem to work. still having the issue of the full plugin code gets injected.

This is probably a Jonny bug now since it touches ElFinder

There is (presumably) an error in the help system, which I found while editing the help of Spreadsheet, but I guess this help text, since it describes basic Tiki syntax, gets displayed on numerous occasions.

tiki-edit_help.tpl has this on line 55:

{CODE(Colors="Tiki")}
<td>
<strong>{tr}Show/Hide{/tr}</strong> <br/> !+, !!- {tr}show/hide heading section. + (shown) or - (hidden) by default{/tr}.
</td>
{CODE}

I assume both options are to be written with double exclamation marks, and not only the negative?

The template for the community wizard has an error, it points users the wrong direction to look at:
{CODE(Colors="Tiki")}
<em>{tr}See also{/tr} {tr}Share{/tr} <a href="tiki-admin.php?page=share" target="_blank">{tr}admin panel{/tr}</a> &amp; <a href="https://doc.tiki.org/Share" target="_blank">{tr}in doc.tiki.org{/tr}</a></em>.
</div>
<div class="col-lg-6">
{preference name=feature_friends}
<div class="adminoptionboxchild" id="feature_friends_childcontainer">
{preference name=social_network_type}
</div>
<br>
<em>{tr}See also{/tr} "{tr}Community{/tr} <a href="tiki-admin.php?page=community&cookietab=2" target="_blank">{tr}admin panel{/tr}</a> > {tr}Social Network{/tr} > {tr}Friendship and Followers{/tr}" &amp; <a href="https://doc.tiki.org/Friendship+Network" target="_blank">{tr}in doc.tiki.org{/tr}</a></em>.
{CODE}

The Friendship&Followers settings are not in Control Panels > Social Network > Friendship and Followers, but rather in Control Panels > Community > Tab "Social Interaction".

When i create a new show site which is not in trunk, the file http://jyhem-9952-4675.show.tikiwiki.org/install_log.txt

shows an error
/usr/local/sbin//tim-create: line 87: [[: 11.0: syntax error: invalid arithmetic operator (error token is ".0")

Ok, I can fix that in 2 minutes but I really wanted to experiment with the whole show workflow as a normal user :-)
Let me fix it and close it :)

When trying to Upload Translations using a Custom Translations file I got the following (tested on Mac and Windows).

Error
Invalid file type (expected file type: php)

On this page:

/tiki-view_forum_thread.php?comments_parentId=15&forumId=1

The previous topic link produces this url:

/tiki-view_forum_thread.php?comments_parentId=12&topics_offset=-1

This page is a Error Page.

This page also gets indexed by google and is crawled by bots.

I have added a line to my robots.txt to tell google bots not to include it in there indexing

Disallow: /*topics_offset=-1

Thanks, for considering addressing this. Really appreciate tiki.

Set a tracker to display items with a wiki page template.
Don't create the template so it is missing.

When viewing a tracker items popup this (ugly) error.

{CODE()}Fatal error: Uncaught exception 'SmartyException' with message 'Unable to load template file 'promo_tpl' in 'tracker_pretty_item.tpl'' in /var/www/sites/xxx/xxx/subdomains/www/html/vendor/smarty/smarty/distribution/libs/sysplugins/smarty_internal_templatebase.php on line 127 SmartyException: Unable to load template file 'promo_tpl' in 'tracker_pretty_item.tpl' in /var/www/sites/xxx/xxx/subdomains/www/html/vendor/smarty/smarty/distribution/libs/sysplugins/smarty_internal_templatebase.php on line 127 Call Stack: 0.0020 1106896 1. {main}() /var/www/sites/xxx/xxx/subdomains/www/html/tiki-view_tracker_item.php:0 0.2151 29471160 2. Smarty_Tiki->display() /var/www/sites/xxx/xxx/subdomains/www/html/tiki-view_tracker_item.php:723 0.2151 29471896 3. Smarty_Internal_TemplateBase->display() /var/www/sites/xxx/xxx/subdomains/www/html/lib/init/smarty.php:348 0.2151 29472056 4. Smarty_Tiki->fetch() /var/www/sites/xxx/xxx/subdomains/www/html/vendor/smarty/smarty/distribution/libs/sysplugins/smarty_internal_templatebase.php:374 0.2152 29475872 5. Smarty_Tiki->fetch() /var/www/sites/xxx/xxx/subdomains/www/html/lib/init/smarty.php:229 0.2154 29476112 6. Smarty_Internal_TemplateBase->fetch() /var/www/sites/xxx/xxx/subdomains/www/html/lib/init/smarty.php:254{CODE}

Should display the item with the tracker standard view (no template).
Eventually display a small error to admin only.

Export Spreadsheet as csv with code to produce svg chart includes the svg output tags in the csv cell instead of the tiki syntax to generate the chart

Reproduced when attempting to export sheet4 in doc.t.o, which is part of the sample charts generated from the tiki spreadsheet feature:
https://doc.tiki.org/tiki-export_sheet.php?sheetId=4

When exported (as csv with comma, and utf8) the content is like:
{CODE(colors="htmlmixed")}
Chart Type,Example,Chart,Data,Month,Year
Vertical Bar,"=BARCHART(D2:D13),<div class="jSheetChart"><svg height="172" width="421" version="1.1" xmlns="http://www.w3.org/2000/svg"><desc>Created with Raphaël</desc><defs></defs><path d="M80,139L58,139L58,127L80,127Z" stroke="none" fill="#1751a7"></path><path d="M108,139L86,139L86,1,4,Jan,2001
Horizontal Bar,"=HBARCHART(D2:D13),<div class="jSheetChart"><svg height="148" width="421" version="1.1" xmlns="http://www.w3.org/2000/svg"><desc>Created with Raphaël</desc><defs></defs><path d="M53,27L53,20L95,20L95,27Z" stroke="none" fill="#1751a7"></path><path d="M53,36L53,29L116,29L116,,6,Feb,2002
Pie,"=LINECHART(D2:D8, F2:F6)",<div class="jSheetChart"><svg height="220" width="421" version="1.1" xmlns="http://www.w3.org/2000/svg"><desc>Created with Raphaël</desc><defs></defs><text fill="#000000" stroke="none" font="12px Arial, sans-serif" style="text-anchor: middle; font: 12px A,7.2,Mar,2003
Line,"=PIECHART(D2:D8, E2:E8)",<div class="jSheetChart"><svg height="144" width="421" version="1.1" xmlns="http://www.w3.org/2000/svg"><desc>Created with Raphaël</desc><defs></defs><path stroke-linejoin="round" stroke-width="1" style="stroke-width: 1; stroke-linejoin: round;" d="M210.5,7.5,Apr,2004
,,,8.2,May,2005
,,,9.1,Jun,2006
,,,14.1,Jul,2007
,,,16,Aug,2008
,,,17.9,Sep,2009
,,,22,Oct,2010
,,,30,Nov,2011
,,,32,Dec,2012
,,,,,
,,,,,
{CODE}

And in my honest opinion, it should be something like:
{CODE()}
Chart Type,Example,Chart,Data,Month,Year
Vertical Bar,"=BARCHART(D2:D13)",=BARCHART(D2:D13),4,Jan,2001
Horizontal Bar,"=HBARCHART(D2:D13)",=HBARCHART(D2:D13),6,Feb,2002
Line,"=LINECHART(D2:D8, F2:F6)",=LINECHART(D2:D8, F2:F6),7.2,Mar,2003
Pie,"=PIECHART(D2:D8, E2:E8)",=PIECHART(D2:D8, E2:E8),7.5,Apr,2004
,,,8.2,May,2005
,,,9.1,Jun,2006
,,,14.1,Jul,2007
,,,16,Aug,2008
,,,17.9,Sep,2009
,,,22,Oct,2010
,,,30,Nov,2011
,,,32,Dec,2012
,,,,,
,,,,,
{CODE}

It would be handy to have more internal wiki variables exposed as Wiki Argument Variables.
eg version, description, last author etc

The reason is simple. Reuse instead of repeat.
I for example am setting up tiki to keep and maintain ISO 9001 and HACCP documents and records.
The standards require each file to have version and associative info to it which works fine when viewing online but when printing, all the above have to be re-entered manually and updated on every change on every page.

In tikilib.php, the external link icon is hardcoded:
{CODE(wrap="1",colors="php")} if ($prefs['feature_wiki_ext_icon'] == 'y' && !$options['suppress_icons']) {
$ext_icon = "<img border=\"0\" class=\"externallink\" src=\"img/icons/external_link.gif\" alt=\" (external link)\" />";
}{CODE}

That is not good if you want that icon to be different.
You have to overwrite img/icons/external_link.gif with your own, and remember to re-overwrite it when updated to a new Tiki.

It would be better to either allow the user/admin to give a link to an alternative icon, or even better: put it in CSS, so that it can be overwritten in themes.

A quick fix would be to change line 5806 and line 6245 from this:
{CODE(wrap="1",colors="php")}$ext_icon = "<img border=\"0\" class=\"externallink\" src=\"img/icons/external_link.gif\" alt=\" (external link)\" />";{CODE}
to this:
{CODE(wrap="1",colors="php")}$ext_icon = "<span class=\"externallink\">   </span>";
{CODE}
And then put a CSS class in design.css or other appropriate css file, so that it can be overridden by theme css:
{CODE(wrap="1",colors="css")}.externallink
{
background: url(img/icons/external_link.gif) no-repeat;
}{CODE}

feature alias (semantic links) is not SEF (search engine friendly) ready

Using 4.2.
See it here:
page:
http://gavarrespedia.org/pendent

has a few aliases such as:
{CODE()}
(alias(pendents))
{CODE}

If you have SEF feature off (btw, and htaccess rewrite rules on), when you type:
http://gavarrespedia.org/pendents

you get
http://gavarrespedia.org/pendent

However, if you enable SEF feature (to make tiki create also short urls), then:
http://gavarrespedia.org/pendents

shows error, page not found, maybe you were looking for pendent, etc.
and it should just show the page "pendent" straight away

Feature to discuss wiki pages in forums sends a notification email (user watches) each time the use clicks at the button 'Start discussion' (even if the discussion and thread was already started by someone else previously)

Reproduced:

http://xavi-9794-6188.show.tikiwiki.org/tiki-index.php?page=HomePage
u: admin
p: 12345

u: user1
p: user1

Mail sending is logged in the syslogs
Login as user1 and click at access discussion of the homepage (link above bottom bar). Registered users (through group watches) will receive an email as if you started the thread. But thread was started already, and you didn't post anything else to trigger a new email sent.

No matter if you disable feature_wiki_1like_redirection
it in the "Wiki" part of Administration Page

the engine always tries to show you a page name
similar to the one you asked for.

in plugin trackerlist and plugin trackerfilter (and maybe some others also) the filter fields is really ugly, mainly because the colon ":" is often displayed in a own line, ripping apart the field name and the filter field.

Well, just look at the screenshot, it's obvious.

{img fileId="1605" thumb="box"}

Logged as admin, when you navigate inside the File Galleries you can see the name of the Gallery you are in and close to it a wrench. The wrench tootip let you understand that you will be able to interact with THIS file gallery settings but in reality you are sent to the Admin Control Panel "File Galleries".
https://dev.tiki.org/tiki-admin.php?page=fgal#File%20Galleries

{img fileId="2091" thumb="box"}

This is quite confusing for new Admins.

> As admin, I can't set the permissions on Registered users to: list_file_galleries or create_file_galleries, though other file galleries settings are selected, including view_file_gallery, download_files, upload_files, view_fgal_explorer, and view_fgal_path. I tried to deselect that last 2 since I don't understand what the file gallery explorer is and I don't know that they need to view the path, but I can't seem to deselect and save it successfully.
>
> When I log in as a Registered user and click on File Galleries, I get this Error message: Permission denied you cannot view this section.
>
> I see a link for Upload file, but when I click on it, I get: No gallery available. You have to create a gallery first! Create New Gallery.
>
> When I click on Create New Gallery, it gives me this Error message: Permission denied you cannot view this section.

Withing a file gallery, the "parent gallery" navigation button appears even if that user has no permissions to view the gallery it points to, of course causing an error, and allowing google to index the error.

To reproduce: set global tiki_p_view_file_gallery to allow. Create a child gallery. Set the tiki_p_view_file_gallery for the parent gallery to deny. Navigate to the child gallery. Click the "parent gallery" link. The error appears.

What it should do.

Instead of checking if the user has permissions to view the page they are navigating from, check if the user has permission to view the page they are navigating to. (in this case the parent page.) & do not display the navigation link if here is no permissions to view it.

When you are in file galleries, some file galleries may contain more images than others. If you are on page 2 (or subsequent) of the sub-gallery you are currently browsing, the according page is loaded with parameter offset=25.

From this view, you can directly click another gallery from the tree that is displayed on the left-hand side.

But ALL subgalleries in the tree are linked with parameter offset=25, so when you click one that does not have more than 25 entries, you get the error message (information) that there is nothing to be displayed...

So either change the logic that all subgalleries in the left-hand tree are linked with their root (offset 0) or display the last possible page of that gallery, when it gets clicked. I would prefer the former.

Thanks
hman