Loading...
 
Skip to main content

File Gallery Download dead loop if folder is customized

Status
Open
Subject
File Gallery Download dead loop if folder is customized
Version
11.x
12.x
Category
  • Consistency
Feature
File Gallery (elFinder or standard UI)
Resolution status
Confirmed
Submitted by
jp_eagle
Lastmod by
Marc Laporte
Rating
(0)
Description

I got a problem to see thumbnail and download file from File Gallery.
What I did are:
1. create a customized a folder for file gallery
2. point the file gallery folder destination to the new folder in setting.
3. upload a file
4. try to view the file and download the file, the system goes to endless loop, and no responds from server to client, logs are continuously generated till disk full.
Thu Jan 01 12:56:38 2014 error client 192.168.1.102 PHP Notice: ob_end_clean(): failed to delete buffer zlib output compression. in /apps/tiki/tiki-download_file.php on line 147, referer: http://tiki.mydomain.com/file1
5. after I check the code. in the tiki/tiki-download_file.php, line 146, it has below
while (ob_get_level()) {
ob_end_clean();
}// Be sure output buffering is turned off

6. I googled the coding, looks it should be changed as below.
while (ob_get_level()>1) {
ob_end_clean();
}// Be sure output buffering is turned off

7. I changed, the code, the file viewing and download are perfect. problem is solved.

Could any developer please review the code, if it is the way to go, please merge the change into the main trunk for future releases.

Thanks.

Solution

5. after I check the code. in the tiki/tiki-download_file.php, line 146, it has below
while (ob_get_level()) {
ob_end_clean();
}// Be sure output buffering is turned off

6. I googled the coding, looks it should be changed as below.
while (ob_get_level()>1) {
ob_end_clean();
}// Be sure output buffering is turned off

Importance
9
Easy to solve?
9
Priority
81
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
5120
Created
Thursday 30 January, 2014 05:03:22 UTC
by jp_eagle
LastModif
Thursday 07 August, 2014 23:53:27 UTC


Show PHP error messages