Search updates for 3.0beta1 to show correct menus
- Status
- Closed
- Subject
- Search updates for 3.0beta1 to show correct menus
- Version
- 3.x
- Category
- Patch
- Feature
- Search
- Resolution status
- Out of Date
- Submitted by
- Geoff Brickell
- Lastmod by
- Geoff Brickell
- Rating
- Description
Whilst the various .tpl files associated with search do a check on the $prefs.feature_XXX when showing the drop down menu for refining the search there is no check on whether the individual user has the privilege to use the feature. Therefore menu options can be shown that are not appropriate.
Also the drop down menus are slightly different for the three different .tpls files
No longer relevant - 15th June 2013- Files
- Solution
mod-search_box.tpl
tiki-searchresults.tpl
tiki-searchindex.tplupdated and attached as proposed patch
-----------------
I do not agree with the test about permission as a general solution.
For instance - tiki_p_view can not be set globally, but some pages can have special permissions.
Perhaps we need a global setting. But this is not general at all.
Otherwise I agree with the missing tracker - and calendar options. I committed it. Thanks
sylviedoh! yep you are right this isn't a general solution - I guess I have been steered by my own use of tiki where I avoid using individual permissions and actually I don't let clients/users do that except where it is unavoidable. Instead I always try to use Categories that implement an agreed security policy (for access control that is).
On balance I think the patch could suit some users since showing Feature buttons that the user may not even know about, may be a 'greater problem' than missing some items in a search that have had their permissions individually set.
Need to think harder though since a generic solution should probably still not show the Feature buttons but should include individually 'permitted' items. hmmm tricky!
Geoff
- Priority
- 25
- Demonstrate Bug on Tiki 19+
-
This bug has been demonstrated on show2.tiki.org
Please demonstrate your bug on show2.tiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show2.tiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Demonstrate Bug (older Tiki versions)
-
This bug has been demonstrated on show.tikiwiki.org
Please demonstrate your bug on show.tikiwiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show.tikiwiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Ticket ID
- 2345
- Created
- Saturday 07 March, 2009 22:20:25 UTC
by Unknown - LastModif
- Saturday 06 July, 2024 10:21:44 UTC