Workflow Process Activities not showing up on Admin Process Activities screen

• Error
• Usability

I recently wiped my 1.9.7 install of Galaxia and replaced it from today's BRANCH-1.9 distribution. I am noticing that when I create a new process in the Admin Processes screen, it will auto-create the start and end activities in the galaxia_activities table. This is fine and dandy.

When I go to the Admin Process Activities screen to manipulate and add more activities, the start and end activities do not show up in the Process Activities list. It does report at the top of the screen that there are errors (such as start being interactive but no role assigned, and must use a particular method), but they appear invisible.

I also added a unique activity via this screen that does show up in the database as well, but it isn't showing up on the activity list from the Admin screen.

Interestingly though, I can go to the Monitor Activities screen, and there they are.

This is a significant roadblock to usability. I'll see if I can find what's causing it, but I'm having trouble deciphering a lot of it. Each script farms out to three or four others, which I'm not used to, so by the time I find the statement I'm looking for, I'm 5 scripts deep, and have to go back to get context. Difficult to troubleshoot.

kerrnel22 BRANCH-1-9 * tiki/lib/Galaxia/src/ProcessManager/ActivityManager.php: FIX Activity manager fixed so it now shows activities for new workflow installations.

It doesn't seem to be a problem on the Workflow site, but so far in the several installations of tiki I've got running on test boxes, I have always had the problem in Tiki 1.9x where I can create a process in the Process Manager, however when I selected "activities" nothing would ever come up.

Investigation into the db shows that there are always start and end activities created, but you can never see them on new wiki installs.

The reason for this was an obscure SQL query that tried to select a distinct query from two different tables: the activities table, and the activity_roles table, to build its activity list. Obviously, in a new installation, you will not have any entries in the activity_roles table, and from what I can gather, the SQL query will fail every time, unless there is something populated in both tables. If there's nothing in one of them, it will return nothing. It's a catch-22 because without the Activity Manager actually showing you the activities, you can't assign any roles to them.

So I put in a quick check to see if there are no entries (basically, a new install) in the activity_roles table, and if that's the case, then ignore that table in the list query. If stuff does exist, I allow the query to run as intended.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org

This bug has been demonstrated on show.tikiwiki.org

Please demonstrate your bug on show.tikiwiki.org