Loading...
 
Skip to main content

'Last Changed' module formatting is inconsistent

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
'Last Changed' module formatting is inconsistent
Version
1.9.x
Category
  • Usability
  • Consistency
Feature
Theme: Look & feel, Styles, CSS, Theme Control Center
Modules
Resolution status
Works For Me
Submitted by
jhwheuer
Volunteered to solve
jhwheuer
Lastmod by
jhwheuer
Rating
(0)
Description

I had my issues with the way the module mod-last_modif_pages.tpl rendered... the title could be hidden by a "decorations=n" which made the link to the addition changes vanish, plus the link in the module title is a little bit of a break with the remaining styling...

Then I discovered that the module uses a table instead of a OL or UL to format, which is a little bit messy itself.

Solution

This is what my module template now looks like:

Copy to clipboard
{* $Header: /cvsroot/tikiwiki/tiki/templates/modules/mod-last_modif_pages.tpl,v 1.18.2.4 2005/10/04 14:26:23 sylvieg Exp $ *}

{if $feature_wiki eq 'y'}
{if $nonums eq 'y'}
{eval var="{tr}Last `$module_rows` changes{/tr}" assign="tpl_module_title"}
{*{eval var="<a class=\"box-title_link\" href=\"tiki-lastchanges.php\">{tr}Last `$module_rows` changes{/tr}</a>" assign="tpl_module_title"}*}
{else}
{eval var="{tr}Last changes{/tr}" assign="tpl_module_title"}
{*{eval var="<a class=\"box-title_link\" href=\"tiki-lastchanges.php\">{tr}Last changes{/tr}</a>" assign="tpl_module_title"}*}
{/if}
      {if $nonums != 'y'}
         {eval var="ol" assign="changepagelisttype"}
        {else}
         {eval var="ul" assign="changepagelisttype"}
      {/if}
{tikimodule title=$tpl_module_title name="last_modif_pages" flip=$module_params.flip decorations=$module_params.decorations}<{$changepagelisttype} class="changelist">
    {section name=ix loop=$modLastModif}
       <li class="changelist_item">
		{if $absurl == 'y'}
          <a class="linkmodule" href="{$feature_server_name}tiki-index.php?page={$modLastModif[ix].pageName|escape:"url"}" title="{$modLastModif[ix].lastModif|tiki_short_datetime}, {tr}by{/tr} {if $modLastModif[ix].user ne ''}{$modLastModif[ix].user}{else}{tr}Anonymous{/tr}{/if}{if (strlen($modLastModif[ix].pageName) > $maxlen) && ($maxlen > 0)}, {$modLastModif[ix].pageName}{/if}">
        {if $maxlen > 0}{* 0 is default value for maxlen eq to 'no truncate' *}
         {$modLastModif[ix].pageName|escape|truncate:$maxlen:"...":true}
        {else}
         {$modLastModif[ix].pageName|escape}
        {/if}
          </a>
		  {else}
       <a class="linkmodule" href="tiki-index.php?page={$modLastModif[ix].pageName|escape:"url"}" title="{$modLastModif[ix].lastModif|tiki_short_datetime}, {tr}by{/tr} {if $modLastModif[ix].user ne ''}{$modLastModif[ix].user}{else}{tr}Anonymous{/tr}{/if}{if (strlen($modLastModif[ix].pageName) > $maxlen) && ($maxlen > 0)}, {$modLastModif[ix].pageName}{/if}">
        {if $maxlen > 0}{* 0 is default value for maxlen eq to 'no truncate' *}
         {$modLastModif[ix].pageName|escape|truncate:$maxlen:"...":true}
        {else}
         {$modLastModif[ix].pageName|escape}
        {/if}
       </a>
	   {/if}
      </li>
    {/section}
   </{$changepagelisttype}><p style="margin-top=0pt;" align="right"><a href="tiki-lastchanges.php">{tr}More changes...{/tr}</p}>
{/tikimodule}
{/if}

Notice the use of a list instead of a table and the last line of "More changes...". This begged for a new style, "changelist", which looks like this.

Copy to clipboard
.changelist {
    list-style-type: decimal;
    list-style-position: outside;
    margin: 0px;
	width: 10em;
	padding-top: 0pt;
	padding-bottom: 0pt;
	padding-left: 24pt;
	padding-right: 0pt;
}

.changelist_item {

}
Importance
2
Priority
10
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
499
Created
Thursday 02 February, 2006 14:40:07 UTC
by Unknown
LastModif
Sunday 18 June, 2017 23:14:12 UTC


Show PHP error messages