Loading...
 
Skip to main content

Minor Stats bug in tiki-setup.php

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
Minor Stats bug in tiki-setup.php
Version
1.9.x
Category
  • Error
  • Patch
Feature
User Administration (Registration, Login & Banning)
Stats
Resolution status
Works For Me
Submitted by
wbeaver2
Volunteered to solve
wbeaver2
Lastmod by
amette
Rating
(0)
Description
Tiki login page wrongfully increments tiki_pageviews hit count
Solution
Replace this loop
Copy to clipboard
if ($feature_stats == 'y') {
        if (isset($user)) {
                if ($count_admin_pvs == 'y' || $user != 'admin') {
                        if (!isset($section) or ($section != 'chat' and $section != 'livesupport')) {
                                $tikilib->add_pageview();
                        }
                }
        }
}

With this one
Copy to clipboard
if ($feature_stats == 'y') {
        if (isset($user)) { # Bug fix, otherwise next line counts hits for login page (because $user='')
                if ($count_admin_pvs == 'y' || $user != 'admin') {
                        if (!isset($section) or ($section != 'chat' and $section != 'livesupport')) {
                                $tikilib->add_pageview();
                        }
                }
        }
}
Importance
2
Priority
10
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
345
Created
Monday 26 September, 2005 16:26:23 UTC
by Unknown
LastModif
Sunday 18 June, 2017 23:14:12 UTC


Show PHP error messages