IE7 problem with the "Show/Hide menu " javascript (patch now attached as a workaround)
- Status
- Closed
- Subject
- IE7 problem with the "Show/Hide menu " javascript (patch now attached as a workaround)
- Version
- 2.x
- Category
- Error
- Patch
- Feature
- Browser Compatibility
- Resolution status
- Fixed or Solved
- Submitted by
- Geoff Brickell
- Lastmod by
- Geoff Brickell
- Rating
- Description
With version 2.2 (not checked previous versions) using the "Show/Hide Menus" option to collapse a left or right hand column with IE7 gives page errors and does not execute. Error message says:
Line 409
Char 4
Error: Could not get the display property. Invalid argument.
Code:0
URL: http://dev.tikiwiki.org/tiki-index.php
Function works fine in FF3 and (surprisingly) IE6 but gives exactly the same problem across a number of different tiki sites with IE7, including dev.tikiwiki.org.
The error message (it is assumed) refers to the function flip(foo,style) in lib/tiki-js.js
FIXED
- Files
- Workaround
A colleague who understands javascript (since I certainly don't!) has resolved this issue for me and I have created a patch that works. Its a bit crude/inelegant and does not look at any consequences across other areas of the tiki-js.js or the imminent arrival of IE8, but ...
... the issue is that the variable iewin is only initialised in the function browser to only detect IE5 and IE6, using an intermediate variable ie56. The patch therefore simply adds a new variable ie567 and iewin7 and uses iewin7 for the conditional test in the flip function. I've attached an updated copy of tiki-js.js for anyone that wants it.
- Importance
- 9
- Priority
- 45
- Demonstrate Bug on Tiki 19+
-
This bug has been demonstrated on show2.tiki.org
Please demonstrate your bug on show2.tiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show2.tiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Demonstrate Bug (older Tiki versions)
-
This bug has been demonstrated on show.tikiwiki.org
Please demonstrate your bug on show.tikiwiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show.tikiwiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Ticket ID
- 2112
- Created
- Thursday 30 October, 2008 17:58:46 UTC
by Unknown - LastModif
- Saturday 06 July, 2024 10:21:44 UTC