Loading...
 
Skip to main content

The field with the smilies does not appear in places where they should be available

  • Tracker item actions
Trackers
Items
Status
Pending
Subject
The field with the smilies does not appear in places where they should be available
Version
1.9.x
2.x
Category
  • Usability
Feature
Blog
Forum
WYSIWYG (What You See is What You Get)
Wiki Syntax (text area, parser, external wiki, etc)
Resolution status
New
Submitted by
zorp
Rating
(0)
Description

In certain instances when editing a page through the text editor (or creating a new blog post), with the wysiwyg-available available (though hidden) the smilies field is not displayed.

The problem is probably due to the fact that the variable $wysiwyg contains an 'n' if the editor is hidden while in some instances the value is NULL. This is probably because if the wysiwyg feature in admin-features is disabled then the $wysiwyg value is NULL, but if it is enabled but hidden the value is 'n'.

There is a conditional in templates/tiki-editpage.tpl that does not take this into account.

(The problem may be present in other versions as well)

Solution

In order to resolve the issue in in templates/tiki-editpage.tpl
replace
{if $prefs.feature_smileys eq 'y'&&(!$wysiwyg}

with
{if $prefs.feature_smileys eq 'y'&&(!$wysiwyg || $wysiwyg eq 'n')}

The later conditional checks for the NULL value as well as the 'n' value

NOTE: the same faulty conditional may be found in templates/tiki-blog_post.tpl and posibly other places as well!!! templates/tiki-view_forum.tpl uses several calls to check for smilies as well but I haven't examined these.

Importance
3
Priority
15
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
1786
Created
Tuesday 27 May, 2008 13:03:30 UTC
by Unknown
LastModif
Tuesday 27 May, 2008 13:03:30 UTC


Show PHP error messages