Loading...
 
Skip to main content

Incorrect number of pages in forum posts

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
Incorrect number of pages in forum posts
Version
1.9.x
Category
  • Error
Feature
Forum
Resolution status
Fixed or Solved
Submitted by
Dimitris Moraitis
Volunteered to solve
luci
Lastmod by
amette
Rating
(0)
Description

Since some time now the number of pages in forum posts is completely wrong. It seems that the blame goes to luciash who commited the following patch. It's supposed to fix the comments count but it also breaks the page count.

Copy to clipboard
---
Update of /cvsroot/tikiwiki/tiki
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv22684

Modified Files:
      Tag: BRANCH-1-9
        comments.php 
Log Message:
fixed comments count

Index: comments.php
===================================================================
RCS file: /cvsroot/tikiwiki/tiki/comments.php,v
retrieving revision 1.31.2.25
retrieving revision 1.31.2.26
diff -u -d -r1.31.2.25 -r1.31.2.26
--- comments.php        10 Apr 2005 04:42:37 -0000      1.31.2.25
+++ comments.php        28 Apr 2005 15:15:13 -0000      1.31.2.26
@@ -464,7 +464,7 @@
        $comments_offset, $_REQUEST["comments_maxComments"], $_REQUEST["comments_sort_mode"], $_REQUEST["comments_commentFind"],
        $_REQUEST['comments_threshold'], $_REQUEST["comments_style"], $threadId_if_reply);
 
-$comments_cant = $comments_coms['cant'];
+$comments_cant = $commentslib->count_comments($comments_objectId);
 
 $smarty->assign('comments_below', $comments_coms["below"]);
 $smarty->assign('comments_cant', $comments_cant);

Solution

fixed for upcoming 1.9.1

1.9.1 has been - closed that one

Importance
6
Priority
30
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
178
Created
Thursday 12 May, 2005 18:34:37 UTC
by Unknown
LastModif
Friday 07 October, 2005 00:06:54 UTC


Show PHP error messages