Loading...
 
Skip to main content

Markdown plugin does not parse quoted text properly

  • Tracker item actions
Trackers
Items
Status
Closed
Subject
Markdown plugin does not parse quoted text properly
Version
20.x
Category
  • Bug
Feature
Wiki Syntax (text area, parser, external wiki, etc)
Resolution status
Fixed or Solved
Submitted by
Saša Janiška
Volunteered to solve
luci
Lastmod by
Saša Janiška
Rating
(0)
Related-to
Description

Hello,

While trying to convert some blog posts to Tiki by using Markdown plugin I noticed several problems...First one is that when using quoted text, Tiki does not parse it properly.

Here is the text snippet:

-+Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
tempor incididunt ut labore et dolore magna aliqua. Mauris pharetra et
ultrices neque. Id consectetur purus ut faucibus pulvinar elementum
integer enim. Sed euismod nisi porta lorem mollis. Dui nunc mattis enim
ut tellus elementum sagittis vitae et. Porttitor eget dolor morbi non
arcu risus quis. Aliquam purus sit amet luctus venenatis lectus magna.
Ipsum suspendisse ultrices gravida dictum. In mollis nunc sed id semper
risus in. Arcu risus quis varius quam.

> Mattis rhoncus urna neque viverra justo nec. Aliquet nec ullamcorper
> sit amet. Sit amet venenatis urna cursus eget nunc. Maecenas accumsan
> lacus vel facilisis volutpat est. Consequat ac felis donec et. Aliquam
> vestibulum morbi blandit cursus risus at.

> A diam maecenas sed enim ut sem viverra. Consequat nisl vel pretium
> lectus. Ultricies integer quis auctor elit sed vulputate. Scelerisque
> in dictum non consectetur. Scelerisque eleifend donec pretium
> vulputate sapien nec sagittis aliquam.

A diam maecenas sed enim ut sem viverra. Consequat nisl vel pretium
lectus. Ultricies integer quis auctor elit sed vulputate. Scelerisque in
dictum non consectetur.+-


Here Image you can see how does it look like.

Solution

change the line with $converter = new CommonMarkConverter();
to $converter = new CommonMarkConverter(['html_input' => 'escape', 'allow_unsafe_links' => false]);

Fix committed in http://sourceforge.net/p/tikiwiki/code/70184

Workaround
remove line with $md = htmlentities($md); (UNSAFE!)
Priority
25
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
7089
Created
Saturday 08 June, 2019 15:18:57 UTC
by Saša Janiška
LastModif
Monday 20 January, 2020 13:40:03 UTC


Show PHP error messages